From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C9BAEB64D7 for ; Wed, 21 Jun 2023 08:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d2N9/9UHz9Bg5l4md9y2ysv3bMtH/UayG92YRPbfjlY=; b=3WyVsDQr7VL1ef UV6z0Lm1C96wbN3LkqhzGaJna3kxxAofb5c24Kocyqu2Ot5bMYiOC8KJpvd+bWVngR05d5ZLCq+wC wS4DmNeD7UmRaQeHZSYCSTOtjv0rCHQe8vUOddSxjpZbrtIBuLylZQOSH1T2EcGOB/KrXtNUjfQLd WrxoVLzHXa2ilzzp+sD/bLGyZxSzsABsFyN26FdhdbUlTO9U7UnV1c0qLnFWLsnOo2P6+nJyn/coi mki0i1GJniDWLSy0Kn6m6YrRI2ots9+WZBLM61EC3Lt1o4qmUrImWo4Rpt+2ar91sduK4pyLDkGNL /pyp59tudgAm9V75iESg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBszD-00DfUt-21; Wed, 21 Jun 2023 08:14:43 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBsz9-00DfTe-2R for linux-arm-kernel@lists.infradead.org; Wed, 21 Jun 2023 08:14:41 +0000 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-51bdd67a306so297049a12.3 for ; Wed, 21 Jun 2023 01:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687335278; x=1689927278; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wFzwm0k+gSaYbrmuFD+Ct/zQgWpL6tZz+YLkGnIfg6I=; b=a76tJNOALkltAqWqgtPCU0wkn5mbUJV2rsmN+PBeKjidPCp+KRcctMQIsbMnOFXqL/ XER5GsRnI7gZFjKcMcHgU3I+/zpLLnKSlHODP2Rss0DWWOHR8uYHMkkC3CCRZ7NCPX1F 52d5DkJEg8COvAfOVtYEL/WcdEHsV5qzr9k+utruZmLC/aqazzNlQqonr6t44o+X4EtV Ooz+L2BbiADCJVa9bx3lCwsrppzQuF3aG/tb2G/E+2f//0aGeTmSV03uM8q6wblwg4j8 1FZqvXCB6lTayJCICqlwWiL15Nz2wSWsYJV5VvKzuiWikRWEwTF8vaVYXzb1t24exUqF kjSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687335278; x=1689927278; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wFzwm0k+gSaYbrmuFD+Ct/zQgWpL6tZz+YLkGnIfg6I=; b=XpqfNfF53PJ7YcCNHqy9JE1TNS4/n1VjccKOdg3c9Va3bWpMAMYw2PN4pE4aSgWuPA Q4O2ypsz4mT1MMD2ISudPaSSGKTGvsoosr3dZwkU3Xcb8UCws6mXOrBiL26X/6wIHGAr xv+47vRHqTldpm3MATTUp17xFq+ksL+uFclKuSGzTisDA2aV5szlx3+LKAjdwha7m8uT 4NS0zSuBwScNIFLz9+RkOizl7NDDoUZdJ035Pz+3YGo/iOWep4/eiHRu0LARVaQ7kxHI +MbKqdY8+80hZa27QsdxNsCwZeZ3jzetJ03b9getD6EwRLpnmDq4FxmaEwqrgaPbbE9n IWOQ== X-Gm-Message-State: AC+VfDz8ewvFJ7S0gqR6g/1eT7DEAGQ110s4wWOI16t8N1Wm5fTMn+PH V2Mv/jpD27tz/T49tdcoKx3BNg== X-Google-Smtp-Source: ACHHUZ7UrcFS6J/tH2I6gNeCns11XWXlOjvCQUWbFjRheU0+56SHXKbV3CU9w/ukLC9Ee3IUJHyMhw== X-Received: by 2002:a50:ef19:0:b0:51b:ac91:9f58 with SMTP id m25-20020a50ef19000000b0051bac919f58mr4448024eds.4.1687335277701; Wed, 21 Jun 2023 01:14:37 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id q26-20020aa7cc1a000000b005184165f1fasm2230331edt.5.2023.06.21.01.14.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 01:14:37 -0700 (PDT) Message-ID: Date: Wed, 21 Jun 2023 10:14:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [EXT] Re: [PATCH v6 2/8] dt-bindings: display: bridge: Add Cadence MHDP8501 HDMI and DP Content-Language: en-US To: Sandor Yu , Rob Herring Cc: "andrzej.hajda@intel.com" , "neil.armstrong@linaro.org" , "robert.foss@linaro.org" , "Laurent.pinchart@ideasonboard.com" , "jonas@kwiboo.se" , "jernej.skrabec@gmail.com" , "airlied@gmail.com" , "daniel@ffwll.ch" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "vkoul@kernel.org" , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-phy@lists.infradead.org" , "kernel@pengutronix.de" , dl-linux-imx , Oliver Brown References: <8687f2221299b120e12f29fdccf264e120227bd7.1686729444.git.Sandor.yu@nxp.com> <20230620154856.GB3637514-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_011439_794236_379ED2DB X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/06/2023 04:23, Sandor Yu wrote: >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - cdns,mhdp8501-dp >>> + - cdns,mhdp8501-hdmi >>> + - fsl,imx8mq-mhdp8501-dp >>> + - fsl,imx8mq-mhdp8501-hdmi >> >> Is DP vs. HDMI fixed for a particular SoC implementation or it's a board level >> decision. In the latter case, the type of connector should determine the mode, >> not compatible. > DP or HDMI is bord level decision. Then it's a connector, not compatible. > Because DP and HDMI have different initialize process and less functions could be reuse, so they have different drivers. How do you organize drivers is independent of bindings. > Please check it in patch > [PATCH v6 3/8] drm: bridge: Cadence: Add MHDP8501 DP driver > [PATCH v6 5/8] drm: bridge: Cadence: Add MHDP8501 HDMI driver > > If use the type of connector to determine the mode, hdmi and DP driver have to combine into one driver. > So the compatible may the better choice. Why? Because one driver implementation tells you to do that? Bindings are for hardware, not for driver, so whatever you have to do in drivers is not convincing argument. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel