From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03B8CC433F5 for ; Mon, 23 May 2022 11:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u8t6SO087QQ7+Fh9ZxRXkszcI8HYH7MD4VzDzGpzLzU=; b=08A17RvAKFgRBz CXX8zRxikwJ4GvKZIUwuxshyRXixaXnqN1MakAKJ7Wpdy71offTPvUnbZrW5XFhI2YyWQI91DdEAC N8k+JrYsNnqq75PO4x5GqsaFNY2riZ/0waHRX/fmfTUzx+WIhy6OgK2pXgGczBpCcqygw7c9W1E5g wDH1ab7WLZfDspck55u4S67ujJy7Ye6ynef7wYmmTzUx1ghUjqB0DivzcyZQrBC2BkHjkMt80fqA7 Vzky1Th5ipwenKij1gO0cFo0C0h0up3Ep0hEqP33z0QU0r+aJHEO0reEbPoUrvlES0aM9xIc1trQa n8bc8Nesu/stoP4fA6nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt63k-003cWb-4e; Mon, 23 May 2022 11:17:13 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt5Cd-003CKD-83 for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 10:22:20 +0000 Received: by mail-lf1-x132.google.com with SMTP id j10so1278182lfe.12 for ; Mon, 23 May 2022 03:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=HNshsQ+jjwxazxWRShiy1xQPJQNvQBGxNnmIIrcdM+8=; b=eWB8K4d6dGx2vtV8LZ16/Z5P9sYbaAwVmxtAmLUbP8zPUkxvDrDQ1Zp35Ehg6Xk0Zt f3FnUI2rRroOi5uxhh1TEXOQ51XDnBVWwmZ24lKmC0Agb4jQ8cbQ5f7+nk1jUcyMUde9 B+XSIeGu886HX7x5VNbKhcO/TQ58/5ZvSZ9O6UtO/YaDbkpv4Hk9R5zZK9jE7+dZAAFk c4X/nlbrOwEPtc8yCJ/vIrff9QkxD1kIsV1cADEwBAAloRGQAOEFoN+cfFwKAk0f+xtB qIFX8U69PWug5AiZwTx7hOSU+dKbXMaAVGMnanb+h7faMkHGA0HlsaiZfBAtDRI2xtS9 c2jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HNshsQ+jjwxazxWRShiy1xQPJQNvQBGxNnmIIrcdM+8=; b=3QYL2GXGxmVyTGeU5S3/JiE9XjC4K/pN0w1oW1+gA1Ziz/9RvcWd3dgI4fmgNfQ6Sx fWRJISaaOpjFJhWtTUllyP9tTvLpwp7JRR54rp2wFXGnADGCUGoZAMhG3TLdYaw5yaIP LgAl5mNgbC2600WvKc1pxP7PhXw0QtHLdY6pXM4i1sgaZKpWwko4Z4JsDgE+4o4hpQIL 21Dt7kzPLqroQWz8ZOXnrbO+7WwZ2DiLu5efiQvBSvK0f7b2HSQcVr6hdpaE4Vz91oXI xbaAISoekDoj/w6bsNUlq0SqEv6FLA3flYThn8AYD+Y5NfBl+Fo1T6APN5bXFg5aE/aJ 8fnw== X-Gm-Message-State: AOAM5313jbKibrxrDWd6wljnlDf3T7ldA4dlhCOi2gWdyW481erF1JuK SHk/lu6jMa83Q4yNNpveItV+vA== X-Google-Smtp-Source: ABdhPJwlll0aDgo5Ev/QIHW25Kv2LtXA5WwszdfvpkXDcLDBMOGt9NFWl0tHQ0BayjkbbGmbr4cMEw== X-Received: by 2002:a05:6512:401d:b0:478:69b9:2a39 with SMTP id br29-20020a056512401d00b0047869b92a39mr5175918lfb.500.1653301335563; Mon, 23 May 2022 03:22:15 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id d11-20020a0565123d0b00b0047862c69e83sm1032131lfv.40.2022.05.23.03.22.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 03:22:15 -0700 (PDT) Message-ID: Date: Mon, 23 May 2022 12:22:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 3/3] arm64: dts: fsd: Add ADC device tree node Content-Language: en-US To: Tamseel Shams , jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, krzk+dt@kernel.org Cc: geert@linux-m68k.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, alim.akhtar@samsung.com, paul@crapouillou.net, linux-fsd@tesla.com References: <20220520145820.67667-1-m.shams@samsung.com> <20220520145820.67667-4-m.shams@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220520145820.67667-4-m.shams@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_032219_354038_D3BB45A6 X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/05/2022 16:58, Tamseel Shams wrote: > From: Alim Akhtar > > This patch adds ADC device tree node and enables the same > on fsd platform. > > Signed-off-by: Alim Akhtar > Signed-off-by: Tamseel Shams > --- > - Changes since v1 > * Addressed Krzysztof's comment for corrections in dt files > > arch/arm64/boot/dts/tesla/fsd-evb.dts | 4 ++++ > arch/arm64/boot/dts/tesla/fsd.dtsi | 11 +++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts > index 5af560c1b5e6..63f26a85053a 100644 > --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts > +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts > @@ -34,6 +34,10 @@ > clock-frequency = <24000000>; > }; > > +&adc { > + status = "okay"; Please test your bindings (`make dtbs_check`). There is no way it passes since you miss at least supply (maybe more?). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel