From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH V2 2/3] soc: qcom: boot_stat: Add Driver Support for Boot Stats
Date: Wed, 12 Apr 2023 10:21:18 +0200 [thread overview]
Message-ID: <d05e1184-ead4-3f80-4c06-ff757a10ba3b@linaro.org> (raw)
In-Reply-To: <5eeeb46e9b3f61656a37cb77c2ad6a04e383c16d.1680874520.git.quic_schowdhu@quicinc.com>
On 07/04/2023 16:04, Souradeep Chowdhury wrote:
> All of Qualcomm's proprietary Android boot-loaders capture boot time
> stats, like the time when the bootloader started execution and at what
> point the bootloader handed over control to the kernel etc. in the IMEM
> region. This information is captured in a specific format by this driver
> by mapping a structure to the IMEM memory region and then accessing the
> members of the structure to print the information. This information is
> useful in verifying if the existing boot KPIs have regressed or not.
> A sample log in SM8450(waipio) device is as follows:-
>
> +
> +static int boot_stats_probe(struct platform_device *pdev)
> +{
> + struct device_node *np_mpm2;
> + struct device *boot_stat = &pdev->dev;
> +
> + boot_stats = of_iomap(boot_stat->of_node->child, 0);
> + if (!boot_stats)
> + return dev_err_probe(&pdev->dev, -ENOMEM,
> + "failed to map imem region\n");
> +
> + np_mpm2 = of_find_compatible_node(NULL, NULL,
> + "qcom,mpm2-sleep-counter");
This is undocumented and non-existing compatible. No, we cannot take this.
Also, referencing other nodes should be with phandles, not compatibles.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-12 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 14:04 [PATCH V2 0/3] soc: qcom: boot_stats: Add driver support for boot_stats Souradeep Chowdhury
2023-04-07 14:04 ` [PATCH V2 1/3] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM Souradeep Chowdhury
2023-04-12 8:15 ` Krzysztof Kozlowski
2023-04-12 14:17 ` Souradeep Chowdhury
2023-04-12 8:19 ` Krzysztof Kozlowski
2023-04-07 14:04 ` [PATCH V2 2/3] soc: qcom: boot_stat: Add Driver Support for Boot Stats Souradeep Chowdhury
2023-04-07 15:41 ` Bjorn Andersson
2023-04-10 6:48 ` Souradeep Chowdhury
2023-04-12 8:17 ` Krzysztof Kozlowski
2023-04-12 14:22 ` Souradeep Chowdhury
2023-04-12 8:21 ` Krzysztof Kozlowski [this message]
2023-04-12 14:25 ` Souradeep Chowdhury
2023-04-07 14:04 ` [PATCH V2 3/3] MAINTAINERS: Add the entry for boot_stats driver support Souradeep Chowdhury
2023-04-07 15:44 ` [PATCH V2 0/3] soc: qcom: boot_stats: Add driver support for boot_stats Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d05e1184-ead4-3f80-4c06-ff757a10ba3b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_schowdhu@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).