From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58F24EB64DA for ; Wed, 19 Jul 2023 06:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wPonbM/vtQboj7wSthxUwtPKzDTQkQxMR9A330hri1w=; b=o5RqqUJdSInjIB J7Ed/iAehi/970sitdFcDmDZ0qHauNeFfxqG1yPIqGWN4ogBegwJhTVZs+bL+T4oYIQ2IoRCBGYrZ l3IZM/FrX9hJ41A54D+EvSQDXSRmBTse1v24boK0znDYYmtuhglACwtAPT3zMhpaeLqOM/bnAHOBA asgZUydxE0vul47OPJwbbfaQD6f004hIuN7MCnkA+GX21+th0CBByrvdiCGCxAaTMgOQ/nKCUD+KJ ntGOPALlO9Fin/sNaS83pVi3Vc00SKD+0j7xzsajyic3ztzfK4OivDIBBIwrz3QBIZzqbuX7hJose 22I5QzVUDz4wcynzEeug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM0cG-005iFa-1r; Wed, 19 Jul 2023 06:24:52 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM0cE-005iDj-1X for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 06:24:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=G6/8N7r9NBloAE8WS8tLLSB/dGe92+uxsdAAiPO77KA=; b=Tk56M5YoVFxecGddoC10/UzvXt lmwiYffAlvEK8+izptVVw5a1jIPlBhKbzgy6vhTboNL0Npu/4TUo0ouocTywNQyjdPLwZzLzwjGz9 pCk5sFIeM55V3YT5vXJmkgaiuzqbblpFwlSm+PTy5T8CT+m+G0hR/7cBUVhtc1CZTbf+CF37tHWRH gOfjBCb7/dhYcbiJl4Ujl/I6kmt5l7Wmj0345ZaCileggHabTOGLOp3VP32OSDZ9Gg4ljDxsG7/zh I/h8bljBSP3XqrRoaNbUTJnL3BOLzFHxvj4EPHwD0tkZdrO/LDhKmQ3Jy7u7qYb/Q7VvzMp+5DDNh YtGg2e6w==; Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLpCF-00Brxe-27 for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2023 18:13:18 +0000 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-986d8332f50so780584466b.0 for ; Tue, 18 Jul 2023 11:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689703929; x=1692295929; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G6/8N7r9NBloAE8WS8tLLSB/dGe92+uxsdAAiPO77KA=; b=oSI5k08opg8zIeSQxaPflm1lUXIVvEVqYOhxD5tQkyFBV9gAnPEVEtqCR7dFYvDnic FKVy0HWkhEdYW+u5H1UtrjyeUd8iz6aKE9BaZ4L+cACl/hpOFCPK+8sPFWdVpJBLV+CL 59rLvRBit9BkPeXWDCpWH7hbAJnmN6A1RJBEU5IHrbcZAH2KFldaHd6v7Zh3FknlJRzF eZeruZcmHuJoH0lrGlXVGIqtGXXbsi+mhxw+r11eMPH2QPMay8CHMTq6VpP1Jp3upmoi Qao4AkWOxolfnm2BsSJ9jivCxGsCEjwHObpF4aoxWctu44LdrK7ZYJw8wqQoy2rH7x33 R3Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689703929; x=1692295929; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G6/8N7r9NBloAE8WS8tLLSB/dGe92+uxsdAAiPO77KA=; b=HfABzZnbNMWwi4zGCy/w7QyLAHViiyWvww3mK6ZLLvlY7jr8eEo88ig/xNZUOiJoaT GZgh/bWes6ajrBiUZUX2E74rgwFqtugqxk7JU1GsyvmYTGCUe1Yjp7bQNAO82hIJnQDJ MBvxwlD/ocphXtzUwD+NvTxjLhvYzW9QtIBzMUWpPBjtVQAdDhZUYsiGHPJH5UDF/siL /DpPZEC5OtS7XsfN8l/akeLF1N0e/EteisyXf12E9xYXZNQEWvhB06Pwo+wZvPQHH3ZB 59c6SjsZn3Av7s7VDs3oL4bZDRqa6J66LjHR+pYuktPcaGxMEvF636IiobHsvvEnCJFR Rdhg== X-Gm-Message-State: ABy/qLYRBTGUABBi2PWAODnHoOU3zJWtyVnt5Q1T6zW5kOOubMmY3N5g pawy9k3vfpqexOztSImUcIUGeg== X-Google-Smtp-Source: APBJJlHUEk+vIobvihIcsA3RE38Sv2dNpXe0EbyH+S5eZL1H+p8M7mY2hqQI/VxXI2DspF2gjXgJTA== X-Received: by 2002:a17:907:a48:b0:98a:29ca:c58e with SMTP id be8-20020a1709070a4800b0098a29cac58emr599294ejc.27.1689703929650; Tue, 18 Jul 2023 11:12:09 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id sb6-20020a170906edc600b009888aa1da11sm1272105ejb.188.2023.07.18.11.12.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 11:12:09 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 20:12:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] dt-bindings: arm: Add qcom specific hvc transport for SCMI Content-Language: en-US To: Nikunj Kela , sudeep.holla@arm.com Cc: cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20230718160833.36397-2-quic_nkela@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230718160833.36397-2-quic_nkela@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_191315_941763_18E6C64B X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/07/2023 18:08, Nikunj Kela wrote: > Introduce compatible "qcom,scmi-hvc-shmem" for SCMI > transport channel for Qualcomm virtual platforms. > The compatible mandates a shared memory channel. > > Signed-off-by: Nikunj Kela > --- > .../bindings/firmware/arm,scmi.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index b138f3d23df8..605b1e997a85 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -45,6 +45,9 @@ properties: > - description: SCMI compliant firmware with OP-TEE transport > items: > - const: linaro,scmi-optee > + - description: SCMI compliant firmware with Qualcomm hvc/shmem transport > + items: > + - const: qcom,scmi-hvc-shmem > > interrupts: > description: > @@ -321,6 +324,16 @@ else: > required: > - linaro,optee-channel-id > > + else: > + if: > + properties: > + compatible: > + contains: > + const: qcom,scmi-hvc-shmem > + then: > + required: > + - shmem Unfortunately this pattern if-else-if-else-if-else does not scale well. Please convert all entries first to allOf:if:then,if:then,if:then (in new patch), and then add new if:then: > + > examples: > - | > firmware { > @@ -444,6 +457,62 @@ examples: > }; > }; > > + - | > + firmware { > + scmi_dpu { No underscores in node names. Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "qcom,scmi-hvc-shmem"; > + shmem = <&shmem_dpu>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + scmi_pd_dpu: protocol@11 { > + reg = <0x11>; > + #power-domain-cells = <1>; > + }; > + }; > + Add only one example, but then only if it differs significantly. I see no differences - except compatible - so maybe no point of examples. > + scmi_gpu { > + compatible = "qcom,scmi-hvc-shmem"; > + shmem = <&shmem_gpu>; This example for sure is not needed - you duplicate above. > + > + interrupts = ; > + interrupt-names = "a2p"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + scmi_pd_gpu: protocol@11 { > + reg = <0x11>; > + #power-domain-cells = <1>; > + }; > + }; > + }; > + > + soc { > + #address-cells = <1>; > + #size-cells = <1>; > + > + sram@95c00000 { > + compatible = "mmio-sram"; > + reg = <0x95c00000 0x10000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + shmem_dpu: scmi-sram-dpu@95c00000 { > + compatible = "arm,scmi-shmem"; > + reg = <0x95c00000 0x3f0>; > + }; How does these differ from existing example? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel