From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: Manikandan Muralidharan <manikandan.m@microchip.com>,
sam@ravnborg.org, bbrezillon@kernel.org, airlied@gmail.com,
daniel@ffwll.ch, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, lee@kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Hari.PrasathGE@microchip.com,
Balamanikandan.Gunasundar@microchip.com,
Durai.ManickamKR@microchip.com, Nayabbasha.Sayed@microchip.com,
Dharma.B@microchip.com, Varshini.Rajendran@microchip.com,
Balakrishnan.S@microchip.com
Subject: Re: [PATCH v4 7/8] drm: atmel-hlcdc: add vertical and horizontal scaling support for XLCDC
Date: Sat, 9 Sep 2023 19:26:42 +0300 [thread overview]
Message-ID: <d0652f8f-deb1-0fa7-54ab-c2df1a333e9f@tuxon.dev> (raw)
In-Reply-To: <20230825125444.93222-8-manikandan.m@microchip.com>
On 8/25/23 15:54, Manikandan Muralidharan wrote:
> update the LCDC_HEOCFG30 and LCDC_HEOCFG31 registers of XLCDC IP which
s/update/Update
> supports vertical and horizontal scaling with Bilinear and Bicubic
> co-efficients taps for Chroma and Luma componenets of the Pixel.
>
> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 ++
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 4 ++++
> .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 20 +++++++++++++++++++
> 3 files changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> index d30aec174aa2..ae3e1a813482 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> @@ -536,6 +536,8 @@ static const struct atmel_hlcdc_layer_desc atmel_xlcdc_sam9x75_layers[] = {
> .general_config = 12,
> .csc = 16,
> .scaler_config = 23,
> + .vxs_config = 30,
> + .hxs_config = 31,
> },
> .clut_offset = 0x1300,
> },
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h
> index 8b05a54b5fd0..27074a4c5aec 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h
> @@ -198,6 +198,8 @@
> * @disc_pos: discard area position register
> * @disc_size: discard area size register
> * @csc: color space conversion register
> + * @vxs_config: vertical scalar filter taps control register
> + * @hxs_config: horizontal scalar filter taps control register
> */
> struct atmel_hlcdc_layer_cfg_layout {
> int xstride[ATMEL_HLCDC_LAYER_MAX_PLANES];
> @@ -217,6 +219,8 @@ struct atmel_hlcdc_layer_cfg_layout {
> int disc_pos;
> int disc_size;
> int csc;
> + int vxs_config;
> + int hxs_config;
> };
>
> /**
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> index 26caf4cddfa4..a06ae2dc5909 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> @@ -972,6 +972,26 @@ static void xlcdc_csc_init(struct atmel_hlcdc_plane *plane,
> atmel_hlcdc_layer_write_cfg(&plane->layer,
> desc->layout.csc + i,
> xlcdc_csc_coeffs[i]);
> +
> + if (desc->layout.vxs_config && desc->layout.hxs_config) {
> + /*
> + * Updating vxs.config and hxs.config fixes the
> + * Green Color Issue in SAM9X7 EGT Video Player App
> + */
> + atmel_hlcdc_layer_write_cfg(&plane->layer,
> + desc->layout.vxs_config,
> + ATMEL_XLCDC_LAYER_VXSYCFG_ONE |
> + ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE |
> + ATMEL_XLCDC_LAYER_VXSCCFG_ONE |
> + ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE);
> +
> + atmel_hlcdc_layer_write_cfg(&plane->layer,
> + desc->layout.hxs_config,
> + ATMEL_XLCDC_LAYER_HXSYCFG_ONE |
> + ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE |
> + ATMEL_XLCDC_LAYER_HXSCCFG_ONE |
> + ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE);
> + }
> }
>
> static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-09 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 12:54 [PATCH v4 0/8] Add support for XLCDC to sam9x7 SoC family Manikandan Muralidharan
2023-08-25 12:54 ` [PATCH v4 1/8] mfd: atmel-hlcdc: Add compatible for sam9x75 XLCD controller Manikandan Muralidharan
2023-08-25 12:54 ` [PATCH v4 2/8] drm: atmel-hlcdc: add flag to differentiate XLCDC and HLCDC IP Manikandan Muralidharan
2023-08-25 12:54 ` [PATCH v4 3/8] drm: atmel-hlcdc: add LCD controller layer definition for sam9x75 Manikandan Muralidharan
2023-08-25 12:54 ` [PATCH v4 4/8] drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers Manikandan Muralidharan
2023-09-09 15:50 ` claudiu beznea
2023-08-25 12:54 ` [PATCH v4 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver Manikandan Muralidharan
2023-09-09 16:20 ` claudiu beznea
2023-09-12 10:44 ` Manikandan.M
2023-09-18 4:30 ` claudiu beznea
2023-08-25 12:54 ` [PATCH v4 6/8] drm: atmel-hlcdc: add DPI mode support for XLCDC Manikandan Muralidharan
2023-09-09 16:25 ` claudiu beznea
2023-08-25 12:54 ` [PATCH v4 7/8] drm: atmel-hlcdc: add vertical and horizontal scaling " Manikandan Muralidharan
2023-09-09 16:26 ` claudiu beznea [this message]
2023-08-25 12:54 ` [PATCH v4 8/8] drm: atmel-hlcdc: add support for DSI output formats Manikandan Muralidharan
2023-09-09 16:32 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0652f8f-deb1-0fa7-54ab-c2df1a333e9f@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=Balakrishnan.S@microchip.com \
--cc=Balamanikandan.Gunasundar@microchip.com \
--cc=Dharma.B@microchip.com \
--cc=Durai.ManickamKR@microchip.com \
--cc=Hari.PrasathGE@microchip.com \
--cc=Nayabbasha.Sayed@microchip.com \
--cc=Varshini.Rajendran@microchip.com \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikandan.m@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).