From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B46DDEE3EC2 for ; Sat, 9 Sep 2023 16:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QckhhAPtp0e2IRGWHfGZtmaBtA8tCnv1TdRfLZLu/Kw=; b=A4y9AOvBpkQvxw pC2i2STeJCvQ7rH8PcpbgoQ/zmN1ID9fkWqPJpGA4cdyvWtcroHQPMKmFUyGn0RlCJQUKsmQsqcP2 xGgC8HpYBklPuZ8YXXwyiSPOf5iDm2v/pbGfMv7W1+XeTAdW2L5CDjFq8DpqIAu5ZlmdBpPuT6oCM Oye/Bcnp+KvnoMlZLNHOoSwKSJwEx1tavvCTnozQxm6YnUqlF4wDmj5CknsBfxXlZ13UuVtVCGvnH B0PMsU4O2EFIyViRjtl8kh2q/al0mieWuVPfzLhwDMV0uWkFY3w1txRpZvBnyJkYK/6AmQy2KwcU5 DLNrzQDDGpUaL/FH/JMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qf0nJ-00FdPy-2j; Sat, 09 Sep 2023 16:26:49 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qf0nH-00FdPE-1N for linux-arm-kernel@lists.infradead.org; Sat, 09 Sep 2023 16:26:48 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-52bcb8b199aso3978919a12.3 for ; Sat, 09 Sep 2023 09:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1694276804; x=1694881604; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gErk2fmDPN9zspW0gxfBB3yKqfpmHz9a2nWUFiDbRqE=; b=pY7bJVrk1v9P5lfsDurpcxMo1Wi1AiWm0vFthd2xZVZbR0PvAAYRV1PF7eLx1DxhJa VAE58AkbOgtXJqg4lIWeCqagBghwaqaYmDxn/g2hp0wxFT9u5RoCI2x5/l4DKEX7uq4A Rhd81FwHSEluEXKqMzBgK16ek02clPD0+vUqDDsKW2ExOWPua3tCif9yOgA17h44CnHj 1VALfLTEB3eQOv30uD8+MJasDkQXgUvACX8oZbYUygt3H9YvVxJ9sRABjBvZqbIfC3KG 4oTCWynJGVFmqMV7kIHNcsrkwxl8lv5B/61dpv1Rb18iOB3wVpGBfQ05xvVDJPAIaP4j INYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694276804; x=1694881604; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gErk2fmDPN9zspW0gxfBB3yKqfpmHz9a2nWUFiDbRqE=; b=X+DixkB6zKV0lD8EoykfVNLbQqYD8Hvz9+WjWvRkjvyVZU1mOLV6jTUUGtaNLeqRwF 6n1F2amlyL8yWBAmjqujR2lyt8E0IaC0T9OiuTPUWpxbdHTSUaldZai0b2DUGvrQiWIa OeAxmessF1tG5XVj5bLcs48QrxENb/gVXzBP1fjyyYmsgvMzTIKiaVeoZNSCrK3C62li mF/GBic2Gs3COOEPzs5y6GdezJMbVqIGB4MP4isWNZNQPv1ET/yF5xFOEnoe9jAqjXJo iLi0KfrJnqVo8sOvwL+JWH2xUiKn63ijYF/T9JnbtyITrpcvxt7+Xi9TdZV8Qx76UVkp zJmg== X-Gm-Message-State: AOJu0YzvUTo23dwS5g4toeo3iy6nhUT7/Pj/d7aTVWjigxhu38JdwXVd D7b7P2e1VHfA4V+vsKowXI/OcA== X-Google-Smtp-Source: AGHT+IFgt36OdnvJBSVSriNawPcCIHp40ArBHJDt/BFPQWS2kGOmdHyNu//mVtsP3fu82deHfqRT7g== X-Received: by 2002:a50:ed03:0:b0:52a:1d9c:83ff with SMTP id j3-20020a50ed03000000b0052a1d9c83ffmr4307642eds.1.1694276804644; Sat, 09 Sep 2023 09:26:44 -0700 (PDT) Received: from [192.168.32.2] ([82.78.167.145]) by smtp.gmail.com with ESMTPSA id l15-20020aa7d94f000000b0052338f5b2a4sm2327139eds.86.2023.09.09.09.26.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Sep 2023 09:26:44 -0700 (PDT) Message-ID: Date: Sat, 9 Sep 2023 19:26:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v4 7/8] drm: atmel-hlcdc: add vertical and horizontal scaling support for XLCDC Content-Language: en-US To: Manikandan Muralidharan , sam@ravnborg.org, bbrezillon@kernel.org, airlied@gmail.com, daniel@ffwll.ch, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, lee@kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Hari.PrasathGE@microchip.com, Balamanikandan.Gunasundar@microchip.com, Durai.ManickamKR@microchip.com, Nayabbasha.Sayed@microchip.com, Dharma.B@microchip.com, Varshini.Rajendran@microchip.com, Balakrishnan.S@microchip.com References: <20230825125444.93222-1-manikandan.m@microchip.com> <20230825125444.93222-8-manikandan.m@microchip.com> From: claudiu beznea In-Reply-To: <20230825125444.93222-8-manikandan.m@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230909_092647_471789_C10870D8 X-CRM114-Status: GOOD ( 20.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/25/23 15:54, Manikandan Muralidharan wrote: > update the LCDC_HEOCFG30 and LCDC_HEOCFG31 registers of XLCDC IP which s/update/Update > supports vertical and horizontal scaling with Bilinear and Bicubic > co-efficients taps for Chroma and Luma componenets of the Pixel. > > Signed-off-by: Manikandan Muralidharan > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 ++ > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 4 ++++ > .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 20 +++++++++++++++++++ > 3 files changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > index d30aec174aa2..ae3e1a813482 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c > @@ -536,6 +536,8 @@ static const struct atmel_hlcdc_layer_desc atmel_xlcdc_sam9x75_layers[] = { > .general_config = 12, > .csc = 16, > .scaler_config = 23, > + .vxs_config = 30, > + .hxs_config = 31, > }, > .clut_offset = 0x1300, > }, > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > index 8b05a54b5fd0..27074a4c5aec 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h > @@ -198,6 +198,8 @@ > * @disc_pos: discard area position register > * @disc_size: discard area size register > * @csc: color space conversion register > + * @vxs_config: vertical scalar filter taps control register > + * @hxs_config: horizontal scalar filter taps control register > */ > struct atmel_hlcdc_layer_cfg_layout { > int xstride[ATMEL_HLCDC_LAYER_MAX_PLANES]; > @@ -217,6 +219,8 @@ struct atmel_hlcdc_layer_cfg_layout { > int disc_pos; > int disc_size; > int csc; > + int vxs_config; > + int hxs_config; > }; > > /** > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > index 26caf4cddfa4..a06ae2dc5909 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > @@ -972,6 +972,26 @@ static void xlcdc_csc_init(struct atmel_hlcdc_plane *plane, > atmel_hlcdc_layer_write_cfg(&plane->layer, > desc->layout.csc + i, > xlcdc_csc_coeffs[i]); > + > + if (desc->layout.vxs_config && desc->layout.hxs_config) { > + /* > + * Updating vxs.config and hxs.config fixes the > + * Green Color Issue in SAM9X7 EGT Video Player App > + */ > + atmel_hlcdc_layer_write_cfg(&plane->layer, > + desc->layout.vxs_config, > + ATMEL_XLCDC_LAYER_VXSYCFG_ONE | > + ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE | > + ATMEL_XLCDC_LAYER_VXSCCFG_ONE | > + ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE); > + > + atmel_hlcdc_layer_write_cfg(&plane->layer, > + desc->layout.hxs_config, > + ATMEL_XLCDC_LAYER_HXSYCFG_ONE | > + ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE | > + ATMEL_XLCDC_LAYER_HXSCCFG_ONE | > + ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE); > + } > } > > static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel