From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CD82606A31C for ; Tue, 17 Nov 2026 14:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Pf9sdwhq; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=RldvSNBi DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=2Wq9AE25iea427W8wiH0e2Ewq13PobRIAnClSSphGUw=; b=Pf9sdwhqhHG28D 7JhFtH2fx3ELz8ARiHqBaQPnohL1S4AbFtFyIPT+WVNMI7aR4ji+aT10d+aBX3qXPu+OlNluDJ7ft 2NR+7wCrIKQ/R94XAy+mHiS/UEhAjfNrXEBOIUgPY1eNNX1t/ElxrergU67H+ZZe0GoIAMfPT9Umx fSAWJIXz4jYyYXLt+iPqwB/rwjo/3Qi+Opw3T5nBwWQxEhj6b7FKItL0vz5OzI8q9cnPbHCVysz88 CfFJ2jv+QgxePY+zJOjHVybI/GGQvBkq9kljPJ61sN78UARwuXD2UQUpHdG8v0uVpqUzwac+z4zVw M29qedH2/o4GK/crM1Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTKa2-00000006E0v-3z7w; Tue, 17 Nov 2026 14:54:42 +0000 Received: from smtpout-04.galae.net ([185.171.202.116]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTKZv-00000006Dtw-4BjD for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2026 14:54:41 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id D4D73C79A9B; Tue, 17 Nov 2026 14:54:37 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 49E9E5FD6A; Tue, 17 Nov 2026 14:54:33 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id D187511BC0026; Tue, 17 Nov 2026 15:54:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1794927271; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=2Wq9AE25iea427W8wiH0e2Ewq13PobRIAnClSSphGUw=; b=RldvSNBih/YepnuGq2MmKOY6A9rIpEumELC0ddV1Qgq3r8IhTrV9lLpBVSihJHenq/I5Vm nd/D9MLgGB234C7uQ88P5bQwFSTY+e4TDToHLYcXFPrmuKPTqcBi7dLVsJw32RGbjuDYJq DSpyU8dNw+tl5D0GFkjGBp4MDLolXdsuoCK7TJlQvzelGr+QaF4TV9f8tpXJQK6ktyC3U1 ZIIWLKrlz+S+q7+hhl7LD9tk/gm5zD17LNzTyrGIkcrpSZqz3fehRtbOjXHyJO9Z+zne/f +TVHU/jYSpNFMwbDgip6SnNlQIpAKn1oCFtg8VOPxoboHaMQCZd36nFYvjiQvQ== Message-ID: Date: Tue, 17 Nov 2026 15:54:22 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3 1/3] net: stmmac: honour Rx checksum errors in the AF_XDP zero-copy path To: Christian Schmidbauer , netdev@vger.kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, Oleksij Rempel , stable@vger.kernel.org, Maxime Coquelin , Alexandre Torgue , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Ong Boon Leong , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: <20261114133640.3285413-1-opensource@grische.xyz> <20261114133640.3285413-2-opensource@grische.xyz> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20261114133640.3285413-2-opensource@grische.xyz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261117_065436_939397_37E034CA X-CRM114-Status: GOOD ( 16.47 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Hi, On 11/14/26 14:36, Christian Schmidbauer wrote: > Commit ee0aace5f844 ("net: stmmac: Correctly handle Rx checksum offload > errors") taught stmmac_rx() to honour the csum_none status, but > stmmac_dispatch_skb_zc() still ignores it and sets CHECKSUM_UNNECESSARY > for every IP frame whenever the checksum offload engine (CoE) is > enabled. > > Since commit fe4042797651 ("net: stmmac: dwmac4: stop hardware from > dropping checksum-error packets") dwmac4 delivers such frames instead of > dropping them, so this path receives them. > > Mark the skb CHECKSUM_NONE when csum_none is set, as stmmac_rx() does. > > Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy") > Cc: > Assisted-by: Claude:claude-opus-5-5 > Signed-off-by: Christian Schmidbauer Reviewed-by: Maxime Chevallier Maxime > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 7ffed295eb14..3e5803db19b4 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -5547,7 +5547,7 @@ static struct sk_buff *stmmac_construct_skb_zc(struct stmmac_channel *ch, > > static void stmmac_dispatch_skb_zc(struct stmmac_priv *priv, u32 queue, > struct dma_desc *p, struct dma_desc *np, > - struct xdp_buff *xdp) > + struct xdp_buff *xdp, int status) > { > struct stmmac_rxq_stats *rxq_stats = &priv->xstats.rxq_stats[queue]; > struct stmmac_channel *ch = &priv->channel[queue]; > @@ -5575,7 +5575,8 @@ static void stmmac_dispatch_skb_zc(struct stmmac_priv *priv, u32 queue, > > skb->protocol = eth_type_trans(skb, priv->dev); > > - if (unlikely(!coe) || !stmmac_has_ip_ethertype(skb)) > + if (unlikely(!coe) || !stmmac_has_ip_ethertype(skb) || > + (status & csum_none)) > skb_checksum_none_assert(skb); > else > skb->ip_summed = CHECKSUM_UNNECESSARY; > @@ -5789,7 +5790,8 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue) > > switch (res) { > case STMMAC_XDP_PASS: > - stmmac_dispatch_skb_zc(priv, queue, p, np, buf->xdp); > + stmmac_dispatch_skb_zc(priv, queue, p, np, buf->xdp, > + status); > xsk_buff_free(buf->xdp); > break; > case STMMAC_XDP_CONSUMED: