* [PATCH] firmware: raspberrypi: Change dependency to ARCH_BCM2835 and COMPILE_TEST
@ 2026-04-08 8:11 Chen-Yu Tsai
2026-04-10 17:15 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Chen-Yu Tsai @ 2026-04-08 8:11 UTC (permalink / raw)
To: Florian Fainelli, Broadcom internal kernel review list
Cc: Chen-Yu Tsai, linux-rpi-kernel, linux-arm-kernel, linux-kernel
The Raspberry Pi firmware driver has no compile dependencies on the
BCM2835 mailbox driver. It's just a indirect runtime dependency: the
driver only works on a Raspberry Pi.
Change the dependency from BCM2835_MBOX to ARCH_BCM2835. Also allow
compile tests. This allows drivers that have build time dependencies
on this firmware driver to be compile tested as well.
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/firmware/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index bbd2155d8483..f99d27c1f6a4 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -114,7 +114,7 @@ config ISCSI_IBFT
config RASPBERRYPI_FIRMWARE
tristate "Raspberry Pi Firmware Driver"
- depends on BCM2835_MBOX
+ depends on ARCH_BCM2835 || COMPILE_TEST
help
This option enables support for communicating with the firmware on the
Raspberry Pi.
--
2.53.0.1213.gd9a14994de-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware: raspberrypi: Change dependency to ARCH_BCM2835 and COMPILE_TEST
2026-04-08 8:11 [PATCH] firmware: raspberrypi: Change dependency to ARCH_BCM2835 and COMPILE_TEST Chen-Yu Tsai
@ 2026-04-10 17:15 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2026-04-10 17:15 UTC (permalink / raw)
To: Chen-Yu Tsai, Broadcom internal kernel review list
Cc: linux-rpi-kernel, linux-arm-kernel, linux-kernel
On 4/8/26 01:11, Chen-Yu Tsai wrote:
> The Raspberry Pi firmware driver has no compile dependencies on the
> BCM2835 mailbox driver. It's just a indirect runtime dependency: the
> driver only works on a Raspberry Pi.
>
> Change the dependency from BCM2835_MBOX to ARCH_BCM2835. Also allow
> compile tests. This allows drivers that have build time dependencies
> on this firmware driver to be compile tested as well.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
No objection, however I think this should also have:
default ARCH_BRCM2835
because without the firmware driver there is effectively nothing that
works. See this patch series:
https://lists.infradead.org/pipermail/linux-arm-kernel/2024-May/927679.html
> ---
> drivers/firmware/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index bbd2155d8483..f99d27c1f6a4 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -114,7 +114,7 @@ config ISCSI_IBFT
>
> config RASPBERRYPI_FIRMWARE
> tristate "Raspberry Pi Firmware Driver"
> - depends on BCM2835_MBOX
> + depends on ARCH_BCM2835 || COMPILE_TEST
> help
> This option enables support for communicating with the firmware on the
> Raspberry Pi.
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-10 17:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-08 8:11 [PATCH] firmware: raspberrypi: Change dependency to ARCH_BCM2835 and COMPILE_TEST Chen-Yu Tsai
2026-04-10 17:15 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox