From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D52C433EF for ; Wed, 15 Sep 2021 08:07:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E3A7608FB for ; Wed, 15 Sep 2021 08:07:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0E3A7608FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SRloQRFErxLxm77zVmSY2sTZj6ZCay46Afd7eSnvIQg=; b=qXR5pmWP3IGAxpkgLx3eAMH1fc Q+tIl8zT9X2xwbXCPKAnuLmb0+HMzN5y/xUfkHhT8AnMwEMtet4j/J3cRCXUbJRmInJrZxicWCV2S VjqKI5Zsi/Om9UXDF8rCObgDn+InJUA+1chHk+OI4ELB3PCQHpLQKA0sn96ItAASsR5lorcKmzGAG tRe91I/tv2MVuAfrroo4cea8PCmZ8u9Q3tFxSJIdQfXYq4zesH705GfxI74vMdfI6JXPPZvl8o7qX kS6SMoVkoDsND5Emb2d+skutQ/b8R8cGR7ORpIF1aYC32/QVL2f8aA6T0iEYSS2enX6jxsQh2ZMGI jEgKTgwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQPvt-008Ph0-Vc; Wed, 15 Sep 2021 08:06:18 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQPvq-008Pg3-Bg for linux-arm-kernel@lists.infradead.org; Wed, 15 Sep 2021 08:06:15 +0000 Received: by mail-wr1-x42b.google.com with SMTP id b6so2383822wrh.10 for ; Wed, 15 Sep 2021 01:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZE0PeTRh9qfRZGJNwCzqtIG58jlteNMLdoVqfOwsJSc=; b=PiLZA/X9ua4zt13neVQpgP6jN+QDMTGTzbeUs/sHSbBf+dH/4iYMdnQ8XWtx7dF76q zhaWYh1exDJt+ed9kyDp6D75YhjZXgvgiwL5vpaRy2oa8TcvpfvfqKMOqXZSxdn2a9/L clmXSH4OwOJ0iL8ZZG2hBDHa7BgCsvXyG0/8uj8kMmUJIMf1XZ7Zruhg6ycOwm43vcTL rmn4fcAv2g4zu7yTHQsFbItaDImlg/1glSrU1y7WedAvExdsWcfJukJ0uAePMkfQafdL 9CohDlXmn6ps2tvAuW7EJlbklXwIA8JCwXzvB6bh3Q97hrB+pTjo9zzjmTI7hwYbLLFp j09w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZE0PeTRh9qfRZGJNwCzqtIG58jlteNMLdoVqfOwsJSc=; b=MOzCXumqlKUFGBnwv/HmufJY65NPQLkqSXveZX0572idzb26XsO6eCVIu5l9fYojYB KtFj90S0jl8Kpx0lNWaX8Fr2yvrYjlPbLiO5CHe23iC9oge0rPxJRtUmIv+eSbUuGTBl 1jNDHi9H4ZF8Glgtb2pU5CuOY6Jph9sr51I7Q8sqezrobKkRDqV0fjh+deVeabHBV8l2 HWxpmayG7HwkZ/iNmkbS2SDF+VFr8vEZ3zB9NkH867pYrG66s/MtSNMaRsP1DN8WgBww AQvBDbG/go4/wuIUh/birLQGi+BAQnix31pUyfnzTBI6dHmhpkFvpCoIz04x26GJU3U9 pCMA== X-Gm-Message-State: AOAM532p4hS07RaFt027PmoXBOlN/ZGFZztpiD+d7qXPgaJwLRXVfw9s scM0P6wh3uWOKStUhAOGYgt+lw== X-Google-Smtp-Source: ABdhPJwJ2evMM3o2cbEHd2qfC2Zc9a0Zn5BEoBr1iOPEPLIAfRVXA2v74v/MCXQdflid0JKN7ihvHg== X-Received: by 2002:a5d:4a46:: with SMTP id v6mr3451302wrs.262.1631693171268; Wed, 15 Sep 2021 01:06:11 -0700 (PDT) Received: from ?IPv6:2a00:1098:3142:14:1538:6132:c93a:c98c? ([2a00:1098:3142:14:1538:6132:c93a:c98c]) by smtp.gmail.com with ESMTPSA id j4sm13056800wrt.23.2021.09.15.01.06.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 01:06:10 -0700 (PDT) Subject: Re: [PATCH 1/8] staging: vchiq_arm: replace sleep() with usleep_range() To: Stefan Wahren , Gaston Gonzalez , linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, arnd@arndb.de, dan.carpenter@oracle.com, ojaswin98@gmail.com, amarjargal16@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org References: <20210914213532.396654-1-gascoar@gmail.com> <260b38b8-6f3f-f6cc-0388-09a269ead507@i2se.com> From: Phil Elwell Message-ID: Date: Wed, 15 Sep 2021 09:06:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <260b38b8-6f3f-f6cc-0388-09a269ead507@i2se.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_010614_474968_B6E764E0 X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, On 15/09/2021 06:21, Stefan Wahren wrote: > Hi, > > Am 14.09.21 um 23:35 schrieb Gaston Gonzalez: >> usleep_range() should be used instead of sleep() when sleepings range >> from 10 us to 20 ms, [1]. >> >> Reported by checkpatch.pl >> >> [1] Documentation/timers/timers-howto.txt >> --- >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> index b25369a13452..0214ae37e01f 100644 >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c >> @@ -824,7 +824,7 @@ vchiq_bulk_transmit(unsigned int handle, const void *data, unsigned int size, >> if (status != VCHIQ_RETRY) >> break; >> >> - msleep(1); >> + usleep_range(1000, 1100); > > from my understanding the usage of usleep_range() and hrtimers isn't > necessary here. The intention is to sleep a little bit and not "exactly" > 1 ms. > > @Phil Elwell: what is your opinion? Exactly - the aim is just to stop it spinning. Phil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel