Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: meson: gxbb: fix build error without RESET_CONTROLLER
Date: Tue, 9 May 2017 11:28:16 +0200	[thread overview]
Message-ID: <d0aae880-655a-7306-263d-9b15f2ba2f3f@baylibre.com> (raw)
In-Reply-To: <8556c66c-585f-d171-e2a8-1f59d109e9de@baylibre.com>

On 04/24/2017 12:10 PM, Neil Armstrong wrote:
> On 04/24/2017 12:05 PM, Tobias Regnery wrote:
>> With CONFIG_RESET_CONTROLLER=n we see the following link error in the
>> meson gxbb clk driver:
>>
>> drivers/built-in.o: In function 'gxbb_aoclkc_probe':
>> drivers/clk/meson/gxbb-aoclk.c:161: undefined reference to 'devm_reset_controller_register'
>>
>> Fix this by selecting the reset controller subsystem.
>>
>> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>
>> ---
>>  drivers/clk/meson/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
>> index 19480bcc7046..2f29ee1a4d00 100644
>> --- a/drivers/clk/meson/Kconfig
>> +++ b/drivers/clk/meson/Kconfig
>> @@ -14,6 +14,7 @@ config COMMON_CLK_MESON8B
>>  config COMMON_CLK_GXBB
>>  	bool
>>  	depends on COMMON_CLK_AMLOGIC
>> +	select RESET_CONTROLLER
>>  	help
>>  	  Support for the clock controller on AmLogic S905 devices, aka gxbb.
>>  	  Say Y if you want peripherals and CPU frequency scaling to work.
>>
> 
> Hi Tobias,
> 
> I was going to push this, thanks for the patch !
> 
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> 
> Neil
> 

Applied on fixes/meson-clk-drivers

Thanks,
Neil

      reply	other threads:[~2017-05-09  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24 10:05 [PATCH] clk: meson: gxbb: fix build error without RESET_CONTROLLER Tobias Regnery
2017-04-24 10:10 ` Neil Armstrong
2017-05-09  9:28   ` Neil Armstrong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0aae880-655a-7306-263d-9b15f2ba2f3f@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox