From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F495C48BC3 for ; Tue, 13 Feb 2024 05:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JK8xyLXHhQYkrpHbH4HhgshVfbR1FQYqlqc+lUZ5TxI=; b=dExy0YvueskH03 J3MRufpRZKP5ZzQbn2AWKr8aACE+KZSq+hV2POJcjFF1/GX7VGPDVMvxpiP+nUj56e1QyhIbOJRuL k9wULxUUR0Jt0rQv3dDsVTRT/4afEX6c1D41z6fm6nPAJ2jqb2pI8v32FyXR8zeEwpjrd1DGTDP5f 7VhrD4Ui36BYqpOIyyQRKTM8wBAIiGUiR1B1eZhROIJ/AMJbzYV+/P4uKd98nikXuSH19rTJj5WUY GRgBqFc7UT0X4bgq8uIfif2TXziJ7P9GBDHI4M4RBCLDw3MuvkGri/0skAimIiZhKEJTXWrD3vmMC t0p/R5eNXqUb73ND3TyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZlX7-0000000817T-0kBv; Tue, 13 Feb 2024 05:40:41 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZlX3-00000008174-32L1 for linux-arm-kernel@lists.infradead.org; Tue, 13 Feb 2024 05:40:39 +0000 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41D5CN4E032147; Tue, 13 Feb 2024 05:40:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=bcECAOxG27hb5viVJ2WKDRBPwzybpcZBZwp56T0Hm+M=; b=l0 GhWb+Pa9VTZygEdbCVtchYTP+z9qL6PEWITmhktr4Gi1ufPfKxWCI+B2w8q899sb NhiaODC1n64ohyyCdcwgErzKxE2bLhXgEHsDPsGa/tckHxuEIcO0PQFjJv6lVJG7 DXgajTCSfPRKu54iVqXfTkGBMC3TUU1u83joyflD7rIwlHmtf+kr5tGg95235nBK 02cInMY9c7c8Ng5r7qzj4th3//HtnqaT91fNgz2GDX5g7fQXLvOruRAVckl2d+4a mN/kr0Q22DWXvy9VYMUhrvGRQmTAubTko4jVziZjNKWB/zYh/lJoqPaXGfh98Bms LjtIr52vF64MRuK7Hvuw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3w7hewa4p7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 05:40:29 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41D5eSCV028913 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Feb 2024 05:40:29 GMT Received: from [10.131.33.37] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 12 Feb 2024 21:40:25 -0800 Message-ID: Date: Tue, 13 Feb 2024 11:10:22 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH V2 1/4] firmware: arm_scmi: Add perf_notify_support interface Content-Language: en-US To: Cristian Marussi , Sudeep Holla CC: , , , , , , , , , References: <20240117104116.2055349-1-quic_sibis@quicinc.com> <20240117104116.2055349-2-quic_sibis@quicinc.com> <20240131112854.24euh6c6xgljsj6c@bogus> From: Sibi Sankar In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ES6HdPApwObErYW01lLVkdC3oSyHTg7S X-Proofpoint-ORIG-GUID: ES6HdPApwObErYW01lLVkdC3oSyHTg7S X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-13_02,2024-02-12_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 bulkscore=0 clxscore=1011 mlxlogscore=987 priorityscore=1501 malwarescore=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401310000 definitions=main-2402130039 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_214037_810505_27939E40 X-CRM114-Status: GOOD ( 26.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/12/24 18:14, Cristian Marussi wrote: > On Wed, Jan 31, 2024 at 11:28:54AM +0000, Sudeep Holla wrote: >> On Mon, Jan 29, 2024 at 05:33:42PM +0000, Cristian Marussi wrote: > > Hi Sibi, > >>> On Mon, Jan 29, 2024 at 03:50:20PM +0000, Cristian Marussi wrote: >>>> On Wed, Jan 17, 2024 at 04:11:13PM +0530, Sibi Sankar wrote: >>>>> Add a new perf_notify_support interface to the existing perf_ops to export >>>>> info regarding limit/level change notification support. >>>>> >>>> >>>> Hi Sibi, >>>> >>>> as I mentioned previously, in order not to add a needless stream of SCMI >>>> Perf accessors I posted this: >>>> >>>> https://lore.kernel.org/linux-arm-kernel/20240129151002.1215333-1-cristian.marussi@arm.com/T/#u >>>> >>>> to expose all the Perf domains infos via the usual info_get(), similarly >>>> to how other SCMI protocols do already. >>>> >>>> I think that reworking this series on that, you can certainly drop this patch and just >>>> check the _notify booleans on the retrieved domain info. >>> >>> Sorry, but hold on with this change, I will probably post an updated version >>> my patch above. >>> >> >> As discussed in private, I would prefer to avoid exposing all the internals >> to the users of SCMI perf. At the same time may we can do better if we can >> check the availability of notification as part of notification enablement >> from the SCMI driver, I need to think the details yet. >> > > as previously mentioned, after speaking with Sudeep, I posted a new > series at [1], that aims to solve your problem with registering > notifications and looking up reported Perf frequencies in a new way. > > Using the changes at [1] you should be able to: > > - register your notifier without caring to check if the notification > is supported, since the SCMI core will take care of checking that and > report an error if not supported, without sending any unneeded > attempted notification enable message (so you can drop 1/4 in this > series) > > - retrieve the pre-calculated OPPs frequencies from the new extended > Perf notifications reports no matter if the system if operating in > level_indexing_mode or not. (so you can drop 2/4 in this series) Christian/Sudeep, Thanks a lot for spending time on this and simplifying the series. Will re-spin the series with your recommendations. -Sibi > > Thanks, > Cristian > > [1]: https://lore.kernel.org/linux-arm-kernel/20240212123233.1230090-1-cristian.marussi@arm.com/T/#ma68cefd753e34ba3e1f2d4392e978026a87e1bf8 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel