Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jie Gan <jie.gan@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@arm.com>,
	James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@arm.com>,
	Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH RFC 1/6] dt-bindings: soc: qcom: add QDCP provider
Date: Thu, 19 Nov 2026 15:00:08 +0100	[thread overview]
Message-ID: <d0dd4fad-2f56-456a-91ee-737af0f3b4e6@kernel.org> (raw)
In-Reply-To: <20261119-introduce-qcom-qecp-feature-v1-1-b1a730d2c57a@oss.qualcomm.com>

On 19/11/2026 10:01, Jie Gan wrote:
> Document the Qualcomm Debug Control Protocol (QDCP) firmware provider
> node used by CoreSight debug and trace blocks that are owned by the
> Qualcomm Embedded Co-Processor (QECP), a separate on-die processor that
> runs its own firmware. QDCP is the QMI (Qualcomm MSM Interface) service,
> carried over QRTR (Qualcomm IPC Router), that Linux uses to ask QECP
> firmware to control those blocks.
> 
> The provider is a Qualcomm platform/QMI service node, not a CoreSight
> graph device. It exposes the qcom,qdcp compatible along with
> per-connection QMI service/instance identifiers; the QMI service
> version is the only optional identifier, defaulting to 1.
> 
> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,qdcp.yaml    | 81 ++++++++++++++++++++++
>  1 file changed, 81 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,qdcp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,qdcp.yaml
> new file mode 100644
> index 000000000000..ee0a66b12dde
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,qdcp.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/qcom,qdcp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Debug Control Protocol (QDCP) provider
> +
> +maintainers:
> +  - Jie Gan <jie.gan@oss.qualcomm.com>
> +
> +description: |
> +  QDCP is a QMI-based firmware provider used to control CoreSight trace
> +  blocks that are owned by the Qualcomm Embedded Co-Processor (QECP) rather
> +  than the application processor (AP). CoreSight-facing consumers look up
> +  the provider through a "qcom,qdcp" phandle, naming a specific
> +  "connection-N" child node rather than the top-level provider node, and
> +  issue typed firmware requests instead of programming registers directly.
> +
> +  This node does not represent a CoreSight graph device. It is a platform
> +  driver that establishes the QMI connections used by consumer drivers such
> +  as the Qualcomm QDCP STM source and QDCP-backed TMC/ETR sink.
> +
> +  QECP exposes more than one independent QMI service (for example, a
> +  separate service used by remote ETM/diag sources). Each QMI connection is
> +  described as a child node of the "qcom,qdcp" node rather than as a
> +  property of the node itself, so a single provider device can establish
> +  more than one connection. A node without any "connection-N" child is valid
> +  but provides nothing for consumers to reference.
> +
> +properties:
> +  compatible:
> +    const: qcom,qdcp

Standard comment - compatibles are not supposed to be generic. That's
why you have entire commit msg to explain any oddities or deviations
from common rules.


No resources here, so this does not look like separate device.

> +
> +patternProperties:
> +  "^connection-[0-9]+$":
> +    type: object
> +    description:
> +      A single QMI connection established by the QDCP provider. Consumers
> +      reference this child node directly via their "qcom,qdcp" phandle, not
> +      the top-level provider node.
> +
> +    properties:
> +      qcom,service-id:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description:
> +          QMI service identifier for this connection.
> +
> +      qcom,version:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        default: 1
> +        description:
> +          QMI service version for this connection.
> +
> +      qcom,instance-id:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description:
> +          QMI instance identifier for this connection.
> +

Please don't describe firmware contents as random integers in DT.


Best regards,
Krzysztof


  reply	other threads:[~2026-11-19 14:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  9:01 [PATCH RFC 0/6] Coresight: Introduce Qualcomm QDCP support for QECP-owned trace blocks Jie Gan
2026-11-19  9:01 ` [PATCH RFC 1/6] dt-bindings: soc: qcom: add QDCP provider Jie Gan
2026-11-19 14:00   ` Krzysztof Kozlowski [this message]
2026-11-19  9:01 ` [PATCH RFC 2/6] soc: qcom: add QDCP firmware provider Jie Gan
2026-11-19  9:01 ` [PATCH RFC 3/6] dt-bindings: arm: qcom: add QDCP STM source Jie Gan
2026-11-19 14:02   ` Krzysztof Kozlowski
2026-11-19  9:01 ` [PATCH RFC 4/6] coresight: " Jie Gan
2026-11-19  9:01 ` [PATCH RFC 5/6] dt-bindings: arm: qcom: add QDCP TMC ETR sink Jie Gan
2026-11-19  9:01 ` [PATCH RFC 6/6] coresight: tmc: add QDCP ETR sysfs support Jie Gan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0dd4fad-2f56-456a-91ee-737af0f3b4e6@kernel.org \
    --to=krzk@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=james.clark@linaro.org \
    --cc=jie.gan@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mike.leach@arm.com \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tingwei.zhang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox