From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C95EC43331 for ; Mon, 11 Nov 2019 11:52:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E75121655 for ; Mon, 11 Nov 2019 11:52:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RxSdP2yu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E75121655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yB9ict4ZmQ/TYXLKSpsPju31+wwVUx8StPkAgDizzxQ=; b=RxSdP2yuhOXY28QBi/+hU/DF/ 0K9Qetz64QWXrpaic3NTjSF9w2QD8fvyADWJOeP5vsc0AH4GnqEskdft+cPKN64nA9cTn2Tt+Q9Xj B6UxuKFfzY4e0YRYLF0uj2Fu31x3EIpd7e0e1D6BGJra4EZ6J7ZoE6o92b1sMjKU4wGugPBG61Ptq +gy6/vEGHeoC8Ez/R8wmhN3cCr8oUWZoC8yteMRnq1NaJ90tCNaSgNlrGOR5fQSItQH+bCKpKhN1R J1VNqQuY9y7MQiX2Ep1yan29oP+TOB6rXU6xde4KwIpwMNQK6l4xV7o3gcxzBpHqFArtQDXF+/RKG uuy+CbJkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU8Fa-0003TR-TT; Mon, 11 Nov 2019 11:52:54 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU8FW-0003SU-UM for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 11:52:53 +0000 Received: from lhreml702-cah.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 3AEBA609B00C25622120; Mon, 11 Nov 2019 11:52:40 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by lhreml702-cah.china.huawei.com (10.201.108.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 11 Nov 2019 11:52:39 +0000 Received: from [127.0.0.1] (10.202.226.46) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 11 Nov 2019 11:52:39 +0000 Subject: Re: [PATCH 1/2] iommu/arm-smmu-v3: Don't display an error when IRQ lines are missing To: Jean-Philippe Brucker , , References: <20191111111721.4145919-1-jean-philippe@linaro.org> From: John Garry Message-ID: Date: Mon, 11 Nov 2019 11:52:38 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191111111721.4145919-1-jean-philippe@linaro.org> Content-Language: en-US X-Originating-IP: [10.202.226.46] X-ClientProxiedBy: lhreml713-chm.china.huawei.com (10.201.108.64) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_035251_136527_CF0668BF X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: will@kernel.org, joro@8bytes.org, robin.murphy@arm.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/11/2019 11:17, Jean-Philippe Brucker wrote: > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message > to platform_get_irq*()"), platform_get_irq_byname() displays an error > when the IRQ isn't found. Since the SMMUv3 driver uses that function to > query which interrupt method is available, the message is now displayed > during boot for any SMMUv3 that doesn't implement the combined > interrupt, or that implements MSIs. > > [ 20.700337] arm-smmu-v3 arm-smmu-v3.7.auto: IRQ combined not found > [ 20.706508] arm-smmu-v3 arm-smmu-v3.7.auto: IRQ eventq not found > [ 20.712503] arm-smmu-v3 arm-smmu-v3.7.auto: IRQ priq not found > [ 20.718325] arm-smmu-v3 arm-smmu-v3.7.auto: IRQ gerror not found > > Use platform_get_irq_byname_optional() to avoid displaying a spurious > error. > > Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") > Signed-off-by: Jean-Philippe Brucker That stops a nuisance: Tested-by: John Garry However, I will say though that the combined irq seems necessary for TX2, which is not warned about being missing now. Finally, A cover letter would have been handy to mention that the new API was only introduced after rc1 thanks > --- > drivers/iommu/arm-smmu-v3.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index bfa4a0f39ed0..a89797f346a4 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -5207,19 +5207,19 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > > /* Interrupt lines */ > > - irq = platform_get_irq_byname(pdev, "combined"); > + irq = platform_get_irq_byname_optional(pdev, "combined"); > if (irq > 0) > smmu->combined_irq = irq; > else { > - irq = platform_get_irq_byname(pdev, "eventq"); > + irq = platform_get_irq_byname_optional(pdev, "eventq"); > if (irq > 0) > smmu->evtq.q.irq = irq; > > - irq = platform_get_irq_byname(pdev, "priq"); > + irq = platform_get_irq_byname_optional(pdev, "priq"); > if (irq > 0) > smmu->priq.q.irq = irq; > > - irq = platform_get_irq_byname(pdev, "gerror"); > + irq = platform_get_irq_byname_optional(pdev, "gerror"); > if (irq > 0) > smmu->gerr_irq = irq; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel