linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Ghiti <alex@ghiti.fr>
To: "Clément Léger" <cleger@rivosinc.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: "Himanshu Chauhan" <hchauhan@ventanamicro.com>,
	"Anup Patel" <apatel@ventanamicro.com>,
	"Xu Lu" <luxu.kernel@bytedance.com>,
	"Atish Patra" <atishp@atishpatra.org>,
	"Björn Töpel" <bjorn@rivosinc.com>,
	"Yunhui Cui" <cuiyunhui@bytedance.com>
Subject: Re: [PATCH v6 1/5] riscv: add SBI SSE extension definitions
Date: Wed, 13 Aug 2025 11:01:57 +0200	[thread overview]
Message-ID: <d0f8d0d8-fb46-4009-a50f-3faacf8516fc@ghiti.fr> (raw)
In-Reply-To: <20250808153901.2477005-2-cleger@rivosinc.com>

Hi Clément,

On 8/8/25 17:38, Clément Léger wrote:
> Add needed definitions for SBI Supervisor Software Events extension [1].
> This extension enables the SBI to inject events into supervisor software
> much like ARM SDEI.
>
> [1] https://lists.riscv.org/g/tech-prs/message/515
>
> Signed-off-by: Clément Léger <cleger@rivosinc.com>
> ---
>   arch/riscv/include/asm/sbi.h | 61 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 61 insertions(+)
>
> diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h
> index 341e74238aa0..e4993fb664d2 100644
> --- a/arch/riscv/include/asm/sbi.h
> +++ b/arch/riscv/include/asm/sbi.h
> @@ -36,6 +36,7 @@ enum sbi_ext_id {
>   	SBI_EXT_STA = 0x535441,
>   	SBI_EXT_NACL = 0x4E41434C,
>   	SBI_EXT_FWFT = 0x46574654,
> +	SBI_EXT_SSE = 0x535345,
>   
>   	/* Experimentals extensions must lie within this range */
>   	SBI_EXT_EXPERIMENTAL_START = 0x08000000,
> @@ -430,6 +431,66 @@ enum sbi_fwft_feature_t {
>   
>   #define SBI_FWFT_SET_FLAG_LOCK			BIT(0)
>   
> +enum sbi_ext_sse_fid {
> +	SBI_SSE_EVENT_ATTR_READ = 0,
> +	SBI_SSE_EVENT_ATTR_WRITE,
> +	SBI_SSE_EVENT_REGISTER,
> +	SBI_SSE_EVENT_UNREGISTER,
> +	SBI_SSE_EVENT_ENABLE,
> +	SBI_SSE_EVENT_DISABLE,
> +	SBI_SSE_EVENT_COMPLETE,
> +	SBI_SSE_EVENT_SIGNAL,


Nit but in the specification this event is referred as "inject" instead 
of "signal", any reason to change that naming?


> +	SBI_SSE_EVENT_HART_UNMASK,
> +	SBI_SSE_EVENT_HART_MASK,
> +};
> +
> +enum sbi_sse_state {
> +	SBI_SSE_STATE_UNUSED     = 0,
> +	SBI_SSE_STATE_REGISTERED = 1,
> +	SBI_SSE_STATE_ENABLED    = 2,
> +	SBI_SSE_STATE_RUNNING    = 3,
> +};
> +
> +/* SBI SSE Event Attributes. */
> +enum sbi_sse_attr_id {
> +	SBI_SSE_ATTR_STATUS		= 0x00000000,
> +	SBI_SSE_ATTR_PRIO		= 0x00000001,
> +	SBI_SSE_ATTR_CONFIG		= 0x00000002,
> +	SBI_SSE_ATTR_PREFERRED_HART	= 0x00000003,
> +	SBI_SSE_ATTR_ENTRY_PC		= 0x00000004,
> +	SBI_SSE_ATTR_ENTRY_ARG		= 0x00000005,
> +	SBI_SSE_ATTR_INTERRUPTED_SEPC	= 0x00000006,
> +	SBI_SSE_ATTR_INTERRUPTED_FLAGS	= 0x00000007,
> +	SBI_SSE_ATTR_INTERRUPTED_A6	= 0x00000008,
> +	SBI_SSE_ATTR_INTERRUPTED_A7	= 0x00000009,
> +
> +	SBI_SSE_ATTR_MAX		= 0x0000000A
> +};
> +
> +#define SBI_SSE_ATTR_STATUS_STATE_OFFSET	0
> +#define SBI_SSE_ATTR_STATUS_STATE_MASK		0x3
> +#define SBI_SSE_ATTR_STATUS_PENDING_OFFSET	2
> +#define SBI_SSE_ATTR_STATUS_INJECT_OFFSET	3
> +
> +#define SBI_SSE_ATTR_CONFIG_ONESHOT	BIT(0)
> +
> +#define SBI_SSE_ATTR_INTERRUPTED_FLAGS_SSTATUS_SPP	BIT(0)
> +#define SBI_SSE_ATTR_INTERRUPTED_FLAGS_SSTATUS_SPIE	BIT(1)
> +#define SBI_SSE_ATTR_INTERRUPTED_FLAGS_HSTATUS_SPV	BIT(2)
> +#define SBI_SSE_ATTR_INTERRUPTED_FLAGS_HSTATUS_SPVP	BIT(3)
> +
> +#define SBI_SSE_EVENT_LOCAL_HIGH_PRIO_RAS	0x00000000
> +#define SBI_SSE_EVENT_LOCAL_DOUBLE_TRAP		0x00000001
> +#define SBI_SSE_EVENT_GLOBAL_HIGH_PRIO_RAS	0x00008000
> +#define SBI_SSE_EVENT_LOCAL_PMU_OVERFLOW	0x00010000
> +#define SBI_SSE_EVENT_LOCAL_LOW_PRIO_RAS	0x00100000
> +#define SBI_SSE_EVENT_GLOBAL_LOW_PRIO_RAS	0x00108000
> +#define SBI_SSE_EVENT_LOCAL_SOFTWARE_INJECTED	0xffff0000
> +#define SBI_SSE_EVENT_GLOBAL_SOFTWARE_INJECTED	0xffff8000


And here you use "injected".


> +
> +#define SBI_SSE_EVENT_PLATFORM		BIT(14)
> +#define SBI_SSE_EVENT_GLOBAL		BIT(15)
> +
>   /* SBI spec version fields */
>   #define SBI_SPEC_VERSION_DEFAULT	0x1
>   #define SBI_SPEC_VERSION_MAJOR_SHIFT	24


  reply	other threads:[~2025-08-13  9:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 15:38 [PATCH v6 0/5] riscv: add support for SBI Supervisor Software Events Clément Léger
2025-08-08 15:38 ` [PATCH v6 1/5] riscv: add SBI SSE extension definitions Clément Léger
2025-08-13  9:01   ` Alexandre Ghiti [this message]
2025-08-13 10:49     ` Clément Léger
2025-08-08 15:38 ` [PATCH v6 2/5] riscv: add support for SBI Supervisor Software Events extension Clément Léger
2025-08-13 10:09   ` Alexandre Ghiti
2025-08-13 10:47     ` Clément Léger
2025-08-13 11:58       ` Alexandre Ghiti
2025-08-18  9:08   ` [External] " yunhui cui
2025-08-28 10:47     ` Clément Léger
2025-08-08 15:38 ` [PATCH v6 3/5] drivers: firmware: add riscv SSE support Clément Léger
2025-08-12 12:54   ` [External] " yunhui cui
2025-08-12 12:57     ` Clément Léger
2025-08-13 12:08   ` Alexandre Ghiti
2025-08-28  8:07     ` Clément Léger
2025-08-08 15:38 ` [PATCH v6 4/5] perf: RISC-V: add support for SSE event Clément Léger
2025-08-08 15:38 ` [PATCH v6 5/5] selftests/riscv: add SSE test module Clément Léger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0f8d0d8-fb46-4009-a50f-3faacf8516fc@ghiti.fr \
    --to=alex@ghiti.fr \
    --cc=apatel@ventanamicro.com \
    --cc=atishp@atishpatra.org \
    --cc=bjorn@rivosinc.com \
    --cc=cleger@rivosinc.com \
    --cc=cuiyunhui@bytedance.com \
    --cc=hchauhan@ventanamicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=luxu.kernel@bytedance.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).