From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>, Andrej Picej <andrej.picej@norik.com>
Cc: linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, festevam@gmail.com,
linux-kernel@vger.kernel.org, s.hauer@pengutronix.de,
wim@linux-watchdog.org, linux@roeck-us.net,
kernel@pengutronix.de, Anson.Huang@nxp.com, linux-imx@nxp.com
Subject: Re: [PATCH v3 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode
Date: Thu, 3 Nov 2022 18:29:28 -0400 [thread overview]
Message-ID: <d1061af4-cfd6-4c39-e23e-c18d6f2edeea@linaro.org> (raw)
In-Reply-To: <166747792333.2121983.3197860057328686578.robh@kernel.org>
On 03/11/2022 08:35, Rob Herring wrote:
>
> On Thu, 03 Nov 2022 11:03:57 +0100, Andrej Picej wrote:
>> Property "fsl,suspend-in-wait" suspends watchdog in "WAIT" mode which
>> corresponds to Linux's Suspend-to-Idle S0 mode. If this property is not
>> set and the device is put into Suspend-to-Idle mode, the watchdog
>> triggers a reset after 128 seconds.
>>
>> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
>> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>> ---
>> Changes in v3:
>> - disallow the property for devices which don't support WDW bit
>> functionality with .yaml DTS allOf:if:then scheme.
>>
>> Changes in v2:
>> - add a commit message,
>> - add a list of devices which support this functionality
>> ---
>> .../bindings/watchdog/fsl-imx-wdt.yaml | 33 +++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml:71:1: [error] duplication of key "allOf" in mapping (key-duplicates)
>
You already have there allOf, so:
1. Move the existing allOf *above* unevaluatedProperties:false (like in
example-schema).
2. Drop the quotes around 'watchdog.yaml', when moving.
3. Add your pieces.
All above in one commit.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-03 22:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 10:03 [PATCH v3 0/3] Suspending i.MX watchdog in WAIT mode Andrej Picej
2022-11-03 10:03 ` [PATCH v3 1/3] watchdog: imx2_wdg: suspend " Andrej Picej
2022-11-03 15:04 ` Guenter Roeck
2022-11-03 10:03 ` [PATCH v3 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode Andrej Picej
2022-11-03 12:35 ` Rob Herring
2022-11-03 22:29 ` Krzysztof Kozlowski [this message]
2022-11-03 10:03 ` [PATCH v3 3/3] ARM: dts: imx6ul/ull: suspend i.MX6UL watchdog " Andrej Picej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1061af4-cfd6-4c39-e23e-c18d6f2edeea@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=andrej.picej@norik.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).