From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 706CCC77B7A for ; Thu, 18 May 2023 06:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=INYyux39oY9sbA6SYUJ3OsE7RkaLDbfUCiNBB1h6Vao=; b=MnZtCmzoYdz2iv wEkQj84ghJLV5qDNsacAoWEtxp45hfObWL6ykXp4db4td+TfWBC6Y3LIfQJeNEMFggDkmEp09fxYM w2XHdIB3dnQ8+hrJzj84REs9U5ZJ5CJv5ZDwAJSQVERNCW1amvucrvbYUsFZ91EcC2jRuwrHi0PZJ D8zepE/Bx7t+OZf8fb7QQI3a7K2OMivvHZRa6y75XkFdNd1vi/BSDUQyLglCVSG/h9ToQcLP9iHei 88AxMJFM4A36KlrwA/FV21oRbjEYNCMU30qSosAtPcXgEShKfmz61Kw/Tz+7uzWHkL6M9BJG2SgYy AaB4wIx8vYD1z6g9660A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pzWjc-00C1CX-27; Thu, 18 May 2023 06:03:32 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pzWjZ-00C1C0-0s for linux-arm-kernel@lists.infradead.org; Thu, 18 May 2023 06:03:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1684389809; x=1715925809; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6UEDa+KRdu9f+XcdqXzJbY4Ep7Pzh4XXvXqo2mhxdMI=; b=j9yC80zP8VDfXXcRIOiIdGL91vrSpbfuVkLpXor0EC4dkrovCam82RXc rjlmNCtcgYUY327k9HWXET7YxzvlgZQhudx0LN7dhDr4Fsoh5DHUtaRKl IlErODAZAFfPGRF5Ui2Ekb2gw2x3SK79ookvwpkXW3kev2zQcfkzWW/qC NvR3FJZPg2L9DlWzs57RPpiDRE2EODvHYk1ciAuhU4gPCbOl6Jox/m/zc Hz0wM+NWQwANdPmZ01GNTmOM/nvRbJmtfI457JLBh6AftwGx+JvzvQcMF 79RjFvTrmcjN4t+J66ANp0QqMZJH0a8iP+u3gRPf5lSsWy+hNBvqbUHAu w==; X-IronPort-AV: E=Sophos;i="5.99,284,1677567600"; d="scan'208";a="152687158" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 May 2023 23:03:28 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 17 May 2023 23:03:26 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 17 May 2023 23:03:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4rEyk2c5JQtFSFVzp3hxRNmZr/snSfAX7hQmzLF4JXcWtcXHADIZlnmOs+oyemUj71984bhuHBwBW3RievlvuM/fnxAhe+fmfHl/QOKUQcL2IyAuE5PtjBe+3gp6U3eznpvZWBu2uRz8ZN7tYchDKEobkwM0ZdQOLrffTh7Qa1bHDQqjJah8nsDMA/tCd08BoYRxZZ35qLyKhV+2/rRJKIfMhoHod39wwz+L+xofGAVwLwrHlNUs5ZbmW3/I/F2NhbtI34enGae6E0GCUb+e7UA0Q2jz2rMtDdphsBhpWRgdurSl13SNKLCZ+y+hEViUaWgIUrkboLijAxArqArRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6UEDa+KRdu9f+XcdqXzJbY4Ep7Pzh4XXvXqo2mhxdMI=; b=SF30Ls/7g0eminghW3g4rzzPndXniAYJQYApH3WR4HYvvYVbRvcn9h4KEQMGOgHphprxirHYqddCL+RN2z/xD5sPQnicPkbY3ErzOj2NBuk1OTJTgK8OTBrZ6eaTNfskX8TiaO1YVeZUrAONJaYGKKMTI3rYGqxWBeVSqd3NgWj0z1mki0koHPlStxjnMbu0D8MDAq/hO5wovFL8VLgT2FQ2mrX6cYEDZe5PtpHQrOqi17CQc8wnUnp7HnWV2DLgav3yaTHiAgofr5uldRQLegkAq0xsYv3ltCE1Sfif5RGGHEijU4gQfX+cudvbybCGV8F1VQEN4rxFsmaNBj/2jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6UEDa+KRdu9f+XcdqXzJbY4Ep7Pzh4XXvXqo2mhxdMI=; b=nCKGuaytZWk+YT78PuwA0ZQHaGqyMKqjzVLSvUdFTEvD7hV/NWT7YR1151+TkvgRPGL03z3dLq+sgMQLtQLg7cBlllwsb51/gPDt0SzZKSby050b6wi+9BK6XTy7O3tEBaf/s5xj2WOvPW+73iAq70kYE8bsOPVE1rnGqIMowbU= Received: from SJ2PR11MB7648.namprd11.prod.outlook.com (2603:10b6:a03:4c3::17) by CO1PR11MB4788.namprd11.prod.outlook.com (2603:10b6:303:97::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Thu, 18 May 2023 06:03:22 +0000 Received: from SJ2PR11MB7648.namprd11.prod.outlook.com ([fe80::27bf:a69f:806f:67be]) by SJ2PR11MB7648.namprd11.prod.outlook.com ([fe80::27bf:a69f:806f:67be%5]) with mapi id 15.20.6411.019; Thu, 18 May 2023 06:03:22 +0000 From: To: , , , , , , , CC: , , , Subject: Re: [PATCH v5 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml Thread-Topic: [PATCH v5 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml Thread-Index: AQHZiU5zKZL6Rhh1HESEigeJj/zbcw== Date: Thu, 18 May 2023 06:03:21 +0000 Message-ID: References: <20230517094119.2894220-1-claudiu.beznea@microchip.com> <20230517094119.2894220-3-claudiu.beznea@microchip.com> <83f484ff-f170-6f32-f4b4-9743eb6d0b4c@linaro.org> In-Reply-To: <83f484ff-f170-6f32-f4b4-9743eb6d0b4c@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ2PR11MB7648:EE_|CO1PR11MB4788:EE_ x-ms-office365-filtering-correlation-id: c4901b81-5e6c-4834-320b-08db576595b9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1RGCoKfAKQfb5SRlso0dqvCpooREzr3G6tJ8wK7EvFhO3zuXQoeS3+7ou5qAeHSaRcFlmVo1DxQTnhi7CUMWt2zOHpzwpRNv6fadgAutM2PIxrZTD50zRRE0lKI2sM0ZF7ZGYj8bXh9E5lOVW6n/mHksRpwRQ8c468kPdQQLE5QaX1LReDf1FmwuDOyqqesRkibAeAliHmboMU7V3mcW5nJkKjkn0Zha50BBqshHzHxlVMi5nrIfa7oMdv11jHQDSk1ahrJo0WEThbP23CuOeNa3Woc/73+gKqoUKx3xF+WdyBXllggmV30VbR2G8MVxNoI3uPsdd8ikpf0bk1K11ipTIokIX6+QH4VnrgQcg2gV1Y/RPh56S3Lbm6oVyRbInkUwMBNB4UFAe4t4dXEfEMWVSl3HwE7pgf1aU9PvMWqXrqpx0GB92atIV5BEiUL/At6efTNNfxU0zG9IA03RQLoeVX0G9rssRUxnHmwz3R6zXjrcjyIOsUKSL6Z7wgCGrKpCBCjatusoFIs+WBmcGuTQgzW4J9mSXyYGLb8f8RBgnqosm4VoWzAui3aINSAEO5Siwdvjc2Cu8KDkBRSlrDUenzs7Z9D6AvZstGzVzQ1pL2/7GJ4kL+oAZTBWlpTQtJ3awVTYyn8JHZnJjiOKQyYKUjK0GKFEBJ7uff9mrV930YB51+AmHBf8EhLNrWTn x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7648.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(366004)(376002)(346002)(136003)(451199021)(31686004)(2906002)(8936002)(7416002)(41300700001)(8676002)(5660300002)(66946007)(64756008)(4326008)(66476007)(76116006)(66446008)(66556008)(91956017)(54906003)(110136005)(71200400001)(478600001)(6486002)(36756003)(83380400001)(122000001)(2616005)(53546011)(186003)(26005)(6506007)(316002)(6512007)(38100700002)(86362001)(38070700005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WU5ia004cDlPb2RENGNhQlR1cnFxaVhqWXdUYlpic3ZVSE1ITlAreHZGTnYy?= =?utf-8?B?ZDJzbW1WV2duNXpUbWVEdDRHVlVoMUZCSkRQOHFWMUNIZk1OUWNpbU4wZGxq?= =?utf-8?B?U2FxQkFUZVZiRmZtYnF5QXFiZ0JCZE5Ta3kwM2NyV08yVHZ5b3lmQ2Y5NVlN?= =?utf-8?B?N0w4Rmp1ZXhRUUlyUW5Fa05xU1JhUnlDaFB6UGJQaktuL3ZHcUpuNllLZFNR?= =?utf-8?B?YmpPcHBVUks3MGtXYS93d21Ld0FYVW42aExKaUJxU1c4cWNPOElTcEFGaGtI?= =?utf-8?B?V29ERUgvOSszT3VBbHJWRG42Z09VMk1xZ0tVTXlIQW9xNSszNTUydmVRdFRy?= =?utf-8?B?S2JHL0h5ZThtam95OG1hc0NPMGNHb1RGeFpjZHFoNmdkdU5nNUxsWkJrV2VI?= =?utf-8?B?NDZwaklGM0lQd0dMWTdTNVA2YXhJZWh2TFhCak4weGovekcxVEJtekJQb0JQ?= =?utf-8?B?MUtZWnZsQWswRE1nYlA1MGVkdzc3eURkMWMvZXp0aGk3NERQYXROeFBqRU00?= =?utf-8?B?d0tiTlF2VkhLQ2ZJTE93azJieFN6U1JCN0J6N0JwaDZ6NGVpMnk3RXZqWFlh?= =?utf-8?B?L29PRE5oV1p3V1B1VXpsYnE1MzErbnd5WFk4L2FXTW5QWnYwSkpscEZZSUZq?= =?utf-8?B?Rk5reGdSUHJVcnkycHlKL05WSEcrQ2pFcTJ1ZFlnb0lXdkNQYmhSbkxLVEcz?= =?utf-8?B?WjJVbWsxUXd2Mm8rd0dYNlZkYjlpMGphV2d3bEdiTXlkUTZ3T0o0NE81Rmxx?= =?utf-8?B?VFB1SWlacjVwS25tc1F6ZnZxMm9HYWZ0QUh6M3RvZlVXVWxrd2NwdUVYY3N6?= =?utf-8?B?c2M0VEdYdDFrbFlkVmEreklPNlFrSGlqdm9XbEFWZVdzWkMzRU10VVlGYnlR?= =?utf-8?B?QWVxdWpzQlVnNmJtai9hcG5YbkFmeFR6cnIwSGd2RjBPM1NqY3cwa3pLOXdo?= =?utf-8?B?ZmFTemJOVHFtK1poZmhkNmc5dzBEMXNUb2p6U2l2RzB5U3pOd25GVXpWTlhu?= =?utf-8?B?bFhENmlJQ0tkQVBRVUliZzdVWm1obkFHMHFtTC8zTCtleXZuOU9scVFQQktS?= =?utf-8?B?UURJS3F6NEt3RXlhRDdWNWJqZElSMGl6dWVNbGpKSGJyVHpzMW9jWDcvNUcv?= =?utf-8?B?anFvOExqSlRNNWIyYlc2aFh5M1BMZlFLRW01NjVMZkxkUHg0WXB3Nk1nNVJn?= =?utf-8?B?RmVpaDBFZTV0TG5JdWhTZG9PNUhsb2gvYzdoQVZmeEMycHk0b2xWUFdaaDJz?= =?utf-8?B?U1hPMnNnVWtMdVAvNk95OE01Wmxabm5TdFdpVjhYekZQQWc3VkVBYlVRRnJn?= =?utf-8?B?eHIwVkc2SWJ6MmpoZnpMeVkxUFdjRW5TV29DdmdLT1NEMmxFTGNwMTMvcGVz?= =?utf-8?B?U1RMamc4aStFSTAwby92dkM2bEhjM1ducWZmZ3NUNkJWRFVLVVBGMmVycE4v?= =?utf-8?B?OEczRHpwaXFZV0VHeVh6Ny8xbkZHbklvaWhNS0tqN2UxQ29ORk1KME5kZE83?= =?utf-8?B?T003OHJlN1Fnc3FYZ29nR2JZdlExcVluSTV6M3NzNE10OGo2RVBGRlM3WDFV?= =?utf-8?B?dllOT1Z0OG9EWVc3Q3pVZXl6b1BkNUZtTFU2MFhZYS8vNy9EQnJWb2c2cG8z?= =?utf-8?B?VE9SZk44YXJkOUJnVnIxSUhRM2psdWFRQkhaa2N5d0pyMGNNVklEdEpiL0dC?= =?utf-8?B?NGhXTkZEV0llMkxHQjBvVkNOVWhZbVgraWlnWXJPaklpWnZMNnhyTGtLeTM3?= =?utf-8?B?TkIrR1dDRkcxZUUwSTRPTW52WHhWdDkwZkpUOHpkQVR4b3RXOFdyRU1RMEtH?= =?utf-8?B?bkhQS2I3RjhIM0lFQmt4YkxzWFVBZlVHbUVlNmpzN1ZWUU9qckFXU1k1L2c3?= =?utf-8?B?RWFuKzRseVl2RXU5RnhXRm5XZ1FFeW5yVUZzUzlHRU8wMUQ2dmdaU1BKRTFs?= =?utf-8?B?R3Erc3paYklsY3RnZ1lLTVk0eDRWUytqblkrNFF2R05XSWEyY2RNNDlBOXV0?= =?utf-8?B?aE9POTdaeVl2RkdWNmZJNjNWLzE3U1NoeVJJNTNBUEJoTjBwRDAzQzN2V2NP?= =?utf-8?B?L1greThIY21TblFKY0VKTjdxd3o2bjJsU2hrNjF6VytkQnJtRHgyeWtsS1Jj?= =?utf-8?B?alI5V0I3OEQzMFYzSEc5NzZqcWJSaXhXQjlGc1o0anFaMEFWRlFvSDBEazcx?= =?utf-8?B?SWc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7648.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4901b81-5e6c-4834-320b-08db576595b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2023 06:03:21.7977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i1vTazYjGQL+Pk7ZiZgTXBQXhVQK2VS4bXNfhhP3kyBcfcUOlfz9WKPcoRhTGi4sbFL7zj56aDyQwDvEryOkcz6LaHhQDIv+qisKOfrTw6k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4788 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230517_230329_412288_46C83D3D X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17.05.2023 17:21, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 17/05/2023 11:41, Claudiu Beznea wrote: >> Convert Atmel PMC documentation to yaml. Along with it clock names >> were adapted according to the current available device trees as >> different controller versions accept different clock (some of them >> have 3 clocks as input, some has 2 clocks as inputs and some with 2 >> input clocks uses different clock names). > > Thank you for your patch. There is something to discuss/improve. > > >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - atmel,at91rm9200-pmc >> + - atmel,at91sam9260-pmc >> + - atmel,at91sam9g20-pmc >> + then: >> + properties: >> + clocks: >> + minItems: 2 >> + maxItems: 2 >> + clock-names: >> + items: >> + - const: slow_xtal >> + - const: main_xtal >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - atmel,sama5d2-pmc >> + - atmel,sama5d3-pmc >> + - atmel,sama5d4-pmc >> + then: >> + properties: >> + clocks: >> + minItems: 2 >> + maxItems: 2 >> + clock-names: >> + items: >> + - const: slow_clk >> + - const: main_xtal > > This and previous if, should be squashed. You have exactly the same then:. Clock names are different. Or do you propose to have a if for clocks: minItems: 2 maxItems: 2 and 2 ifs for clock names? > > > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel