From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BF26C433EF for ; Sat, 14 May 2022 08:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XMy8OJ10HG9KCXCm9MzBvCH7zfbXxKf4wgE10+2jOvM=; b=gxUEfLG1cV1hpz UyVKt4RuSSeU4S2jJsFy7mU2b0/0rerlu1H47IeR5Vr8r33ifv7CaJagpatOXJw9t/i5Cs7hgYj8z QtMnrD0yOHVRtlhUYjnaXaRQorcTvE5IOHmasZq0IJch5zirB6Si+YdoBg5ICNp7zooZSXDEFT80R aWvZe2MrHsvAI+lWylVTojM+IjlkTCM3SC38C/IQEqRYNK9Urt8xCS5+42pGXhievqGSge8DBlT4+ Cem6Z2ks/vYMi/t6ZQUgaMDZrUE+/mhkGxDfaC9CRKFniXRUCLZ26j9JOtN07lWzG7S/XEjFvD+l7 JNWkXeyL4yVErQ9mGz1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npmxx-0013dq-At; Sat, 14 May 2022 08:17:33 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npmxs-0013dD-DW; Sat, 14 May 2022 08:17:30 +0000 Received: from [192.168.1.107] ([37.4.249.94]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mbj3e-1oLHQZ0uJK-00dFtL; Sat, 14 May 2022 10:17:09 +0200 Message-ID: Date: Sat, 14 May 2022 10:17:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] clk: bcm2835: fix bcm2835_clock_choose_div Content-Language: en-US To: Michael Turquette , Stephen Boyd , Linus Torvalds Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Maxime Ripard , regressions@lists.linux.dev References: <20220428183010.1635248-1-stefan.wahren@i2se.com> <20220503145804.b2xz4etzc6kpr3fk@houat> <20220510132756.qmyjca53xu44iwn7@houat> From: Stefan Wahren In-Reply-To: <20220510132756.qmyjca53xu44iwn7@houat> X-Provags-ID: V03:K1:r2U+3GHILFBJRwdN1QPH4ahI0ZnQAgBHx5ON/pp7+M6xKkOOU7B cDh3ez2wjRJDVkrRmJyZwqRX20qLK1h0odGOKQA2gTvVdOIshrolMPvO+ltIotrDkCOtZNv LiY7PFDCv4rd6871n6rH6mVZPgjfoFEW85IhYK6dJd44NRceaaeueFrXBEdw6B6E6ArK/SB c4xfRAYikG3kU9drmxyug== X-UI-Out-Filterresults: notjunk:1;V03:K0:OBUcdSwGzvA=:7kGSMmYVHvANedwOjmE35m SzdqVBJwDVp9wf95BaSpp3sfWCU4L4eNupi1Kk+MfxmfgsDIrCEsZ8raEt2qcUZGVa2pHV7yy fcGYyYA4dRRVjNLSDjx0rEAjq5hba/B6WdJsEoy/lsnaRzUgHjg0gU0lrvxFUM2D+3yNRVABR ZGGHtQVu7SGQm1nUgScsxQVFVur89dyT/bSSSzvHqNmocn/6s2wu9NPPcTIz//6DMs4+4avjz 3hbnW1KFFA8F1VbVMWDbLBzD38/cQCB37EFv/lODaFi74u2JYDq5vs6Gy8Adqc4Kz0EE9ywBI 4pobsDdp7eu/Oe5iT6P0KZaT47dzaNJVGSoYOZcRSKEftQ17Ph/wxaTz6Iajk7/fT2XtgFNLV IhFQEjRwHG9jlmgLQ+zz3HJ/piqnqMl092hVk/UB99bmp+mIdkhZDOEOWkdxK88lyFpIblB67 ui15rI9kZThCBe34+KZVA3KtDdKBLGlYKee2Cxh0NCcShParsWRB6rYWhLKBtOy4YJuqacbeM Tceoun7RySowctJv9QYJST8OitRLcbuQwKamXV4gTVABcVCKs6zhfEmzELI82lWPnWufgHtCm plNtvNzjQNlMhylKibpNSMsedV+uPonc7BCxL/Rdr490wpCQmc1fc/bpdlyWoSsg+JDKl5dRi RP7Oaj0/h3aBtA0HDsX13QMCt6v97jUf7tzCVVySjnRasWRhCNIYnh3NwHdgMqdEc7i14er5N RX6jO9XoycglYTeatOVWytW1rkDApoI3Lrn/A1e+QF1eDQAedtgUdJd+ogk= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220514_011728_810062_B2ACA8CC X-CRM114-Status: GOOD ( 11.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am 10.05.22 um 15:27 schrieb Maxime Ripard: > On Sat, May 07, 2022 at 11:26:28AM +0200, Stefan Wahren wrote: >> Am 03.05.22 um 16:58 schrieb Maxime Ripard: >>> Hi, >>> >>> On Thu, Apr 28, 2022 at 08:30:10PM +0200, Stefan Wahren wrote: >>>> The commit 09e3b18ca5de ("clk: bcm2835: Remove unused variable") >>>> accidentially breaks the behavior of bcm2835_clock_choose_div() and >>>> booting of Raspberry Pi. The removed do_div macro call had side effects, >>>> so we need to restore it. >>>> >>>> Fixes: 09e3b18ca5de ("clk: bcm2835: Remove unused variable") >>>> Signed-off-by: Stefan Wahren >>> I only found this patch after debugging why the HDMI driver was >>> returning -EINVAL at probe on -rc5. >>> >>> Acked-by: Maxime Ripard >>> Tested-by: Maxime Ripard >> Thanks, >> >> does this go via clk-fixes? > Yep, it should. > > Stephen, could we merge this? Is there any chance to get this regression fix into mainline before 5.18 is released? > > Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel