From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B3D7C433F5 for ; Thu, 7 Apr 2022 00:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jXE9J1PQVbzijBdLFqxKxFoEjjR92hDhVF4kMIi2rU4=; b=FTHf/D9CpGqQ2V 86rGT/DS21AeeVEZuOPL0Nzv22SgUxuPWwbk8N2jx6mtXaTa3Rc2K8Z/u/+0SKIP4QQl8WoSpbO6/ beZgIiRu5ci9TITA8/xDeEXSnPWcr0gDCitIlKVtbPqo/WzVTBQnmxKUj7/u22p/MRU0wQ0+Lc41T Ie9tq9Bf3bQCIVdw7BUqzVX2bOMDckX2CkkqTHzoIsXG97a/n+V5VBtVXepeXjEyMKNNuEIHcVWbN JIRmSzDkPjSrQ9aWA28WwdoEH+EmkBZFBL3KOsgpzTZswAAaHDaVPE7x2E4nVe5Rp9JXHwZs3KyAj wnXaJ8gh5pmxsulB52Hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncFZe-008MBc-Th; Thu, 07 Apr 2022 00:00:31 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncFZQ-008M5B-Qx for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 00:00:18 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id DA4BF83E1E; Thu, 7 Apr 2022 02:00:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1649289612; bh=yzZFAWlsDijA2rzSPEF8dwBfy3kPOX/o4JtiIJJka/k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RzU7cQU+TkTcyVFFd6QCfEZEMOBmWpIUVWBrSWXouDTKrv5BgkwAowQ3ekOIVmLK7 q0EP79wwK3e1Yxa/8Sx9xyn851uMWuLc7aoixNpjvsAn6QFTaBMdCYiIx77XKIb62r nojqzvI1biZNiUo62M+AmIKv/GfBgLszRv/C9YQgzkzD0P/xqaotaR7zQ7g1kjp2RG t8d2l+64HEPDnLzazq3RVHfgyGvyAabxC4wJZ0URNAEwlr8vzoqU9NUlOU8SiL64zJ XuZTYaAzKhvO5jYmBjaoG7M+g71IKhJMtGRPTRrWcT82XGSEweDxoYwgj9nuiADdrD 3Dh3R7R9iTRGg== Message-ID: Date: Thu, 7 Apr 2022 01:56:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v4 07/11] soc: imx: add i.MX8MP HDMI blk-ctrl Content-Language: en-US To: Lucas Stach , Shawn Guo , Rob Herring , Krzysztof Kozlowski Cc: Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , Laurent Pinchart , Paul Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220406153402.1265474-1-l.stach@pengutronix.de> <20220406153402.1265474-8-l.stach@pengutronix.de> From: Marek Vasut In-Reply-To: <20220406153402.1265474-8-l.stach@pengutronix.de> X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220406_170017_067270_B7FE6C91 X-CRM114-Status: UNSURE ( 7.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/6/22 17:33, Lucas Stach wrote: [...] > +static void imx8mp_hdmi_blk_ctrl_power_on(struct imx8mp_blk_ctrl *bc, > + struct imx8mp_blk_ctrl_domain *domain) > +{ > + switch (domain->id) { > + case IMX8MP_HDMIBLK_PD_IRQSTEER: > + regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL0, BIT(9)); > + regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, BIT(16)); > + break; > + case IMX8MP_HDMIBLK_PD_LCDIF: > + regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL0, > + BIT(7) | BIT(16) | BIT(17) | BIT(18) | > + BIT(19) | BIT(20)); > + regmap_set_bits(bc->regmap, HDMI_RTX_CLK_CTL1, BIT(11)); > + regmap_set_bits(bc->regmap, HDMI_RTX_RESET_CTL0, > + BIT(4) | BIT(5) | BIT(6)); Macros which define all those ad-hoc bits might be nice. [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel