linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/7] Add Interrupts property for CDNS CSI2RX
@ 2025-07-14  9:27 Yemike Abhilash Chandra
  2025-07-14  9:27 ` [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
                   ` (8 more replies)
  0 siblings, 9 replies; 18+ messages in thread
From: Yemike Abhilash Chandra @ 2025-07-14  9:27 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1, y-abhilashchandra

The driver patch that adds support for error detection on the
Cadence CSI2RX by enabling its interrupt lines was recently
picked up [0].

Accordingly, this patch adds the required interrupts property
to the Cadence CSI2RX device tree nodes.

Test logs:
(To validate the complete functionality, CRC errors were
intentionally generated by modifying the sensor overlay)

AM68: https://gist.github.com/Yemike-Abhilash-Chandra/123fed82e798a76944ec23f8e46d1114
AM69: https://gist.github.com/Yemike-Abhilash-Chandra/1820e39888cb50e250a83e2d059365f6
J721E: https://gist.github.com/Yemike-Abhilash-Chandra/63f993a995fd6a12cb113454952c063f
J722S: https://gist.github.com/Yemike-Abhilash-Chandra/2144fc8ab2f7bcdb3ef868e85424467d 
J721S2: https://gist.github.com/Yemike-Abhilash-Chandra/f46587ec1ef72671ee31803dd93434b4
J784S4: https://gist.github.com/Yemike-Abhilash-Chandra/0c594683772f11c70bccb508757e9799

Driver and Binding patch series: https://lore.kernel.org/all/20250416121938.346435-1-y-abhilashchandra@ti.com/

[0]: https://lore.kernel.org/all/aG9tuMFOnvwXkcE-@valkosipuli.retiisi.eu/

Yemike Abhilash Chandra (7):
  arm64: dts: ti: k3-j721s2-main: Add interrupts property
  arm64: dts: ti: k3-j721e-main: Add interrupts property
  arm64: dts: ti: k3-j784s4-j742s2-main-common: Add interrupts property
  arm64: dts: ti: k3-am62p-j722s-common-main: Add interrupts property
  arm64: dts: ti: k3-j722s-main: Add interrupts property
  arm64: dts: ti: k3-am62-main: Add interrupts property
  arm64: dts: ti: k3-am62a-main: Add interrupts property

 arch/arm64/boot/dts/ti/k3-am62-main.dtsi                 | 3 +++
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi                | 3 +++
 arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi   | 3 +++
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi                | 6 ++++++
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi               | 6 ++++++
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi                | 9 +++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 9 +++++++++
 7 files changed, 39 insertions(+)

-- 
2.34.1



^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
@ 2025-07-14  9:27 ` Yemike Abhilash Chandra
  2025-07-21 14:07   ` Kumar, Udit
  2025-07-14  9:27 ` [PATCH 2/7] arm64: dts: ti: k3-j721e-main: " Yemike Abhilash Chandra
                   ` (7 subsequent siblings)
  8 siblings, 1 reply; 18+ messages in thread
From: Yemike Abhilash Chandra @ 2025-07-14  9:27 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1, y-abhilashchandra

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
J721S2 TRM [0].

Interrupt Line      | Source Interrupt
--------------------|----------------------------
GIC500SS_SPI_IN_153 | CSI_RX_IF1_CSI_ERR_IRQ_0
GIC500SS_SPI_IN_152 | CSI_RX_IF1_CSI_IRQ_0
GIC500SS_SPI_IN_157 | CSI_RX_IF2_CSI_ERR_IRQ_0
GIC500SS_SPI_IN_156 | CSI_RX_IF2_CSI_IRQ_0

[0]: https://www.ti.com/lit/zip/spruj28

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
index 62f45377a2c9..6f32a2b0c40c 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
@@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
 		cdns_csi2rx0: csi-bridge@4504000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04504000 0x00 0x1000>;
+			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 38 3>, <&k3_clks 38 1>, <&k3_clks 38 3>,
 				<&k3_clks 38 3>, <&k3_clks 38 4>, <&k3_clks 38 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -1301,6 +1304,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
 		cdns_csi2rx1: csi-bridge@4514000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04514000 0x00 0x1000>;
+			interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 39 3>, <&k3_clks 39 1>, <&k3_clks 39 3>,
 				<&k3_clks 39 3>, <&k3_clks 39 4>, <&k3_clks 39 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 2/7] arm64: dts: ti: k3-j721e-main: Add interrupts property
  2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
  2025-07-14  9:27 ` [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
@ 2025-07-14  9:27 ` Yemike Abhilash Chandra
  2025-07-14  9:27 ` [PATCH 3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: " Yemike Abhilash Chandra
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 18+ messages in thread
From: Yemike Abhilash Chandra @ 2025-07-14  9:27 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1, y-abhilashchandra

Add interrupts property for CSI2RX. Interrupt IDs are taken from the
J721E TRM [0].

Interrupt Line      | Source Interrupt
--------------------|----------------------------
GIC500_SPI_IN_185 | CSI_RX_IF1_CSI_ERR_IRQ_0
GIC500_SPI_IN_184 | CSI_RX_IF1_CSI_IRQ_0
GIC500_SPI_IN_189 | CSI_RX_IF2_CSI_ERR_IRQ_0
GIC500_SPI_IN_188 | CSI_RX_IF2_CSI_IRQ_0

[0]: http://www.ti.com/lit/pdf/spruil1

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 5bd0d36bf33e..ab3666ff4297 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -608,6 +608,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
 		cdns_csi2rx0: csi-bridge@4504000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x0 0x4504000 0x0 0x1000>;
+			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 26 2>, <&k3_clks 26 0>, <&k3_clks 26 2>,
 				<&k3_clks 26 2>, <&k3_clks 26 3>, <&k3_clks 26 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -661,6 +664,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
 		cdns_csi2rx1: csi-bridge@4514000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x0 0x4514000 0x0 0x1000>;
+			interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 27 2>, <&k3_clks 27 0>, <&k3_clks 27 2>,
 				 <&k3_clks 27 2>, <&k3_clks 27 3>, <&k3_clks 27 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: Add interrupts property
  2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
  2025-07-14  9:27 ` [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
  2025-07-14  9:27 ` [PATCH 2/7] arm64: dts: ti: k3-j721e-main: " Yemike Abhilash Chandra
@ 2025-07-14  9:27 ` Yemike Abhilash Chandra
  2025-07-14  9:27 ` [PATCH 4/7] arm64: dts: ti: k3-am62p-j722s-common-main: " Yemike Abhilash Chandra
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 18+ messages in thread
From: Yemike Abhilash Chandra @ 2025-07-14  9:27 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1, y-abhilashchandra

Add interrupts property for CSI2RX. Interrupt IDs are taken from the
J784S4 TRM [0].

Interrupt Line    | Source Interrupt
------------------|----------------------------
GIC500SS_0_SPI_IN_185 | CSI_RX_IF1_CSI_ERR_IRQ_0
GIC500SS_0_SPI_IN_184 | CSI_RX_IF1_CSI_IRQ_0
GIC500SS_0_SPI_IN_189 | CSI_RX_IF2_CSI_ERR_IRQ_0
GIC500SS_0_SPI_IN_188 | CSI_RX_IF2_CSI_IRQ_0
GIC500SS_0_SPI_IN_193 | CSI_RX_IF3_CSI_ERR_IRQ_0
GIC500SS_0_SPI_IN_192 | CSI_RX_IF3_CSI_IRQ_0

[0]: https://www.ti.com/lit/zip/spruj52

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
index 7c5b0c69897d..2159ce0c942f 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
@@ -819,6 +819,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
 		cdns_csi2rx0: csi-bridge@4504000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04504000 0x00 0x00001000>;
+			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 72 2>, <&k3_clks 72 0>, <&k3_clks 72 2>,
 				<&k3_clks 72 2>, <&k3_clks 72 3>, <&k3_clks 72 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -872,6 +875,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
 		cdns_csi2rx1: csi-bridge@4514000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04514000 0x00 0x00001000>;
+			interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 73 2>, <&k3_clks 73 0>, <&k3_clks 73 2>,
 				<&k3_clks 73 2>, <&k3_clks 73 3>, <&k3_clks 73 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -924,6 +930,9 @@ ti_csi2rx2: ticsi2rx@4520000 {
 		cdns_csi2rx2: csi-bridge@4524000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x04524000 0x00 0x00001000>;
+			interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 74 2>, <&k3_clks 74 0>, <&k3_clks 74 2>,
 				<&k3_clks 74 2>, <&k3_clks 74 3>, <&k3_clks 74 3>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 4/7] arm64: dts: ti: k3-am62p-j722s-common-main: Add interrupts property
  2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (2 preceding siblings ...)
  2025-07-14  9:27 ` [PATCH 3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: " Yemike Abhilash Chandra
@ 2025-07-14  9:27 ` Yemike Abhilash Chandra
  2025-07-14  9:27 ` [PATCH 5/7] arm64: dts: ti: k3-j722s-main: " Yemike Abhilash Chandra
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 18+ messages in thread
From: Yemike Abhilash Chandra @ 2025-07-14  9:27 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1, y-abhilashchandra

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
J722S TRM [0].

Interrupt Line    | Source Interrupt
------------------|-------------------------
GICSS0_SPI_IN_175 | CSI_RX_IF0_CSI_ERR_IRQ_0
GICSS0_SPI_IN_173 | CSI_RX_IF0_CSI_IRQ_0

[0]: https://www.ti.com/lit/zip/sprujb3

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
index 2e5e25a8ca86..4427b12058a6 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi
@@ -1045,6 +1045,9 @@ ti_csi2rx0: ticsi2rx@30102000 {
 		cdns_csi2rx0: csi-bridge@30101000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30101000 0x00 0x1000>;
+			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 182 0>, <&k3_clks 182 3>, <&k3_clks 182 0>,
 				<&k3_clks 182 0>, <&k3_clks 182 4>, <&k3_clks 182 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 5/7] arm64: dts: ti: k3-j722s-main: Add interrupts property
  2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (3 preceding siblings ...)
  2025-07-14  9:27 ` [PATCH 4/7] arm64: dts: ti: k3-am62p-j722s-common-main: " Yemike Abhilash Chandra
@ 2025-07-14  9:27 ` Yemike Abhilash Chandra
  2025-07-14  9:27 ` [PATCH 6/7] arm64: dts: ti: k3-am62-main: " Yemike Abhilash Chandra
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 18+ messages in thread
From: Yemike Abhilash Chandra @ 2025-07-14  9:27 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1, y-abhilashchandra

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
J722S TRM [0].

Interrupt Line    | Source Interrupt
------------------|-------------------------
GICSS0_SPI_IN_178 | CSI_RX_IF1_CSI_ERR_IRQ_0
GICSS0_SPI_IN_179 | CSI_RX_IF1_CSI_IRQ_0
GICSS0_SPI_IN_219 | CSI_RX_IF2_CSI_ERR_IRQ_0
GICSS0_SPI_IN_232 | CSI_RX_IF2_CSI_IRQ_0
GICSS0_SPI_IN_249 | CSI_RX_IF3_CSI_ERR_IRQ_0
GICSS0_SPI_IN_250 | CSI_RX_IF3_CSI_IRQ_0

[0]: https://www.ti.com/lit/zip/sprujb3

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
index 5cfa7bf36641..6a8e5ff3b1d5 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
@@ -168,6 +168,9 @@ ti_csi2rx1: ticsi2rx@30122000 {
 		cdns_csi2rx1: csi-bridge@30121000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30121000 0x00 0x1000>;
+			interrupts = <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 247 0>, <&k3_clks 247 3>, <&k3_clks 247 0>,
 				 <&k3_clks 247 0>, <&k3_clks 247 4>, <&k3_clks 247 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -221,6 +224,9 @@ ti_csi2rx2: ticsi2rx@30142000 {
 		cdns_csi2rx2: csi-bridge@30141000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30141000 0x00 0x1000>;
+			interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 248 0>, <&k3_clks 248 3>, <&k3_clks 248 0>,
 				 <&k3_clks 248 0>, <&k3_clks 248 4>, <&k3_clks 248 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
@@ -274,6 +280,9 @@ ti_csi2rx3: ticsi2rx@30162000 {
 		cdns_csi2rx3: csi-bridge@30161000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30161000 0x00 0x1000>;
+			interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 249 0>, <&k3_clks 249 3>, <&k3_clks 249 0>,
 				 <&k3_clks 249 0>, <&k3_clks 249 4>, <&k3_clks 249 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 6/7] arm64: dts: ti: k3-am62-main: Add interrupts property
  2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (4 preceding siblings ...)
  2025-07-14  9:27 ` [PATCH 5/7] arm64: dts: ti: k3-j722s-main: " Yemike Abhilash Chandra
@ 2025-07-14  9:27 ` Yemike Abhilash Chandra
  2025-07-14  9:27 ` [PATCH 7/7] arm64: dts: ti: k3-am62a-main: " Yemike Abhilash Chandra
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 18+ messages in thread
From: Yemike Abhilash Chandra @ 2025-07-14  9:27 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1, y-abhilashchandra

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
AM62 TRM [0].

Input Index    | Interrupt Source
---------------|--------------------------
gicss0.spi.175 | csi_rx_if.0.csi_err_irq.0
gicss0.spi.173 | csi_rx_if.0.csi_irq.0

[0]: https://www.ti.com/lit/pdf/spruiv7

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index 120ba8f9dd0e..029380dc1a35 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -1031,6 +1031,9 @@ ti_csi2rx0: ticsi2rx@30102000 {
 		cdns_csi2rx0: csi-bridge@30101000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30101000 0x00 0x1000>;
+			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 182 0>, <&k3_clks 182 3>, <&k3_clks 182 0>,
 				<&k3_clks 182 0>, <&k3_clks 182 4>, <&k3_clks 182 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH 7/7] arm64: dts: ti: k3-am62a-main: Add interrupts property
  2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (5 preceding siblings ...)
  2025-07-14  9:27 ` [PATCH 6/7] arm64: dts: ti: k3-am62-main: " Yemike Abhilash Chandra
@ 2025-07-14  9:27 ` Yemike Abhilash Chandra
  2025-07-14 15:24 ` [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Rob Herring (Arm)
  2025-07-17 20:45 ` Jared McArthur
  8 siblings, 0 replies; 18+ messages in thread
From: Yemike Abhilash Chandra @ 2025-07-14  9:27 UTC (permalink / raw)
  To: nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1, y-abhilashchandra

Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
AM62A TRM [0].

Interrupt Line             | Source Interrupt
---------------------------|-------------------------
GICSS0_COMMON_0_SPI_IN_175 | CSI_RX_IF0_COMMON_0_CSI_ERR_IRQ_0
GICSS0_COMMON_0_SPI_IN_173 | CSI_RX_IF0_COMMON_0_CSI_IRQ_0

[0]: https://www.ti.com/lit/pdf/spruj16

Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index 63e097ddf988..39c27eb29e17 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -1041,6 +1041,9 @@ ti_csi2rx0: ticsi2rx@30102000 {
 		cdns_csi2rx0: csi-bridge@30101000 {
 			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
 			reg = <0x00 0x30101000 0x00 0x1000>;
+			interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "error_irq", "irq";
 			clocks = <&k3_clks 182 0>, <&k3_clks 182 3>, <&k3_clks 182 0>,
 				<&k3_clks 182 0>, <&k3_clks 182 4>, <&k3_clks 182 4>;
 			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/7] Add Interrupts property for CDNS CSI2RX
  2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (6 preceding siblings ...)
  2025-07-14  9:27 ` [PATCH 7/7] arm64: dts: ti: k3-am62a-main: " Yemike Abhilash Chandra
@ 2025-07-14 15:24 ` Rob Herring (Arm)
  2025-07-17 20:45 ` Jared McArthur
  8 siblings, 0 replies; 18+ messages in thread
From: Rob Herring (Arm) @ 2025-07-14 15:24 UTC (permalink / raw)
  To: Yemike Abhilash Chandra
  Cc: conor+dt, devicetree, nm, vigneshr, imx, linux-kernel, krzk+dt,
	kristo, vaishnav.a, linux-arm-kernel, u-kumar1


On Mon, 14 Jul 2025 14:57:01 +0530, Yemike Abhilash Chandra wrote:
> The driver patch that adds support for error detection on the
> Cadence CSI2RX by enabling its interrupt lines was recently
> picked up [0].
> 
> Accordingly, this patch adds the required interrupts property
> to the Cadence CSI2RX device tree nodes.
> 
> Test logs:
> (To validate the complete functionality, CRC errors were
> intentionally generated by modifying the sensor overlay)
> 
> AM68: https://gist.github.com/Yemike-Abhilash-Chandra/123fed82e798a76944ec23f8e46d1114
> AM69: https://gist.github.com/Yemike-Abhilash-Chandra/1820e39888cb50e250a83e2d059365f6
> J721E: https://gist.github.com/Yemike-Abhilash-Chandra/63f993a995fd6a12cb113454952c063f
> J722S: https://gist.github.com/Yemike-Abhilash-Chandra/2144fc8ab2f7bcdb3ef868e85424467d
> J721S2: https://gist.github.com/Yemike-Abhilash-Chandra/f46587ec1ef72671ee31803dd93434b4
> J784S4: https://gist.github.com/Yemike-Abhilash-Chandra/0c594683772f11c70bccb508757e9799
> 
> Driver and Binding patch series: https://lore.kernel.org/all/20250416121938.346435-1-y-abhilashchandra@ti.com/
> 
> [0]: https://lore.kernel.org/all/aG9tuMFOnvwXkcE-@valkosipuli.retiisi.eu/
> 
> Yemike Abhilash Chandra (7):
>   arm64: dts: ti: k3-j721s2-main: Add interrupts property
>   arm64: dts: ti: k3-j721e-main: Add interrupts property
>   arm64: dts: ti: k3-j784s4-j742s2-main-common: Add interrupts property
>   arm64: dts: ti: k3-am62p-j722s-common-main: Add interrupts property
>   arm64: dts: ti: k3-j722s-main: Add interrupts property
>   arm64: dts: ti: k3-am62-main: Add interrupts property
>   arm64: dts: ti: k3-am62a-main: Add interrupts property
> 
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi                 | 3 +++
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi                | 3 +++
>  arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi   | 3 +++
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi                | 6 ++++++
>  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi               | 6 ++++++
>  arch/arm64/boot/dts/ti/k3-j722s-main.dtsi                | 9 +++++++++
>  arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 9 +++++++++
>  7 files changed, 39 insertions(+)
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/v6.16-rc1-21-g3b08f8a34a20 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/ti/' for 20250714092708.3944641-1-y-abhilashchandra@ti.com:

arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dev.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dev.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dahlia.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-dahlia.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-yavia.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-yavia.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-ivy.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: ticsi2rx@4500000 (ti,j721e-csi2rx-shim): csi-bridge@4504000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-ivy.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: csi-bridge@4504000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-ivy.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-ivy.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: ticsi2rx@4510000 (ti,j721e-csi2rx-shim): csi-bridge@4514000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb: csi-bridge@4514000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j742s2-evm.dtb: ticsi2rx@4500000 (ti,j721e-csi2rx-shim): csi-bridge@4504000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j742s2-evm.dtb: csi-bridge@4504000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j742s2-evm.dtb: ticsi2rx@4510000 (ti,j721e-csi2rx-shim): csi-bridge@4514000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j742s2-evm.dtb: csi-bridge@4514000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j742s2-evm.dtb: ticsi2rx@4520000 (ti,j721e-csi2rx-shim): csi-bridge@4524000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j742s2-evm.dtb: csi-bridge@4524000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dahlia.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dahlia.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-sk.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62-pocketbeagle2.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-mallow.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-mallow.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dtb: ticsi2rx@4500000 (ti,j721e-csi2rx-shim): csi-bridge@4504000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dtb: csi-bridge@4504000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dtb: ticsi2rx@4510000 (ti,j721e-csi2rx-shim): csi-bridge@4514000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dtb: csi-bridge@4514000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62a7-phyboard-lyra-rdk.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62a7-phyboard-lyra-rdk.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-mallow.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-mallow.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-dev.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-dahlia.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-dahlia.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j722s-evm.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j722s-evm.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j722s-evm.dtb: ticsi2rx@30122000 (ti,j721e-csi2rx-shim): csi-bridge@30121000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j722s-evm.dtb: csi-bridge@30121000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j722s-evm.dtb: ticsi2rx@30142000 (ti,j721e-csi2rx-shim): csi-bridge@30141000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j722s-evm.dtb: csi-bridge@30141000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j722s-evm.dtb: ticsi2rx@30162000 (ti,j721e-csi2rx-shim): csi-bridge@30161000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j722s-evm.dtb: csi-bridge@30161000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-dev.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-dev.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dtb: ticsi2rx@4500000 (ti,j721e-csi2rx-shim): csi-bridge@4504000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dtb: csi-bridge@4504000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dtb: ticsi2rx@4510000 (ti,j721e-csi2rx-shim): csi-bridge@4514000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dtb: csi-bridge@4514000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-ivy.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-ivy.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am69-sk.dtb: ticsi2rx@4500000 (ti,j721e-csi2rx-shim): csi-bridge@4504000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am69-sk.dtb: csi-bridge@4504000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am69-sk.dtb: ticsi2rx@4510000 (ti,j721e-csi2rx-shim): csi-bridge@4514000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am69-sk.dtb: csi-bridge@4514000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am69-sk.dtb: ticsi2rx@4520000 (ti,j721e-csi2rx-shim): csi-bridge@4524000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am69-sk.dtb: csi-bridge@4524000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62-lp-sk.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-dahlia.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-dahlia.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-yavia.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-yavia.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am68-phyboard-izar.dtb: ticsi2rx@4500000 (ti,j721e-csi2rx-shim): csi-bridge@4504000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am68-phyboard-izar.dtb: csi-bridge@4504000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am68-phyboard-izar.dtb: ticsi2rx@4510000 (ti,j721e-csi2rx-shim): csi-bridge@4514000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am68-phyboard-izar.dtb: csi-bridge@4514000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-yavia.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-nonwifi-yavia.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: ticsi2rx@4500000 (ti,j721e-csi2rx-shim): csi-bridge@4504000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: csi-bridge@4504000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: ticsi2rx@4510000 (ti,j721e-csi2rx-shim): csi-bridge@4514000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: csi-bridge@4514000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb: ticsi2rx@30122000 (ti,j721e-csi2rx-shim): csi-bridge@30121000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb: csi-bridge@30121000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb: ticsi2rx@30142000 (ti,j721e-csi2rx-shim): csi-bridge@30141000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb: csi-bridge@30141000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb: ticsi2rx@30162000 (ti,j721e-csi2rx-shim): csi-bridge@30161000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am67a-beagley-ai.dtb: csi-bridge@30161000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-yavia.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-yavia.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j784s4-evm.dtb: ticsi2rx@4500000 (ti,j721e-csi2rx-shim): csi-bridge@4504000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j784s4-evm.dtb: csi-bridge@4504000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j784s4-evm.dtb: ticsi2rx@4510000 (ti,j721e-csi2rx-shim): csi-bridge@4514000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j784s4-evm.dtb: csi-bridge@4514000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j784s4-evm.dtb: ticsi2rx@4520000 (ti,j721e-csi2rx-shim): csi-bridge@4524000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j784s4-evm.dtb: csi-bridge@4524000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-sk.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-sk.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-ivy.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-ivy.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-dev.dtb: ticsi2rx@30102000 (ti,j721e-csi2rx-shim): csi-bridge@30101000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-am62p5-verdin-wifi-dev.dtb: csi-bridge@30101000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j721e-sk.dtb: ticsi2rx@4500000 (ti,j721e-csi2rx-shim): csi-bridge@4504000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j721e-sk.dtb: csi-bridge@4504000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#
arch/arm64/boot/dts/ti/k3-j721e-sk.dtb: ticsi2rx@4510000 (ti,j721e-csi2rx-shim): csi-bridge@4514000: 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/ti,j721e-csi2rx-shim.yaml#
arch/arm64/boot/dts/ti/k3-j721e-sk.dtb: csi-bridge@4514000 (ti,j721e-csi2rx): 'interrupt-names', 'interrupts' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/media/cdns,csi2rx.yaml#







^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 0/7] Add Interrupts property for CDNS CSI2RX
  2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
                   ` (7 preceding siblings ...)
  2025-07-14 15:24 ` [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Rob Herring (Arm)
@ 2025-07-17 20:45 ` Jared McArthur
  8 siblings, 0 replies; 18+ messages in thread
From: Jared McArthur @ 2025-07-17 20:45 UTC (permalink / raw)
  To: Yemike Abhilash Chandra, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1

On 7/14/25 04:27, Yemike Abhilash Chandra wrote:
> The driver patch that adds support for error detection on the
> Cadence CSI2RX by enabling its interrupt lines was recently
> picked up [0].
> 
> Accordingly, this patch adds the required interrupts property
> to the Cadence CSI2RX device tree nodes.
> 
> Test logs:
> (To validate the complete functionality, CRC errors were
> intentionally generated by modifying the sensor overlay)
> 
> AM68: https://gist.github.com/Yemike-Abhilash-Chandra/123fed82e798a76944ec23f8e46d1114
> AM69: https://gist.github.com/Yemike-Abhilash-Chandra/1820e39888cb50e250a83e2d059365f6
> J721E: https://gist.github.com/Yemike-Abhilash-Chandra/63f993a995fd6a12cb113454952c063f
> J722S: https://gist.github.com/Yemike-Abhilash-Chandra/2144fc8ab2f7bcdb3ef868e85424467d 
> J721S2: https://gist.github.com/Yemike-Abhilash-Chandra/f46587ec1ef72671ee31803dd93434b4
> J784S4: https://gist.github.com/Yemike-Abhilash-Chandra/0c594683772f11c70bccb508757e9799
> 
> Driver and Binding patch series: https://lore.kernel.org/all/20250416121938.346435-1-y-abhilashchandra@ti.com/
> 
> [0]: https://lore.kernel.org/all/aG9tuMFOnvwXkcE-@valkosipuli.retiisi.eu/
> 
> Yemike Abhilash Chandra (7):
>   arm64: dts: ti: k3-j721s2-main: Add interrupts property
>   arm64: dts: ti: k3-j721e-main: Add interrupts property
>   arm64: dts: ti: k3-j784s4-j742s2-main-common: Add interrupts property
>   arm64: dts: ti: k3-am62p-j722s-common-main: Add interrupts property
>   arm64: dts: ti: k3-j722s-main: Add interrupts property
>   arm64: dts: ti: k3-am62-main: Add interrupts property
>   arm64: dts: ti: k3-am62a-main: Add interrupts property
> 
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi                 | 3 +++
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi                | 3 +++
>  arch/arm64/boot/dts/ti/k3-am62p-j722s-common-main.dtsi   | 3 +++
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi                | 6 ++++++
>  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi               | 6 ++++++
>  arch/arm64/boot/dts/ti/k3-j722s-main.dtsi                | 9 +++++++++
>  arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 9 +++++++++
>  7 files changed, 39 insertions(+)
> 

For the whole series.

Reviewed-by: Jared McArthur <j-mcarthur@ti.com>

-- 
Best,
Jared McArthur


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-07-14  9:27 ` [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
@ 2025-07-21 14:07   ` Kumar, Udit
  2025-07-21 14:09     ` Krzysztof Kozlowski
  2025-07-21 14:10     ` Kumar, Udit
  0 siblings, 2 replies; 18+ messages in thread
From: Kumar, Udit @ 2025-07-21 14:07 UTC (permalink / raw)
  To: Yemike Abhilash Chandra, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1


On 7/14/2025 2:57 PM, Yemike Abhilash Chandra wrote:
> Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
> J721S2 TRM [0].
>
> Interrupt Line      | Source Interrupt
> --------------------|----------------------------
> GIC500SS_SPI_IN_153 | CSI_RX_IF1_CSI_ERR_IRQ_0
> GIC500SS_SPI_IN_152 | CSI_RX_IF1_CSI_IRQ_0
> GIC500SS_SPI_IN_157 | CSI_RX_IF2_CSI_ERR_IRQ_0
> GIC500SS_SPI_IN_156 | CSI_RX_IF2_CSI_IRQ_0
>
> [0]: https://www.ti.com/lit/zip/spruj28
>
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 62f45377a2c9..6f32a2b0c40c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>   		cdns_csi2rx0: csi-bridge@4504000 {
>   			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>   			reg = <0x00 0x04504000 0x00 0x1000>;
> +			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;

Just cosmetic thing, if you are doing v2 then consider 152 first , 
followed by 153.

Otherwise

Reviewed-by: Udit Kumar <u-kumar1@ti.com>

> +			interrupt-names = "error_irq", "irq";
>   			clocks = <&k3_clks 38 3>, <&k3_clks 38 1>, <&k3_clks 38 3>,
>   				<&k3_clks 38 3>, <&k3_clks 38 4>, <&k3_clks 38 4>;
>   			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
> @@ -1301,6 +1304,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
>   		cdns_csi2rx1: csi-bridge@4514000 {
>   			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>   			reg = <0x00 0x04514000 0x00 0x1000>;
> +			interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "error_irq", "irq";
>   			clocks = <&k3_clks 39 3>, <&k3_clks 39 1>, <&k3_clks 39 3>,
>   				<&k3_clks 39 3>, <&k3_clks 39 4>, <&k3_clks 39 4>;
>   			clock-names = "sys_clk", "p_clk", "pixel_if0_clk",


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-07-21 14:07   ` Kumar, Udit
@ 2025-07-21 14:09     ` Krzysztof Kozlowski
  2025-07-21 14:12       ` Kumar, Udit
  2025-07-21 14:10     ` Kumar, Udit
  1 sibling, 1 reply; 18+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-21 14:09 UTC (permalink / raw)
  To: Kumar, Udit, Yemike Abhilash Chandra, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel

On 21/07/2025 16:07, Kumar, Udit wrote:
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> index 62f45377a2c9..6f32a2b0c40c 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>>   		cdns_csi2rx0: csi-bridge@4504000 {
>>   			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>   			reg = <0x00 0x04504000 0x00 0x1000>;
>> +			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>> +				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
> 
> Just cosmetic thing, if you are doing v2 then consider 152 first , 
> followed by 153.


No, you cannot just randomly change numbers or the order.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-07-21 14:07   ` Kumar, Udit
  2025-07-21 14:09     ` Krzysztof Kozlowski
@ 2025-07-21 14:10     ` Kumar, Udit
  2025-07-22  5:50       ` Yemike Abhilash Chandra
  1 sibling, 1 reply; 18+ messages in thread
From: Kumar, Udit @ 2025-07-21 14:10 UTC (permalink / raw)
  To: Yemike Abhilash Chandra, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1


On 7/21/2025 7:37 PM, Kumar, Udit wrote:
>
> On 7/14/2025 2:57 PM, Yemike Abhilash Chandra wrote:
>> Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from 
>> the
>> J721S2 TRM [0].
>>
>> Interrupt Line      | Source Interrupt
>> --------------------|----------------------------
>> GIC500SS_SPI_IN_153 | CSI_RX_IF1_CSI_ERR_IRQ_0
>> GIC500SS_SPI_IN_152 | CSI_RX_IF1_CSI_IRQ_0
>> GIC500SS_SPI_IN_157 | CSI_RX_IF2_CSI_ERR_IRQ_0
>> GIC500SS_SPI_IN_156 | CSI_RX_IF2_CSI_IRQ_0
>>
>> [0]: https://www.ti.com/lit/zip/spruj28
>>
>> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi 
>> b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> index 62f45377a2c9..6f32a2b0c40c 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>>           cdns_csi2rx0: csi-bridge@4504000 {
>>               compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>               reg = <0x00 0x04504000 0x00 0x1000>;
>> +            interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>> +                     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>
> Just cosmetic thing, if you are doing v2 then consider 152 first , 
> followed by 153.
>
> Otherwise
>
> Reviewed-by: Udit Kumar <u-kumar1@ti.com>


Sorry, sent too fast, offset of 32 missing .


>
>> +            interrupt-names = "error_irq", "irq";
>>               clocks = <&k3_clks 38 3>, <&k3_clks 38 1>, <&k3_clks 38 
>> 3>,
>>                   <&k3_clks 38 3>, <&k3_clks 38 4>, <&k3_clks 38 4>;
>>               clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
>> @@ -1301,6 +1304,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
>>           cdns_csi2rx1: csi-bridge@4514000 {
>>               compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>               reg = <0x00 0x04514000 0x00 0x1000>;
>> +            interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
>> +                     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
>> +            interrupt-names = "error_irq", "irq";
>>               clocks = <&k3_clks 39 3>, <&k3_clks 39 1>, <&k3_clks 39 
>> 3>,
>>                   <&k3_clks 39 3>, <&k3_clks 39 4>, <&k3_clks 39 4>;
>>               clock-names = "sys_clk", "p_clk", "pixel_if0_clk",


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-07-21 14:09     ` Krzysztof Kozlowski
@ 2025-07-21 14:12       ` Kumar, Udit
  2025-07-21 14:22         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 18+ messages in thread
From: Kumar, Udit @ 2025-07-21 14:12 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Yemike Abhilash Chandra, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1


On 7/21/2025 7:39 PM, Krzysztof Kozlowski wrote:
> On 21/07/2025 16:07, Kumar, Udit wrote:
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> index 62f45377a2c9..6f32a2b0c40c 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>>>    		cdns_csi2rx0: csi-bridge@4504000 {
>>>    			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>    			reg = <0x00 0x04504000 0x00 0x1000>;
>>> +			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>>> +				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>> Just cosmetic thing, if you are doing v2 then consider 152 first ,
>> followed by 153.
>
> No, you cannot just randomly change numbers or the order.
>
To be precise both , interrupt-names and interrupts,

if this make sense to change.


> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-07-21 14:12       ` Kumar, Udit
@ 2025-07-21 14:22         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 18+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-21 14:22 UTC (permalink / raw)
  To: Kumar, Udit, Yemike Abhilash Chandra, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel

On 21/07/2025 16:12, Kumar, Udit wrote:
> 
> On 7/21/2025 7:39 PM, Krzysztof Kozlowski wrote:
>> On 21/07/2025 16:07, Kumar, Udit wrote:
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> index 62f45377a2c9..6f32a2b0c40c 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>>>>    		cdns_csi2rx0: csi-bridge@4504000 {
>>>>    			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>>    			reg = <0x00 0x04504000 0x00 0x1000>;
>>>> +			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>>>> +				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>>> Just cosmetic thing, if you are doing v2 then consider 152 first ,
>>> followed by 153.
>>
>> No, you cannot just randomly change numbers or the order.
>>
> To be precise both , interrupt-names and interrupts,
> 
> if this make sense to change.

No, it does not makes any sense. You cannot change the order and if you
tested this, you would see errors.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-07-21 14:10     ` Kumar, Udit
@ 2025-07-22  5:50       ` Yemike Abhilash Chandra
  2025-07-25 10:46         ` Kumar, Udit
  2025-07-30 19:35         ` Jared McArthur
  0 siblings, 2 replies; 18+ messages in thread
From: Yemike Abhilash Chandra @ 2025-07-22  5:50 UTC (permalink / raw)
  To: Kumar, Udit, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel

Hi Udit,

Thanks for the review.

On 21/07/25 19:40, Kumar, Udit wrote:
> 
> On 7/21/2025 7:37 PM, Kumar, Udit wrote:
>>
>> On 7/14/2025 2:57 PM, Yemike Abhilash Chandra wrote:
>>> Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from 
>>> the
>>> J721S2 TRM [0].
>>>
>>> Interrupt Line      | Source Interrupt
>>> --------------------|----------------------------
>>> GIC500SS_SPI_IN_153 | CSI_RX_IF1_CSI_ERR_IRQ_0
>>> GIC500SS_SPI_IN_152 | CSI_RX_IF1_CSI_IRQ_0
>>> GIC500SS_SPI_IN_157 | CSI_RX_IF2_CSI_ERR_IRQ_0
>>> GIC500SS_SPI_IN_156 | CSI_RX_IF2_CSI_IRQ_0
>>>
>>> [0]: https://www.ti.com/lit/zip/spruj28
>>>
>>> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
>>> ---
>>>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi 
>>> b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> index 62f45377a2c9..6f32a2b0c40c 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>>>           cdns_csi2rx0: csi-bridge@4504000 {
>>>               compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>               reg = <0x00 0x04504000 0x00 0x1000>;
>>> +            interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>>> +                     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>>
>> Just cosmetic thing, if you are doing v2 then consider 152 first , 
>> followed by 153.
>>
>> Otherwise
>>
>> Reviewed-by: Udit Kumar <u-kumar1@ti.com>
> 
> 
> Sorry, sent too fast, offset of 32 missing .
> 

 From what I’ve seen, the SPI interrupt IDs on J721S2 start from 0,
so I don’t think we need to subtract the 32 offset.


Interrupt Input Line   Interrupt ID    Source Interrupt
-------------------------------------------------------------
GIC500SS_SPI_IN_00     0               ESM0_ESM_INT_CFG_LVL_0

To confirm this, I’ve latched onto the correct interrupt line, and
my IRQ handler is getting triggered as expected. I’m also seeing the
desired output [0].

Let me know if I might be missing anything.

[0]: 
https://gist.github.com/Yemike-Abhilash-Chandra/f46587ec1ef72671ee31803dd93434b4

Thanks and Regards
Yemike Abhilash Chandra

> 
>>
>>> +            interrupt-names = "error_irq", "irq";
>>>               clocks = <&k3_clks 38 3>, <&k3_clks 38 1>, <&k3_clks 38 
>>> 3>,
>>>                   <&k3_clks 38 3>, <&k3_clks 38 4>, <&k3_clks 38 4>;
>>>               clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
>>> @@ -1301,6 +1304,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
>>>           cdns_csi2rx1: csi-bridge@4514000 {
>>>               compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>               reg = <0x00 0x04514000 0x00 0x1000>;
>>> +            interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
>>> +                     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
>>> +            interrupt-names = "error_irq", "irq";
>>>               clocks = <&k3_clks 39 3>, <&k3_clks 39 1>, <&k3_clks 39 
>>> 3>,
>>>                   <&k3_clks 39 3>, <&k3_clks 39 4>, <&k3_clks 39 4>;
>>>               clock-names = "sys_clk", "p_clk", "pixel_if0_clk",


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-07-22  5:50       ` Yemike Abhilash Chandra
@ 2025-07-25 10:46         ` Kumar, Udit
  2025-07-30 19:35         ` Jared McArthur
  1 sibling, 0 replies; 18+ messages in thread
From: Kumar, Udit @ 2025-07-25 10:46 UTC (permalink / raw)
  To: Yemike Abhilash Chandra, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel, u-kumar1


On 7/22/2025 11:20 AM, Yemike Abhilash Chandra wrote:
> Hi Udit,
>
> Thanks for the review.
>
> On 21/07/25 19:40, Kumar, Udit wrote:
>>
>> On 7/21/2025 7:37 PM, Kumar, Udit wrote:
>>>
>>> On 7/14/2025 2:57 PM, Yemike Abhilash Chandra wrote:
>>>> Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken 
>>>> from the
>>>> J721S2 TRM [0].
>>>>
>>>> Interrupt Line      | Source Interrupt
>>>> --------------------|----------------------------
>>>> GIC500SS_SPI_IN_153 | CSI_RX_IF1_CSI_ERR_IRQ_0
>>>> GIC500SS_SPI_IN_152 | CSI_RX_IF1_CSI_IRQ_0
>>>> GIC500SS_SPI_IN_157 | CSI_RX_IF2_CSI_ERR_IRQ_0
>>>> GIC500SS_SPI_IN_156 | CSI_RX_IF2_CSI_IRQ_0
>>>>
>>>> [0]: https://www.ti.com/lit/zip/spruj28
>>>>
>>>> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
>>>> ---
>>>>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 6 ++++++
>>>>   1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi 
>>>> b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> index 62f45377a2c9..6f32a2b0c40c 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>>>>           cdns_csi2rx0: csi-bridge@4504000 {
>>>>               compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>>               reg = <0x00 0x04504000 0x00 0x1000>;
>>>> +            interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>>>> +                     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>>>
>>> Just cosmetic thing, if you are doing v2 then consider 152 first , 
>>> followed by 153.
>>>
>>> Otherwise
>>>
>>> Reviewed-by: Udit Kumar <u-kumar1@ti.com>
>>
>>
>> Sorry, sent too fast, offset of 32 missing .
>>
>
> From what I’ve seen, the SPI interrupt IDs on J721S2 start from 0,
> so I don’t think we need to subtract the 32 offset.
>
>
> Interrupt Input Line   Interrupt ID    Source Interrupt
> -------------------------------------------------------------
> GIC500SS_SPI_IN_00     0               ESM0_ESM_INT_CFG_LVL_0
>
> To confirm this, I’ve latched onto the correct interrupt line, and
> my IRQ handler is getting triggered as expected. I’m also seeing the
> desired output [0].
>
> Let me know if I might be missing anything.
>

Thanks for update and please retain Reviewed-by


> [0]: 
> https://gist.github.com/Yemike-Abhilash-Chandra/f46587ec1ef72671ee31803dd93434b4
>
> Thanks and Regards
> Yemike Abhilash Chandra
>
>>
>>>
>>>> +            interrupt-names = "error_irq", "irq";
>>>>               clocks = <&k3_clks 38 3>, <&k3_clks 38 1>, <&k3_clks 
>>>> 38 3>,
>>>>                   <&k3_clks 38 3>, <&k3_clks 38 4>, <&k3_clks 38 4>;
>>>>               clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
>>>> @@ -1301,6 +1304,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
>>>>           cdns_csi2rx1: csi-bridge@4514000 {
>>>>               compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>>               reg = <0x00 0x04514000 0x00 0x1000>;
>>>> +            interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
>>>> +                     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
>>>> +            interrupt-names = "error_irq", "irq";
>>>>               clocks = <&k3_clks 39 3>, <&k3_clks 39 1>, <&k3_clks 
>>>> 39 3>,
>>>>                   <&k3_clks 39 3>, <&k3_clks 39 4>, <&k3_clks 39 4>;
>>>>               clock-names = "sys_clk", "p_clk", "pixel_if0_clk",


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property
  2025-07-22  5:50       ` Yemike Abhilash Chandra
  2025-07-25 10:46         ` Kumar, Udit
@ 2025-07-30 19:35         ` Jared McArthur
  1 sibling, 0 replies; 18+ messages in thread
From: Jared McArthur @ 2025-07-30 19:35 UTC (permalink / raw)
  To: Yemike Abhilash Chandra, Kumar, Udit, nm, vigneshr
  Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, linux-arm-kernel,
	devicetree, imx, linux-kernel

On 7/22/25 00:50, Yemike Abhilash Chandra wrote:
> Hi Udit,
> 
> Thanks for the review.
> 
> On 21/07/25 19:40, Kumar, Udit wrote:
>>
>> On 7/21/2025 7:37 PM, Kumar, Udit wrote:
>>>
>>> On 7/14/2025 2:57 PM, Yemike Abhilash Chandra wrote:
>>>> Add interrupts property for CDNS CSI2RX. Interrupt IDs are taken from the
>>>> J721S2 TRM [0].
>>>>
>>>> Interrupt Line      | Source Interrupt
>>>> --------------------|----------------------------
>>>> GIC500SS_SPI_IN_153 | CSI_RX_IF1_CSI_ERR_IRQ_0
>>>> GIC500SS_SPI_IN_152 | CSI_RX_IF1_CSI_IRQ_0
>>>> GIC500SS_SPI_IN_157 | CSI_RX_IF2_CSI_ERR_IRQ_0
>>>> GIC500SS_SPI_IN_156 | CSI_RX_IF2_CSI_IRQ_0
>>>>
>>>> [0]: https://www.ti.com/lit/zip/spruj28
>>>>
>>>> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
>>>> ---
>>>>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 6 ++++++
>>>>   1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> index 62f45377a2c9..6f32a2b0c40c 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>>>>           cdns_csi2rx0: csi-bridge@4504000 {
>>>>               compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>>               reg = <0x00 0x04504000 0x00 0x1000>;
>>>> +            interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>>>> +                     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>>>
>>> Just cosmetic thing, if you are doing v2 then consider 152 first , followed by 153.
>>>
>>> Otherwise
>>>
>>> Reviewed-by: Udit Kumar <u-kumar1@ti.com>
>>
>>
>> Sorry, sent too fast, offset of 32 missing .
>>
> 
> From what I’ve seen, the SPI interrupt IDs on J721S2 start from 0,
> so I don’t think we need to subtract the 32 offset.
> 
> 
> Interrupt Input Line   Interrupt ID    Source Interrupt
> -------------------------------------------------------------
> GIC500SS_SPI_IN_00     0               ESM0_ESM_INT_CFG_LVL_0
> 
> To confirm this, I’ve latched onto the correct interrupt line, and
> my IRQ handler is getting triggered as expected. I’m also seeing the
> desired output [0].
> 
> Let me know if I might be missing anything.
> 

The interrupt lines are correct (153, 152, 157, and 152), but when I
read the TRM (specifically the Appendix xls) [0], the lines'
definitions include the offset. Where are you looking for the line
name?

Interrupt Input Line                       | Source Interrupt
-------------------------------------------|-----------------------------
COMPUTE_CLUSTER0_CLEC_SOC_EVENTS_IN_IN_184 | CSI_RX_IF0_CSI_IRQ_OUT_0
COMPUTE_CLUSTER0_CLEC_SOC_EVENTS_IN_IN_185 | CSI_RX_IF0_CSI_ERR_IRQ_OUT_0
COMPUTE_CLUSTER0_CLEC_SOC_EVENTS_IN_IN_188 | CSI_RX_IF1_CSI_IRQ_OUT_0
COMPUTE_CLUSTER0_CLEC_SOC_EVENTS_IN_IN_189 | CSI_RX_IF1_CSI_ERR_IRQ_OUT_0

You may want to change your comment to reflect the TRM's appendix.

[0]: https://www.ti.com/lit/zip/spruj28

> [0]: https://gist.github.com/Yemike-Abhilash-Chandra/f46587ec1ef72671ee31803dd93434b4
> 
> Thanks and Regards
> Yemike Abhilash Chandra
> 
>>
>>>
>>>> +            interrupt-names = "error_irq", "irq";
>>>>               clocks = <&k3_clks 38 3>, <&k3_clks 38 1>, <&k3_clks 38 3>,
>>>>                   <&k3_clks 38 3>, <&k3_clks 38 4>, <&k3_clks 38 4>;
>>>>               clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
>>>> @@ -1301,6 +1304,9 @@ ti_csi2rx1: ticsi2rx@4510000 {
>>>>           cdns_csi2rx1: csi-bridge@4514000 {
>>>>               compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>>               reg = <0x00 0x04514000 0x00 0x1000>;
>>>> +            interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>,
>>>> +                     <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
>>>> +            interrupt-names = "error_irq", "irq";
>>>>               clocks = <&k3_clks 39 3>, <&k3_clks 39 1>, <&k3_clks 39 3>,
>>>>                   <&k3_clks 39 3>, <&k3_clks 39 4>, <&k3_clks 39 4>;
>>>>               clock-names = "sys_clk", "p_clk", "pixel_if0_clk",
> 

-- 
Best,
Jared McArthur


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2025-07-30 19:38 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-14  9:27 [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Yemike Abhilash Chandra
2025-07-14  9:27 ` [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property Yemike Abhilash Chandra
2025-07-21 14:07   ` Kumar, Udit
2025-07-21 14:09     ` Krzysztof Kozlowski
2025-07-21 14:12       ` Kumar, Udit
2025-07-21 14:22         ` Krzysztof Kozlowski
2025-07-21 14:10     ` Kumar, Udit
2025-07-22  5:50       ` Yemike Abhilash Chandra
2025-07-25 10:46         ` Kumar, Udit
2025-07-30 19:35         ` Jared McArthur
2025-07-14  9:27 ` [PATCH 2/7] arm64: dts: ti: k3-j721e-main: " Yemike Abhilash Chandra
2025-07-14  9:27 ` [PATCH 3/7] arm64: dts: ti: k3-j784s4-j742s2-main-common: " Yemike Abhilash Chandra
2025-07-14  9:27 ` [PATCH 4/7] arm64: dts: ti: k3-am62p-j722s-common-main: " Yemike Abhilash Chandra
2025-07-14  9:27 ` [PATCH 5/7] arm64: dts: ti: k3-j722s-main: " Yemike Abhilash Chandra
2025-07-14  9:27 ` [PATCH 6/7] arm64: dts: ti: k3-am62-main: " Yemike Abhilash Chandra
2025-07-14  9:27 ` [PATCH 7/7] arm64: dts: ti: k3-am62a-main: " Yemike Abhilash Chandra
2025-07-14 15:24 ` [PATCH 0/7] Add Interrupts property for CDNS CSI2RX Rob Herring (Arm)
2025-07-17 20:45 ` Jared McArthur

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).