From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18E44C4338F for ; Fri, 23 Jul 2021 17:41:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF7DD60E0C for ; Fri, 23 Jul 2021 17:41:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF7DD60E0C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vXDhkJsCE0aubcCwrQqEJIBkwQYCEOB3gGCd9nOTiF8=; b=Zot35wkId4c9Kh4bpnoBHRRso9 wmuwYDWLLS0AK2vv17lHtxlECnrlYzAlvVJitHoPAil48V8dSuL5CcVpTXe8vRiSjnjhgEh+f4ZzR q/14gkz9w3rXZzzzYAgQqkyAxZ2CNjE0NLkRKUhM6r+MOWspZx7tQrsFJiy9AT6HbCMgNB4r0+WEs GZeWATu4UgrWc0C2uZmv7w+y0pFQ7z+O4mOpHxRIOBBNii7OASGbRbuKFfng0SYh3JK1odPooCv8k HszIULZoddZSUTjPBVnM+DH2Uxh4cyqq4n7Y9VwNkSvhXkhM06oFeZf07DSTJLsei3aTnjZLZCzbS D5Khb7Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6z9T-005UJj-9I; Fri, 23 Jul 2021 17:39:59 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6z9H-005UJ3-6f for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 17:39:48 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id A6AB980FBE; Fri, 23 Jul 2021 19:39:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1627061981; bh=JtZAR1o8JFZlRwkemSDuytk+JAAjL1uHIjtJrsXiBB0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=nST7TZLp39n0WFhvIvX0LQTEiIeHk9O87K7aQkNpBuf7ruFMuGSoNOipVC7gRw+fu FmR1BnZBZlEihjrGoCnaOYnPQVTtRRHDSsW/cXcsUo0c2PvCMCbbYW/RKNiBfP7RoJ vWkukt79+0zzCRW/lVlMUcUBqU1ngQaYJVM1x8Kl/13pwb/7r+paAre++uCJH5Xq2I +CDhLb1d6eJ8JkcZmBrUlhjoUL9gsPqpAtdn9yzQNDh8N1jCW+Wl3e1QdNKbfVab5g f/ans7gEl+T+oPO5Zt7xOJqecMzfI2QNqRAkb1O8RWiPWOeG+jXAcA10P8dbleAmbu nHflABOf10SqA== Subject: Re: [PATCH] ARM: dts: stm32: Fix touchscreen IRQ line assignment on DHCOM To: Alexandre TORGUE , linux-arm-kernel@lists.infradead.org Cc: cniedermaier@dh-electronics.com, Patrice Chotard , Patrick Delaunay , linux-stm32@st-md-mailman.stormreply.com References: <20210721181040.126714-1-marex@denx.de> From: Marek Vasut Message-ID: Date: Fri, 23 Jul 2021 19:39:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210723_103947_497332_546B1599 X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/23/21 5:18 PM, Alexandre TORGUE wrote: > Hi Marek > > On 7/21/21 8:10 PM, Marek Vasut wrote: >> While 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM PDK2") >> fixed the LED0 assignment on the PDK2 board, the same commit did not >> update the touchscreen IRQ line assignment, which is the same GPIO line, >> shared between the LED0 output and touchscreen IRQ input. To make this >> more convoluted, the same EXTI input (not the same GPIO line) is shared >> between Button B which is Active-Low IRQ, and touchscreen IRQ which is >> Edge-Falling IRQ, which cannot be used at the same time. In case the LCD >> board with touchscreen is in use, which is the case here, LED0 must be >> disabled, Button B must be polled, so the touchscreen interrupt works as >> it should. >> >> Update the touchscreen IRQ line assignment, disable LED0 and use polled >> GPIO button driver for Button B, since the DT here describes baseboard >> with LCD board. >> >> Fixes: 7e5f3155dcbb4 ("ARM: dts: stm32: Fix LED5 on STM32MP1 DHCOM PDK2") >> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM >> STM32MP1 SoM and PDK2 board") > > I think you need to keep only one fixes tag. Then it is the first one (LED5) if you want to pick it, or shall I resend it ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel