From: Shawn Lin <shawn.lin@rock-chips.com>
To: joachim.eastwood@gmail.com, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: shawn.lin@rock-chips.com,
Diederik de Haas <diederik@cknow-tech.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 5/9] arm64: dts: rockchip: rk3588s-nanopi: rename sd power pin
Date: Thu, 15 Oct 2026 10:32:35 +0800 [thread overview]
Message-ID: <d18f064d-ea3f-45f5-bc86-9318b01f2c92@rock-chips.com> (raw)
In-Reply-To: <20261014-nanopi-m6-improvements-v1-5-e713f71eb4d3@gmail.com>
在 2026/10/15 星期四 0:33, Joachim Eastwood via B4 Relay 写道:
> From: Joachim Eastwood <joachim.eastwood@gmail.com>
>
> sdmmc_pwren matches the signal name in the schematics, which simplifies
> cross-referencing.
>
Reviewed-by: Shawn Lin <Shawn.lin@rock-chips.com>
> Signed-off-by: Joachim Eastwood <joachim.eastwood@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi
> index a99e2e60c5f7..1d37862edb5b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi.dtsi
> @@ -66,7 +66,7 @@ vcc_3v3_sd_s0: regulator-vcc-3v3-sd-s0 {
> enable-active-high;
> gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>;
> pinctrl-names = "default";
> - pinctrl-0 = <&sd_s0_pwr>;
> + pinctrl-0 = <&sdmmc_pwren>;
> regulator-name = "vcc_3v3_sd_s0";
> regulator-boot-on;
> regulator-max-microvolt = <3300000>;
> @@ -334,7 +334,7 @@ sdmmc_det_pin: sdmmc-det-pin {
> rockchip,pins = <0 RK_PA4 RK_FUNC_GPIO &pcfg_pull_up>;
> };
>
> - sd_s0_pwr: sd-s0-pwr {
> + sdmmc_pwren: sdmmc-pwren {
> rockchip,pins = <4 RK_PB4 RK_FUNC_GPIO &pcfg_pull_up>;
> };
> };
>
next prev parent reply other threads:[~2026-10-15 2:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 16:33 [PATCH 0/9] arm64: dts: rockchip: NanoPi 6 series fixes and improvements Joachim Eastwood via B4 Relay
2026-10-14 16:33 ` [PATCH 1/9] arm64: dts: rockchip: rk3588s-nanopi: fix sd min/max voltage Joachim Eastwood via B4 Relay
2026-10-15 2:26 ` Shawn Lin
2026-10-14 16:33 ` [PATCH 2/9] arm64: dts: rockchip: rk3588s-nanopi: enable mmc-hs400 and add supplies Joachim Eastwood via B4 Relay
2026-10-15 2:27 ` Shawn Lin
2026-10-14 16:33 ` [PATCH 3/9] arm64: dts: rockchip: rk3588s-nanopi: add voltage iio-hwmon device Joachim Eastwood via B4 Relay
2026-10-14 16:33 ` [PATCH 4/9] arm64: dts: rockchip: rk3588s-nanopi: move vcc_3v3_s0 to nanopi-r6 Joachim Eastwood via B4 Relay
2026-10-14 16:33 ` [PATCH 5/9] arm64: dts: rockchip: rk3588s-nanopi: rename sd power pin Joachim Eastwood via B4 Relay
2026-10-15 2:32 ` Shawn Lin [this message]
2026-10-14 16:33 ` [PATCH 6/9] arm64: dts: rockchip: rk3588s-nanopi: rename usb host " Joachim Eastwood via B4 Relay
2026-10-14 16:33 ` [PATCH 7/9] arm64: dts: rockchip: rk3588s-nanopi: rename gmac1 reset pin Joachim Eastwood via B4 Relay
2026-10-14 16:33 ` [PATCH 8/9] arm64: dts: rockchip: rk3588s-nanopi-m6: rename pcie2 power pin Joachim Eastwood via B4 Relay
2026-10-15 2:33 ` Shawn Lin
2026-10-14 16:33 ` [PATCH 9/9] arm64: dts: rockchip: rk3588s-nanopi-m6: rename pcie2 power rail Joachim Eastwood via B4 Relay
2026-10-15 2:34 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d18f064d-ea3f-45f5-bc86-9318b01f2c92@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=diederik@cknow-tech.com \
--cc=heiko@sntech.de \
--cc=joachim.eastwood@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox