From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38243C001DB for ; Tue, 8 Aug 2023 13:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dOUuwEeJ3/qK2m8S0yY7xfg+cuVxWFADLV84S3D4zIA=; b=XmJktGrWe+H3QC VvrH3a44qTLWlXHBYY8GieP2SDAcl6yKPyuOKyYHciCf8926AIjtyevwhKgoIPZhj4Hry9u2mKgNc aQYgKfmW25qM0YdEYTnPHTctBWfhgn8gkaQpD1Vf2ocksclXnnA/KrPwiCYtceOUiSpzW9Un8RDcQ cv9Vt+CgSgBvRH6pb9ziVCS6rI6JpIXDSVX0GbXMjEGRUVsI3l8u0LO2WLkuGotwg1KGSfBRtwHpc /9/iaAvDRIoTwVlDmB0+g8VWb/pBGQi9uQtnMakBe2/wCmJN7g1B4PcFGBIea6biLK83yt2lxL54N ZLFASL+njoG6HDuYCk3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTMoE-002eNX-01; Tue, 08 Aug 2023 13:31:38 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTMoA-002eLq-1w for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 13:31:36 +0000 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2ba0f27a4c2so84576381fa.2 for ; Tue, 08 Aug 2023 06:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691501487; x=1692106287; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rh7yiDqz5JOnOPNrSWe6RNtd/mULecCxFtp8KEyVNnw=; b=rSZwNL5nkaEONtvOiCo7kHjGrZWT4u8L961WSHoIYAdCRplKcrQb3S25QKzq1yhEIF BT/GExj3H0yxzir1R6Q4N2F6OY2LsP4weVTmLZem28G6mpdk5Wm3gbeeRynbkPqXS5Uz CDcZKyAoTbR6blxh1qBx293sD/uRurw0y6SlvnGg0Lbq68lDhiXWpMMwz37l7/R1Tkro 0Ip+HnDTTumDmxX9l33HjWaqipnmEsfDmE5IisrIG0vsgkimlAUt7nbQ0G/xU8z7Nd+d vaaEa4ryAslzEurxc9+E8PuIeav2T8AROsPJ/PxjO6FOTYmtSYjCWrnZvvsa/b4O90vQ HdMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691501487; x=1692106287; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rh7yiDqz5JOnOPNrSWe6RNtd/mULecCxFtp8KEyVNnw=; b=McOs9nAASjd6OuFhB437z3KSg45BGDtakv6e/8nJQ98dYn2wW/YrsI5wZaok3C8caV iF4H9MK6RjHQ0tw0a3NcFYOu1fUcuMgMDNjZJ1Y291CCPjn4DrYw11PtV811eOIdA25T g2+iobYRH6j7aU+GASNucXBN7+ws6M7YsgvQuvBF/XJXU0684mrRh9e3GIH4hsFGqRA5 RD+XpZJPKSDlA9EKxJ+lwK1ZwAWwVmVMbv94rZoC3XM82FRLjpJ85NLLwziE1VctB3nD stXd3+lr4M26kdECLulN6j9yGkIXeK1oVZDZpGzdE+0nGrDXFWBUKlXNZadTq4R13DIA QHGw== X-Gm-Message-State: AOJu0Yyh6b/IaYQkv9yEgxblOPdmoddCeYyXmlnjPWPFXe+gVjnoEhK9 CWBvzH0h+Lt9EwinU9sH5EFZBg== X-Google-Smtp-Source: AGHT+IEbOCg9xyA18ITMblbIWlyzPFYOlii2hEzw3GovA2rrE4kb5tpZlfY7zxAoe7VitoQW3rEUTg== X-Received: by 2002:a2e:914b:0:b0:2b9:4476:ab28 with SMTP id q11-20020a2e914b000000b002b94476ab28mr9271044ljg.38.1691501487657; Tue, 08 Aug 2023 06:31:27 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id l26-20020a1c791a000000b003fe4548188bsm13716497wme.48.2023.08.08.06.31.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 06:31:27 -0700 (PDT) Message-ID: Date: Tue, 8 Aug 2023 15:31:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 3/3] media: exynos4-is: fimc-is: replace duplicate pmu node with phandle Content-Language: en-US To: Andi Shyti Cc: Sylwester Nawrocki , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230807131256.254243-1-krzysztof.kozlowski@linaro.org> <20230807131256.254243-3-krzysztof.kozlowski@linaro.org> <20230807231320.svssge6uymw3jiho@intel.intel> <84fbcc37-d226-b637-caa1-b24ebaf03d58@linaro.org> <20230808114201.ztr22migzzyfsfwq@intel.intel> From: Krzysztof Kozlowski In-Reply-To: <20230808114201.ztr22migzzyfsfwq@intel.intel> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_063134_637991_3A79D7B5 X-CRM114-Status: GOOD ( 19.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 13:42, Andi Shyti wrote: >>>> +static void __iomem *fimc_is_get_pmu_regs(struct device *dev) >>>> +{ >>>> + struct device_node *node; >>>> + void __iomem *regs; >>>> + >>>> + node = of_parse_phandle(dev->of_node, "samsung,pmu-syscon", 0); >>>> + if (!node) { >>>> + dev_warn(dev, "Finding PMU node via deprecated method, update your DTB\n"); >>>> + node = of_get_child_by_name(dev->of_node, "pmu"); >>>> + if (!node) >>>> + return IOMEM_ERR_PTR(-ENODEV); >>> >>> in my opinion this should be: >>> >>> ... >>> if (!node) >>> return IOMEM_ERR_PTR(-ENODEV); >>> >>> dev_warn(dev, "Finding PMU node via deprecated method, update your DTB\n"); >>> >>> Because if you don't have both "samsung,pmu-syscon and "pmu" then >>> the warning should not be printed and you need to return -ENODEV. >> >> Why not? Warning is correct - the driver is trying to find, thus >> continuous tense "Finding", PMU node via old method. > > Alright, I'll go along with what you're suggesting, but I have to > say, I find it misleading. > > From what I understand, you're requesting an update to the dtb > because it's using deprecated methods. However, the reality might > be that the node is not present in any method at all. > > Your statement would be accurate if you failed to find the > previous method but then did end up finding it. > > Relying on the present continuous tense for clarity is a bold > move, don't you think? :) I just don't think it matters and is not worth resending. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel