Re: [PATCH v2 5/5] coresight-tnoc: add nodes to configure freq packet

Krzysztof Kozlowski
2025-02-26T13:25:07Z

On 26/02/2025 12:05, Yuanfang Zhang wrote:
> Three nodes for freq packet config are added here:
>
> 1. freq_type: used to set the type of issued ATB FREQ packets.
> 0: 'FREQ' packets; 1: 'FREQ_TS' packets.
>
> 2. freq_req_val: used to set frequency values carried by 'FREQ'
> and 'FREQ_TS' packets.
>
> 3. freq_ts_req: writing '1' to issue a 'FREQ' or 'FREQ_TS' packet.
>
> Signed-off-by: Yuanfang Zhang <quic_yuanfang@quicinc.com>
> ---
> drivers/hwtracing/coresight/coresight-tnoc.c | 97 ++++++++++++++++++++++++++++
> 1 file changed, 97 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tnoc.c b/drivers/hwtracing/coresight/coresight-tnoc.c
> index ad973749250644760adc4dfd855240026d0a744c..24b1add4c921866b944d756e563d50b4172d583a 100644
> --- a/drivers/hwtracing/coresight/coresight-tnoc.c
> +++ b/drivers/hwtracing/coresight/coresight-tnoc.c
> @@ -112,10 +112,107 @@ static ssize_t flag_type_show(struct device *dev,
> }
> static DEVICE_ATTR_RW(flag_type);
>
> +static ssize_t freq_type_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + struct trace_noc_drvdata *drvdata = dev_get_drvdata(dev->parent);
> +
> + return sysfs_emit(buf, "%u\n", drvdata->freq_type);
> +}
> +
> +static ssize_t freq_type_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf,
> + size_t size)

No improvements. You got here comments and you got also later my
complain that yo missed comments already.

You keep ignoring received feedback and that's a no go for me.

Maybe process needs to be improved, so reach to your colleagues and
learn how to interact with upstream. There is very comprehensive
internal guideline in Qualcomm, so follow it carefully.

I expect still to respond to my original comment or implement it fully.

Best regards,
Krzysztof