From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 926EAFA373D for ; Fri, 21 Oct 2022 17:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pt3Fe+Z2X+tWCzLeqjnWSfr4oE/UhmnQ1PXKIInG/q4=; b=YqQrvmkgWx23M8evAdMDth6CTS RKlp8yUmcUhVAEGjPzj433YAcwc6Ngw90bmfc9Y8MEbMA7dR/QeujnIhfgtSW2KlVJgm06pFDEks6 F7/W/U2UtpriT0sb0wEzA/xFUImZ19Wp7LGmeB/bCQxC+yYimViPfYRX92vNvJe5Iezk8Jiu0OU/d HgxVAfYb1ZG9GRoulWVP1SJNoNmmRtloX64UQ/1q0cd59+3Jw4THPs2k8D1YrVwgsrxSXtG2x5E/a sIQWL4/iqN+C4CQsa5fNLT/iijEbmomhsB+HFf17Mg2P7hbSXYGUwffsFIF0bKWbzU8sZUx1vEf76 IiUptcSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olvfn-0099Xx-Q7; Fri, 21 Oct 2022 17:19:07 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olvfl-0099WB-1A; Fri, 21 Oct 2022 17:19:06 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id BD5431884D31; Fri, 21 Oct 2022 17:18:59 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 7E0FF250007B; Fri, 21 Oct 2022 17:18:59 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 7497A9EC0007; Fri, 21 Oct 2022 17:18:59 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Fri, 21 Oct 2022 19:18:59 +0200 From: netdev@kapio-technology.com To: Vladimir Oltean Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Ido Schimmel , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 net-next 10/12] net: dsa: mv88e6xxx: mac-auth/MAB implementation In-Reply-To: <20221021163005.xljk2j3fkikr6uge@skbuf> References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221018165619.134535-11-netdev@kapio-technology.com> <20221020132538.reirrskemcjwih2m@skbuf> <2565c09bb95d69142522c3c3bcaa599e@kapio-technology.com> <20221020225719.l5iw6vndmm7gvjo3@skbuf> <82d23b100b8d2c9e4647b8a134d5cbbf@kapio-technology.com> <20221021112216.6bw6sjrieh2znlti@skbuf> <7bfaae46b1913fe81654a4cd257d98b1@kapio-technology.com> <20221021163005.xljk2j3fkikr6uge@skbuf> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_101905_244261_2F79350F X-CRM114-Status: GOOD ( 20.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-10-21 18:30, Vladimir Oltean wrote: > On Fri, Oct 21, 2022 at 03:16:21PM +0200, netdev@kapio-technology.com > wrote: >> As it is now in the bridge, the locked port part is handled before >> learning >> in the ingress data path, so with BR_LEARNING and BR_PORT_LOCKED, I >> think it >> will work as it does now except link local packages. > > If link-local learning is enabled on a locked port, I think those > addresses should also be learned with the BR_FDB_LOCKED flag. The > creation of those locked FDB entries can be further suppressed by the > BROPT_NO_LL_LEARN flag. > >> If your suggestion of BR_LEARNING causing BR_FDB_LOCKED on a locked >> port, I >> guess it would be implemented under br_fdb_update() and BR_LEARNING + >> BR_PORT_LOCKED would go together, forcing BR_LEARNING in this case, >> thus also >> for all drivers? > > Yes, basically where this is placed right now (in > br_handle_frame_finish): > > if (p->flags & BR_PORT_LOCKED) { > struct net_bridge_fdb_entry *fdb_src = > br_fdb_find_rcu(br, eth_hdr(skb)->h_source, vid); > > if (!fdb_src) { > unsigned long flags = 0; > > if (p->flags & BR_PORT_MAB) { > ~~~~~~~~~~~~~~~~~~~~~~~~ > except check for BR_LEARNING > > __set_bit(BR_FDB_LOCKED, &flags); > br_fdb_update(br, p, eth_hdr(skb)->h_source, > vid, flags); > } > goto drop; > } else if (READ_ONCE(fdb_src->dst) != p || > test_bit(BR_FDB_LOCAL, &fdb_src->flags) || > test_bit(BR_FDB_LOCKED, &fdb_src->flags)) { > goto drop; > } > } As I don't know what implications it would have for other drivers to have learning forced enabled on locked ports, I cannot say if it is a good idea or not. Right now learning is not forced either way as is, but the consensus is that learning should be off with locked ports, which it would be either way in the common case I think. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel