public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: Fabio Estevam <festevam@gmail.com>, shawnguo@kernel.org
Cc: LW@KARO-electronics.de, linux-arm-kernel@lists.infradead.org,
	Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] ARM: dts: imx28-tx28: Pass #sound-dai-cells
Date: Tue, 5 Dec 2023 19:32:00 +0100	[thread overview]
Message-ID: <d2029304-ec7e-4679-aecf-bdeedcd88242@gmx.net> (raw)
In-Reply-To: <20231205145335.2055549-1-festevam@gmail.com>

Hi Fabio,

Am 05.12.23 um 15:53 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> Per sgtl5000.yaml, '#sound-dai-cells' is a required property.
>
> Pass it to fix the following dt-schema warning:
>
> imx28-tx28.dtb: sgtl5000@a: '#sound-dai-cells' is a required property
> 	from schema $id: http://devicetree.org/schemas/sound/sgtl5000.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>   arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts b/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
> index 153e4017951d..5485fe118dc4 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
> @@ -260,6 +260,7 @@ &i2c0 {
>   	sgtl5000: sgtl5000@a {
this patch is fine

Reviewed-by: Stefan Wahren <wahrenst@gmx.net>

but this node name looks wrong.

It should be sgtl5000: codec@a

Regards
>   		compatible = "fsl,sgtl5000";
>   		reg = <0x0a>;
> +		#sound-dai-cells = <0>;
>   		VDDA-supply = <&reg_2p5v>;
>   		VDDIO-supply = <&reg_3p3v>;
>   		clocks = <&mclk>;


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-12-05 18:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-05 14:53 [PATCH] ARM: dts: imx28-tx28: Pass #sound-dai-cells Fabio Estevam
2023-12-05 18:32 ` Stefan Wahren [this message]
2023-12-05 21:26   ` Fabio Estevam
2023-12-06  3:18 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2029304-ec7e-4679-aecf-bdeedcd88242@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=LW@KARO-electronics.de \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox