From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Chanho Park <chanho61.park@samsung.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Bart Van Assche <bvanassche@acm.org>
Cc: linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] ufs: ufs-exynos: change ufs phy control sequence
Date: Tue, 5 Jul 2022 11:36:07 +0200 [thread overview]
Message-ID: <d23604f8-f6b3-0f2f-6ab0-418a6fb9549f@linaro.org> (raw)
In-Reply-To: <20220705065440.117864-4-chanho61.park@samsung.com>
On 05/07/2022 08:54, Chanho Park wrote:
> Since commit 1599069a62c6 ("phy: core: Warn when phy_power_on is called
> before phy_init"), below warning has been reported.
>
> phy_power_on was called before phy_init
>
> To address this, we need to remove phy_power_on from
> exynos_ufs_phy_init and move it after phy_init. phy_power_off and
> phy_exit are also necessary in exynos_ufs_remove.
>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> ---
> drivers/ufs/host/ufs-exynos.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
> index f971569bafc7..5718296e2521 100644
> --- a/drivers/ufs/host/ufs-exynos.c
> +++ b/drivers/ufs/host/ufs-exynos.c
> @@ -908,6 +908,8 @@ static int exynos_ufs_phy_init(struct exynos_ufs *ufs)
> goto out_exit_phy;
> }
>
> + phy_power_on(generic_phy);
What about phy_power_on() return code?
> +
> return 0;
>
> out_exit_phy:
> @@ -1169,10 +1171,6 @@ static int exynos_ufs_init(struct ufs_hba *hba)
> goto out;
> }
>
> - ret = phy_power_on(ufs->phy);
> - if (ret)
> - goto phy_off;
> -
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-05 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220705065722epcas2p3fad39b3edf1a0fd1789de77997bf5728@epcas2p3.samsung.com>
2022-07-05 6:54 ` [PATCH 0/3] change exynos ufs phy control Chanho Park
[not found] ` <CGME20220705065722epcas2p2973795cc88ee436480abcb48435059a8@epcas2p2.samsung.com>
2022-07-05 6:54 ` [PATCH 1/3] phy: samsung-ufs: convert phy clk usage to clk_bulk API Chanho Park
2022-07-05 9:30 ` Krzysztof Kozlowski
[not found] ` <CGME20220705065722epcas2p1e93a8511b906d5e111bff48a312d0603@epcas2p1.samsung.com>
2022-07-05 6:54 ` [PATCH 2/3] phy: samsung-ufs: ufs: change phy on/off control Chanho Park
2022-07-05 9:33 ` Krzysztof Kozlowski
[not found] ` <CGME20220705065722epcas2p3f9970697f6d1f1fed43e10fe17019619@epcas2p3.samsung.com>
2022-07-05 6:54 ` [PATCH 3/3] ufs: ufs-exynos: change ufs phy control sequence Chanho Park
2022-07-05 9:36 ` Krzysztof Kozlowski [this message]
2022-07-06 1:51 ` Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d23604f8-f6b3-0f2f-6ab0-418a6fb9549f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=bvanassche@acm.org \
--cc=chanho61.park@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).