From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9DD9C43334 for ; Tue, 5 Jul 2022 09:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GgU9nv9UV/BMNWe2OqmKnTYO0Z2NAR/vKLQptWB/3jQ=; b=Fxp+xBiTL1LoRc zxGURrLivzKp2f0JdJSI8tDjDC5IsMd/h5oMct9OUMz7gtyWR+k9hwy27tmnhPiCdokmiN2vteLj5 hRTaRMVWrl0G74Uaiw/qfGK1/o+Km5LOWRIDlkdp1xG8Lh5jmGw9oM0+M17Xn1vai90ForNdCoXAh pJublqQd+gRJfVal5aH4b6fOPJPnduhLFSmQnO5krTTxkgY0FMH6Mct4etmzAz2F5Ukbn50OAm1xn gF8SiLCJIxxTyFNY6w9Gwy0D7CUa+byYX+U3pwoiUe7ADhy+R1sKRZ6zEMu9crnDFkQR5LGcsB6ag MY0reWY2fVeMIXGL/8cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8f25-00Go9D-A1; Tue, 05 Jul 2022 09:39:50 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8eyb-00Gm0b-I0 for linux-arm-kernel@lists.infradead.org; Tue, 05 Jul 2022 09:36:14 +0000 Received: by mail-lf1-x12d.google.com with SMTP id y16so19540831lfb.9 for ; Tue, 05 Jul 2022 02:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=DVpNA/tLD/wvwSxUeEUrSF+gBAXB9p0G4i2gTUY7urk=; b=Kl1wLaVX0l0SkIKLe+s6DLVY5Wie08GC35B2K0NpcRRIxKdH7fbwvzcZGq/3TB49so 9npPluaHmv29OPp44rcZGSxxc8azqw8MgTbBi5FboSN0yNOf7aTzhkA4q6Tgo+p/D+fB alij7kkxVwVDnunV6i/5yTjIAXHUc/47g8NznZFe4jIkGcnmH/lOEPcbdYhfmsFZb5An 83b67neobRFsT0lCpQ+Rp6dBbhsn1QvjBDKyA2alZq3LS2NhfAWCRnUF7hUiGgns5CD/ 3tqtYEZApRjUoPveGsXsoHYRjEfvmGf022D1FOkzeNGfXSzybQ6HRM/Ef4NElQ+4MONC 67dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=DVpNA/tLD/wvwSxUeEUrSF+gBAXB9p0G4i2gTUY7urk=; b=ksQeySHd5X7h7pEbkuKPr7YYSxbMV96hZCjkpJur6p9ykGrq/djXY46Yoe9pCWYNwh 0+pz8XREHrKD16LX6zrRoORT+INKkimkcHIV1fMHo//sTC9c4xSCFcQAI2rn2tj2X5+y KtaAKahlB1nsBWN92p7Nceja1tHVAw/xjFHUlbuyPsRqRAWfU39OiyH8fsf/BkCPhRYZ 0HQDOTFSSUWn4BAT8J4LgZPtG6kl5DbauQnlFjrF3sKfj2L/tnXgg5J5oCmq/vZv4AWA ddxK0owNp1j/ycPrx+Nrgdh9tge0JrgYsi460hoN1BAxDxki1H0dKHwsf35RCMdJpMZc /4KA== X-Gm-Message-State: AJIora/DVeVXVgttRiRiNDimA9Ipb0cC4Lt5expQ9bZnrVcHTHeU9h/q tNwq8a4NZmPTKplHLM/t7fKBkw== X-Google-Smtp-Source: AGRyM1sYGyEqkaCnXtTCeKFV77xk0RouTj+keeHZY5v3cr5MdA2/69gP8t4dwAwlMR1FESY1AQydhA== X-Received: by 2002:a05:6512:32c1:b0:47f:9d05:b6be with SMTP id f1-20020a05651232c100b0047f9d05b6bemr21155038lfg.335.1657013769673; Tue, 05 Jul 2022 02:36:09 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id q14-20020a056512210e00b0048389c88ba6sm249336lfr.40.2022.07.05.02.36.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 02:36:09 -0700 (PDT) Message-ID: Date: Tue, 5 Jul 2022 11:36:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/3] ufs: ufs-exynos: change ufs phy control sequence Content-Language: en-US To: Chanho Park , Kishon Vijay Abraham I , Vinod Koul , "James E . J . Bottomley" , "Martin K . Petersen" , Alim Akhtar , Bart Van Assche Cc: linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20220705065440.117864-1-chanho61.park@samsung.com> <20220705065440.117864-4-chanho61.park@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220705065440.117864-4-chanho61.park@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_023613_636205_D7EF017B X-CRM114-Status: GOOD ( 18.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/07/2022 08:54, Chanho Park wrote: > Since commit 1599069a62c6 ("phy: core: Warn when phy_power_on is called > before phy_init"), below warning has been reported. > > phy_power_on was called before phy_init > > To address this, we need to remove phy_power_on from > exynos_ufs_phy_init and move it after phy_init. phy_power_off and > phy_exit are also necessary in exynos_ufs_remove. > > Signed-off-by: Chanho Park > --- > drivers/ufs/host/ufs-exynos.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c > index f971569bafc7..5718296e2521 100644 > --- a/drivers/ufs/host/ufs-exynos.c > +++ b/drivers/ufs/host/ufs-exynos.c > @@ -908,6 +908,8 @@ static int exynos_ufs_phy_init(struct exynos_ufs *ufs) > goto out_exit_phy; > } > > + phy_power_on(generic_phy); What about phy_power_on() return code? > + > return 0; > > out_exit_phy: > @@ -1169,10 +1171,6 @@ static int exynos_ufs_init(struct ufs_hba *hba) > goto out; > } > > - ret = phy_power_on(ufs->phy); > - if (ret) > - goto phy_off; > - Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel