From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83E20CD5BAE for ; Thu, 5 Sep 2024 12:14:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eHw8WE1mdh1dti/dULV4/AdNqe7DLVemRtY541mNzTc=; b=3rDAD/Mty1/nCtusTjA4kQIZe8 qiEcsRG9yPGoL15AUGFDEIAXqhriO2iDKeYShPwO/5oSHt9vQUCOKFcOVqXcOB04yUIDbpDOtbPt0 msJ1S7Vs6jn5CN2pJs/QjOG1WQuSmsW8vkd7D4ie+0PZ98g88+skKEtBvPiYh1w3ZGhxfeR2NwgmY XifD2EepXlwOVw7UcrsdyG7LB1a60Dxet1k+0n7IeW2n9yTtBWNBda0ib42OAHg6QOvfku5/SXcMc nmPfGRM7GcWm+/4QTy4uwZfxl6MNXg4yUgxIM2PjFHPkSOtzgm4TYEHgOctn7PNZaAncbyK2dz1VL o2AOGHdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smBNe-00000008GBb-2ulc; Thu, 05 Sep 2024 12:14:30 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smBMg-00000008FyV-0UKR for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2024 12:13:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C58A2A44B00; Thu, 5 Sep 2024 12:13:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 250B5C4CEC3; Thu, 5 Sep 2024 12:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725538408; bh=xmP/wJyeYT7M4VQxSWmO3MapekYf8Jd7YMh+Yp8oi9Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HGU1lkB8L/fBqhoxiNHHuN2Yw6FzeKDCo3zUwJynw7j8LRqn+FIjU+TO0L+SgjBcX +Xk0vPjb3EEQ9WP33thlPq1DNEu99bdIcBzSe44WE6arNQBvRHX1LyUX9QoZ9yBYs6 23Ce7qXQlPiIo0xmf7ls2lVZ8cVYK1GLmLtc0O0wey9GBVgfJmsdwWmjoYAYc01YIC nStZLcM1N1jaQnXLcMsllBtyJcqyKV1VO8v5CaarS9Vihf2Ccz2rYKI9VDtYj4+24Z lAxQ+ZLUfa9eYmsSvvVlSt/iXH9A3Q6l7qrpxL4MrZT4qLGrepYwjJPjOd+XtRNkKb VAoaSytYBwqqw== Message-ID: Date: Thu, 5 Sep 2024 14:13:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/10] media: qcom: camss: Fix potential crash if domain attach fails To: Vikram Sharma , Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kapatrala Syed , Hariram Purushothaman , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , cros-qcom-dts-watchers@chromium.org, Catalin Marinas , Will Deacon Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org References: <20240904-camss_on_sc7280_rb3gen2_vision_v2_patches-v1-0-b18ddcd7d9df@quicinc.com> <20240904-camss_on_sc7280_rb3gen2_vision_v2_patches-v1-3-b18ddcd7d9df@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240904-camss_on_sc7280_rb3gen2_vision_v2_patches-v1-3-b18ddcd7d9df@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_051330_255544_2C1D7974 X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4.09.2024 1:10 PM, Vikram Sharma wrote: > Fix a potential crash in camss by ensuring detach is skipped if attach > is unsuccessful. > > Fixes: d89751c61279 ("media: qcom: camss: Add support for named power-domains") > CC: stable@vger.kernel.org > Signed-off-by: Vikram Sharma > --- > drivers/media/platform/qcom/camss/camss.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index d64985ca6e88..447b89d07e8a 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -2132,7 +2132,7 @@ static int camss_configure_pd(struct camss *camss) > camss->res->pd_name); > if (IS_ERR(camss->genpd)) { > ret = PTR_ERR(camss->genpd); > - goto fail_pm; > + goto fail_pm_attach; > } > } > > @@ -2149,7 +2149,7 @@ static int camss_configure_pd(struct camss *camss) > ret = -ENODEV; > else > ret = PTR_ERR(camss->genpd); > - goto fail_pm; > + goto fail_pm_attach; > } > camss->genpd_link = device_link_add(camss->dev, camss->genpd, > DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME | > @@ -2164,6 +2164,7 @@ static int camss_configure_pd(struct camss *camss) > fail_pm: > dev_pm_domain_detach(camss->genpd, true); > > +fail_pm_attach: > return ret; What's the point, just call return directly where you added the goto Konrad