From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98971C83F2D for ; Thu, 29 Aug 2024 15:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BruaygEdXCnQYW8tbQ1OgV9ZuFw/62wvKJTlu2vfTEA=; b=ZI6bPQPEwrzxHB2J1fauwiEdaq nZlhtqa4nxHtiBOO57d1yamEqdxPIoc5T6KhShO5SKm5JXdFtoslkYUTf9BoeH4WA7pRqk2Jl9H5u tMFs9yfFSGS6cy9NulModSonJ9VPjuaHHWSbPWKdjS8kIaZd+UaMYV7Wquq21962IESoosrp3yz02 r4JqTvauYTSZnJpeCbQr7FLVrf+if1kKbYOlASFyEnwo9CjsJzB4roqaLYqw0NwfayVmtVeBfbQBD JsOfyGI/LnE1i4tTV54gHsQjRO+xkX4RzvVuHnaCCxvq18TVm+/c16GiSpkRTPfgpmedBFvE37W0G RBhLaZGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjgns-00000002Yd8-2QFJ; Thu, 29 Aug 2024 15:11:16 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjgn0-00000002YNk-2WDm for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 15:10:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724944221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BruaygEdXCnQYW8tbQ1OgV9ZuFw/62wvKJTlu2vfTEA=; b=D9dfBkmckUGetxCK50642IHZ9JJItozpb57gyh1D5Varl7mpA06Ud65gQ6/UbP6l6EMLLd bAJcvv5b2sUr9ArlhM2+JUOd6TQAEnxYoW8o8eA0ejMeVC3+IELxjPMhZaNBeE7CsDh/n6 st8Gh/9IF29b27Twz5n4aLIS4VDxQVY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-0_JYDgfmNpSRaeFJLxEVWg-1; Thu, 29 Aug 2024 11:10:20 -0400 X-MC-Unique: 0_JYDgfmNpSRaeFJLxEVWg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-428076fef5dso7774045e9.2 for ; Thu, 29 Aug 2024 08:10:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724944219; x=1725549019; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BruaygEdXCnQYW8tbQ1OgV9ZuFw/62wvKJTlu2vfTEA=; b=exD8b6XMrwHH5vz6pNRRfW/ujD/c6e+DieuSJmDRd/thHRi/ozkuWjaWeCYz93Q5eS S0gsMJCfgAjumsLEX94hTet4OUnyVj1PreuidAjI1F/tlxIR+DUnnUc/kaFLkk3e2FHn S9uDBrAvdIPbA5vTWGP4c2Cmof2hAgxq4rH1KcQNvgUdu44Bv+fR+Y+3GkpkS/H7t2/N RUaKV0LNZLudq5De6mxG1f7+dIXnWSCofRUmJ44sBLLIJowZd+lHlvj16+Rmwpvc/2uj vv5Ht9aIvoxLAcXeAkabmMEwXl70gvclU7m6OffCBHSJVVoFpDcx+l+RWrihEg5dqzLj xS7g== X-Forwarded-Encrypted: i=1; AJvYcCXG3/lTf+Jy9Y0GXqNoSvUaVTlTwhFRPfGs4ON592YneOQ0Nih5qDXKFhsPqdE3zLTnnyHJoMDtoGmHXBVtZV7u@lists.infradead.org X-Gm-Message-State: AOJu0YzcA+1hJUIGuWlA4DDEMt7owcf7c7wEKVTsdS140WWkXjVAhQ0X pJtN+wlnBMriMxr3NDjBZqtNPZATLrr2CIIW1uoKNPQGC8qabk0bBhAmAbhu/N1/1knyfPkKQ0s //s3XvU4I7UR5Dyb+vWkEoLWxLxzwfZdRjUx/iWT8QtA32Mj9j0G/634iD0du6SsENx8SI/Qc X-Received: by 2002:a05:600c:46c4:b0:428:1ce0:4dfd with SMTP id 5b1f17b1804b1-42bb029cd59mr29162995e9.34.1724944218601; Thu, 29 Aug 2024 08:10:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaB3fJNuysQDaWNUVjmCWx+VoGILEMX3LXPPl/rnoPKW6dJwP5dmIcBvd6CKZ6baC9Oqk3sQ== X-Received: by 2002:a05:600c:46c4:b0:428:1ce0:4dfd with SMTP id 5b1f17b1804b1-42bb029cd59mr29161325e9.34.1724944217558; Thu, 29 Aug 2024 08:10:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c711:c600:c1d6:7158:f946:f083? (p200300cbc711c600c1d67158f946f083.dip0.t-ipconnect.de. [2003:cb:c711:c600:c1d6:7158:f946:f083]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ef7e09esm1639187f8f.86.2024.08.29.08.10.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Aug 2024 08:10:16 -0700 (PDT) Message-ID: Date: Thu, 29 Aug 2024 17:10:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/19] mm/pagewalk: Check pfnmap for folio_walk_start() To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Gavin Shan , Catalin Marinas , x86@kernel.org, Ingo Molnar , Andrew Morton , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Alistair Popple , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Borislav Petkov , Zi Yan , Axel Rasmussen , Yan Zhao , Will Deacon , Kefeng Wang , Alex Williamson References: <20240826204353.2228736-1-peterx@redhat.com> <20240826204353.2228736-7-peterx@redhat.com> <9f9d7e96-b135-4830-b528-37418ae7bbfd@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_081022_763748_B85F3E98 X-CRM114-Status: GOOD ( 22.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >>> >>> If you prefer vm_normal_page_pud() to be defined and check pud_special() >>> there, I can do that. But again, I don't yet see how that can make a >>> functional difference considering the so far very limited usage of the >>> special bit, and wonder whether we can do that on top when it became >>> necessary (and when we start to have functional requirement of such). >> >> I hope my explanation why pte_special() even exists and how it is used makes >> it clearer. >> >> It's not that much code to handle it like pte_special(), really. I don't >> expect you to teach GUP-slow about vm_normal_page() etc. > > One thing I can do here is I move the pmd_special() check into the existing > vm_normal_page_pmd(), then it'll be a fixup on top of this patch: > > ===8<=== > diff --git a/mm/memory.c b/mm/memory.c > index 288f81a8698e..42674c0748cb 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -672,11 +672,10 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, > { > unsigned long pfn = pmd_pfn(pmd); > > - /* > - * There is no pmd_special() but there may be special pmds, e.g. > - * in a direct-access (dax) mapping, so let's just replicate the > - * !CONFIG_ARCH_HAS_PTE_SPECIAL case from vm_normal_page() here. > - */ > + /* Currently it's only used for huge pfnmaps */ > + if (unlikely(pmd_special(pmd))) > + return NULL; Better. I'd appreciate a vm_normal_page_pud(), but I guess I have to be the one cleaning up the mess after you. -- Cheers, David / dhildenb