From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B3ACC433F5 for ; Fri, 20 May 2022 13:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tr47k1OXOvNpfPKTIb64d4XwT0HDx1aY8yuxgl0ahQw=; b=q7vvRzyK8bgqIl Gx7i5tHNkvAP2SnTGr5suQgFr4JLDaILX+nKZMQ4dkm0tEtuosnj8lmMPr6Lw1zfaIokK+l81K+LZ e14z5+ZUmulS9xhQ18vzQcTJ7/kC83PSq5t5RkkA/lqQqm+r7E15d0L563N8anrsD9GWVYrUzQEdl h0uxHCwYiI2ypI5ZcgkWVEO4qgpgMLQs4SC0MaC9aXM47rua17VkxBT4LczzcLaxJ6JSKk5iFZTuo Xer8nmbUSn+rLug/yZQ+sIc9DVMHzzlKeritOt9rmVK9PTqipGX+mgazlrF4b+E9YDLudRghBbZtF ICELvTZqiUmanOL5rLng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns2q6-00CgzS-LI; Fri, 20 May 2022 13:38:47 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns2q2-00Cgww-Nb for linux-arm-kernel@lists.infradead.org; Fri, 20 May 2022 13:38:44 +0000 Received: by mail-lj1-x232.google.com with SMTP id b32so9741182ljf.1 for ; Fri, 20 May 2022 06:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=BJ6cahNcHV64dckbcdagFZ3sXXRYfeYn07qe+/rH0Js=; b=Swsr4EYUUhBGy78gK70OvbbFgbl+xy4A36NGHggg9MIrLAwzJ3L8g3yIQ9pJiZcHPg 5Z4AjQmI8LhFAkWKs1ms85fN0rwO2dGcB0PkM3c3Q4Mp5uIz+pxLR0FI+u/YiXj3PnjT xEfvLERea7XgQ27+5UU7YDdcRvLRe7KZYXOw/kzR7YpmI+WPjHYHicrGkoIpCSwixvEF qX2B9OqRIDzWJEChsL8RoJG7AkW0ohMp4f9j9uxYBDLdctrCwEbp4cg9bWR+ILHo2lj4 gELpWVXkRWAkzYZWD98W4c8v3VVw3H2s8R1CMwWGfB+7L6geo0EvtMEjMNVBE4VJukVy +Yfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BJ6cahNcHV64dckbcdagFZ3sXXRYfeYn07qe+/rH0Js=; b=VSrVnKTr4XbgzCXQl/AkeRgAeIHRIT+GZ2jL9mdzWa5v64NLZH58RNm/2D8yTzVhaW zhokoLzL0CcMja0toBuIZQD/EVzU2cfmpFe14hWtQyfXh07Q8JWkI+c1hxwPHC15fojN mOIKYKyKg5GMXwfjVAO2bC0MgRwW6cyLafwQKhk4uGDu6q4EaqM8gX4ix15wyT/20iqg tqZI/PSXgcqjEqPluuJd6YYUvhVXbHmDl9CK0bJUj/hYKm3v7kPJSQ/QzOo8Ejbk4Ebu YtBLK84MauCqM085w7jaFNFxLYhLHUEMLrnqRAyo4bvy639r749GuvXVQDkDdYbYs6qZ d6/g== X-Gm-Message-State: AOAM530Rm+E1jOfbZut0Bos5exht7j1/kxLLypJ+ut4FFMKu6wiMWacn yS16NQ8P4mBmAs5exesqgXUNLg== X-Google-Smtp-Source: ABdhPJz7+4KDKaqz3IBBXBx/FkONS5BgchZ7fWWMZ6ZrP5bc3A9c1J212pfOKC8DCyjp/llbwrwJOA== X-Received: by 2002:a2e:b8d0:0:b0:253:ca3b:f0ad with SMTP id s16-20020a2eb8d0000000b00253ca3bf0admr5740825ljp.334.1653053918597; Fri, 20 May 2022 06:38:38 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o14-20020ac25e2e000000b0047255d210e3sm667857lfg.18.2022.05.20.06.38.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 06:38:37 -0700 (PDT) Message-ID: Date: Fri, 20 May 2022 15:38:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Content-Language: en-US To: Herve Codina References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-3-herve.codina@bootlin.com> <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org> <20220520133426.3b4728ae@bootlin.com> <20220520142109.57b84da2@bootlin.com> <01b31a02-523e-10bf-3b46-5b830e456522@linaro.org> <20220520150243.625723fa@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20220520150243.625723fa@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220520_063842_805919_AAA2E7E0 X-CRM114-Status: GOOD ( 19.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , linux-kernel@vger.kernel.org, Thomas Petazzoni , Stephen Boyd , Greg Kroah-Hartman , Michael Turquette , linux-usb@vger.kernel.org, linux-clk@vger.kernel.org, Horatiu Vultur , Rob Herring , Krzysztof Kozlowski , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/05/2022 15:02, Herve Codina wrote: > On Fri, 20 May 2022 14:50:24 +0200 > Krzysztof Kozlowski wrote: > >> On 20/05/2022 14:21, Herve Codina wrote: >>>>> I think it makes sense to keep 'microchip,lan966x-udc' for the USB >>>>> device controller (same controller on LAN9662 and LAN9668) and so >>>>> keeping the same rules as for other common parts. >>>> >>>> Having wildcard was rather a mistake and we already started correcting >>>> it, so keeping the "mistake" neither gives you consistency, nor >>>> correctness... >>>> >>> >>> I think that the "family" compatible should be present. >>> This one allows to define the common parts in the common >>> .dtsi file (lan966x.dtsi in our case). >>> >>> What do you think about: >>> - microchip,lan9662-udc >>> - microchip,lan9668-udc >>> - microchip,lan966-udc <-- Family >>> >>> lan966 is defined as the family compatible string since (1) in >>> bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst >>> >> >> You can add some family compatible, if it makes sense. I don't get why >> do you mention it - we did not discuss family names, but using >> wildcards... Just please do not add wildcards. > > Well, I mentioned it as I will only use the family compatible string > and not the SOC (lan9662 or lan9668) compatible string in lan966x.dtsi. > In this case, the family compatible string can be seen as a kind of > "wildcard". I understood as "the "family" compatible should be present" as you want to add it as a fallback. It would be okay (assuming devices indeed share family design). If you want to use it as the only one, then it is again not a recommended approach. Please use specific compatibles. I mean, why do we have this discussion? What is the benefit for you to implement something not-recommended by Devicetree spec and style? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel