public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] soc: ti: qmss: fix the case when !SMP
Date: Wed, 30 Nov 2016 11:09:03 -0600	[thread overview]
Message-ID: <d26f37e6-657f-ff42-2d9d-343fa47c2e5d@ti.com> (raw)
In-Reply-To: <20161130165351.1154-1-grygorii.strashko@ti.com>

+ Santosh Shilimkar <santosh.shilimkar@oracle.com>

On 11/30/2016 10:53 AM, Grygorii Strashko wrote:
> The irq_set_affinity_hint() will always fail when !SMP and
> Networking will fail on Keystone 2 devices in this case.
> Hence, fix by ignoring IRQ affinity settings when !SMP.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
>  drivers/soc/ti/knav_qmss_queue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index b73e353..eacad57 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct knav_device *kdev,
>
>  		range->num_irqs++;
>
> -		if (oirq.args_count == 3)
> +		if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
>  			range->irqs[i].cpu_map =
>  				(oirq.args[2] & 0x0000ff00) >> 8;
>  	}
>

-- 
regards,
-grygorii

  reply	other threads:[~2016-11-30 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30 16:53 [PATCH v2] soc: ti: qmss: fix the case when !SMP Grygorii Strashko
2016-11-30 17:09 ` Grygorii Strashko [this message]
2016-11-30 17:13   ` Santosh Shilimkar
2016-11-30 21:11     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d26f37e6-657f-ff42-2d9d-343fa47c2e5d@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox