From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Thomas McKahan <tmckahan@singleboardsolutions.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add NanoPC T6
Date: Tue, 8 Aug 2023 07:57:52 +0200 [thread overview]
Message-ID: <d28cf9c5-b914-053a-76df-c15e191c042d@linaro.org> (raw)
In-Reply-To: <20230808002751.00001385@singleboardsolutions.com>
On 08/08/2023 06:32, Thomas McKahan wrote:
>>> +
>>> + regulators {
>>> + vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 {
>>> + regulator-boot-on;
>>
>> Boolean properties are not first, but last. regulator-name is the first
>> one. This odd style...
>>
>
> I agree, however it seems the norm in Rockchip devices. This will
> become an outlier in Rockchip but fall in line with the general case.
> I'll put it in V2 with the other mentioned fixes unless a conflicting
> opinion is expressed.
OK, no need to change then.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-08 5:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 5:14 [PATCH 0/2] Add Support for the FriendlyElec NanoPC T6 Thomas McKahan
2023-08-02 5:14 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add " Thomas McKahan
2023-08-02 15:37 ` Conor Dooley
2023-08-02 5:14 ` [PATCH 2/2] arm64: dts: " Thomas McKahan
2023-08-07 6:44 ` Krzysztof Kozlowski
2023-08-08 4:32 ` Thomas McKahan
2023-08-08 5:57 ` Krzysztof Kozlowski [this message]
2023-08-08 11:35 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d28cf9c5-b914-053a-76df-c15e191c042d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=tmckahan@singleboardsolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).