[PATCH v3 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander

[PATCH v3 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander

[Stefan Wahren]

Hi Linus,
hi Eric,


Am 16.01.2018 um 13:45 schrieb Baruch Siach:
> Add a description of the RPi3 GPIO expander that the VC4 firmware controls.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v3:
>    * List GPIO names one per line.
>
> v2:
>    * Move GPIO expander node out of the soc container
>    * Rename compatible string
>    * Add gpio-line-names property
> ---
>   arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> index b44b3b5af00d..8cd93425ffe3 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> @@ -23,6 +23,22 @@
>   			gpios = <&gpio 47 0>;
>   		};
>   	};

i noticed that this patch conflicts with my patch ("ARM: dts: bcm283x: 
Use GPIO polarity defines consistently") in linux-next.

How should we proceed?

> +
> +	expgpio: gpio-expander {
> +		compatible = "raspberrypi,firmware-gpio";
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		firmware = <&firmware>;
> +		gpio-line-names = "BT_ON",
> +				  "WL_ON",
> +				  "STATUS_LED",
> +				  "LAN_RUN",
> +				  "HPD_N",
> +				  "CAM_GPIO0",
> +				  "CAM_GPIO1",
> +				  "PWR_LOW_N";
> +		status = "okay";
> +	};
>   };
>   
>   /* uart0 communicates with the BT module */

[PATCH v3 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander

[Linus Walleij]

On Wed, Jan 17, 2018 at 9:30 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:

> Hi Linus,
> hi Eric,
>
>
> Am 16.01.2018 um 13:45 schrieb Baruch Siach:
>>
>> Add a description of the RPi3 GPIO expander that the VC4 firmware
>> controls.
>>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> v3:
>>    * List GPIO names one per line.
>>
>> v2:
>>    * Move GPIO expander node out of the soc container
>>    * Rename compatible string
>>    * Add gpio-line-names property
>> ---
>>   arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> index b44b3b5af00d..8cd93425ffe3 100644
>> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> @@ -23,6 +23,22 @@
>>                         gpios = <&gpio 47 0>;
>>                 };
>>         };
>
>
> i noticed that this patch conflicts with my patch ("ARM: dts: bcm283x: Use
> GPIO polarity defines consistently") in linux-next.
>
> How should we proceed?

All DTS patches shall be merged through ARM SoC so the conflict should
be resolved by whoever sends the pull requests to ARM SoC before
sending the pull request.

I think these patches will be for the next kernel anyways, unless Torvalds
think we should have an -rc9 this time (because of all the meltdowns and
spectres etc you know).

Yours,
Linus Walleij

[PATCH v3 3/4] gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service

[Stefan Wahren]

Hi Baruch,

> Baruch Siach <baruch@tkos.co.il> hat am 16. Januar 2018 um 13:45 geschrieben:
> 
> 
> From: Dave Stevenson <dave.stevenson@raspberrypi.org>
> 
> Pi3 and Compute Module 3 have a GPIO expander that the
> VPU communicates with.
> There is a mailbox service that now allows control of this
> expander, so add a kernel driver that can make use of it.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v3:
>   * Tweak Kconfig driver prompt
>   * Make GPIO_RASPBERRYPI_EXP tristate
>   * Make COMPILE_TEST independent of RASPBERRYPI_FIRMWARE
>   * Remove redundant DMA header
>   * Use less code lines for dev_err()
>   * Check rpi_exp_gpio_get_polarity() return value
>   * Remove redundant platform_set_drvdata() call
> 
> v2:
>   * Rename driver to gpio-raspberrypi-exp
>   * Populate the gpiochip parent device pointer
>   * Use macro for the mailbox base GPIO number
>   * Drop linux/gpio.h and GPIOF_DIR_*
>   * Check and print firmware error value
>   * Use devm_gpiochip_add_data(); drop .remove
>   * A few more minor tweaks
> ---
>  drivers/gpio/Kconfig                |   9 ++
>  drivers/gpio/Makefile               |   1 +
>  drivers/gpio/gpio-raspberrypi-exp.c | 253 ++++++++++++++++++++++++++++++++++++
>  3 files changed, 263 insertions(+)
>  create mode 100644 drivers/gpio/gpio-raspberrypi-exp.c
> 
> ...
> +
> +static int rpi_exp_gpio_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct device_node *np = dev->of_node;
> +	struct device_node *fw_node;
> +	struct rpi_firmware *fw;
> +	struct rpi_exp_gpio *rpi_gpio;
> +
> +	fw_node = of_parse_phandle(np, "firmware", 0);
> +	if (!fw_node) {
> +		dev_err(dev, "Missing firmware node\n");
> +		return -ENOENT;
> +	}
> +
> +	fw = rpi_firmware_get(fw_node);
> +	if (!fw)
> +		return -EPROBE_DEFER;
> +
> +	rpi_gpio = devm_kzalloc(dev, sizeof(*rpi_gpio), GFP_KERNEL);
> +	if (!rpi_gpio)
> +		return -ENOMEM;
> +
> +	rpi_gpio->fw = fw;
> +	rpi_gpio->gc.parent = dev;
> +	rpi_gpio->gc.label = MODULE_NAME;
> +	rpi_gpio->gc.owner = THIS_MODULE;
> +	rpi_gpio->gc.of_node = np;
> +	rpi_gpio->gc.base = -1;
> +	rpi_gpio->gc.ngpio = NUM_GPIO;
> +
> +	rpi_gpio->gc.direction_input = rpi_exp_gpio_dir_in;
> +	rpi_gpio->gc.direction_output = rpi_exp_gpio_dir_out;
> +	rpi_gpio->gc.get_direction = rpi_exp_gpio_get_direction;
> +	rpi_gpio->gc.get = rpi_exp_gpio_get;
> +	rpi_gpio->gc.set = rpi_exp_gpio_set;
> +	rpi_gpio->gc.can_sleep = true;
> +
> +	return devm_gpiochip_add_data(dev, &rpi_gpio->gc, rpi_gpio);
> +}
> +
> +static const struct of_device_id rpi_exp_gpio_ids[] = {
> +	{ .compatible = "raspberrypi,firmware-gpio" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, rpi_exp_gpio_ids);
> +
> +static struct platform_driver rpi_exp_gpio_driver = {
> +	.driver	= {
> +		.name		= MODULE_NAME,
> +		.owner		= THIS_MODULE,

i assume you got the kbuild test robot mail about this. So please remove this and you can add my 

Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>

> +		.of_match_table	= of_match_ptr(rpi_exp_gpio_ids),
> +	},
> +	.probe	= rpi_exp_gpio_probe,
> +};
> +module_platform_driver(rpi_exp_gpio_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Dave Stevenson <dave.stevenson@raspberrypi.org>");
> +MODULE_DESCRIPTION("Raspberry Pi 3 expander GPIO driver");
> +MODULE_ALIAS("platform:rpi-exp-gpio");
> -- 
> 2.15.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v3 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander

[Stefan Wahren]

> Baruch Siach <baruch@tkos.co.il> hat am 16. Januar 2018 um 13:45 geschrieben:
> 
> 
> Add a description of the RPi3 GPIO expander that the VC4 firmware controls.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

[PATCH v3 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding

[Rob Herring]

On Tue, Jan 16, 2018 at 02:45:08PM +0200, Baruch Siach wrote:
> The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware over
> I2C. The firmware mailbox interface allows the ARM core to control the
> GPIO lines.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v3:
>   * Rename node name.
> 
> v2:
>   * Rename compatible string to raspberrypi,firmware-gpio
> ---
>  .../bindings/gpio/raspberrypi,firmware-gpio.txt    | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt
> 
> diff --git a/Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt b/Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt
> new file mode 100644
> index 000000000000..936dc59eba12
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt
> @@ -0,0 +1,24 @@
> +Raspberry Pi GPIO expander
> +
> +The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware. The
> +firmware exposes a mailbox interface that allows the ARM core to control the
> +GPIO lines on the expander.
> +
> +Required properties:
> +
> +- compatible : Should be "raspberrypi,firmware-gpio"
> +- gpio-controller : Marks the device node as a gpio controller
> +- #gpio-cells : Should be two.  The first cell is the pin number, and
> +  the second cell is used to specify the gpio polarity:
> +  0 = active high
> +  1 = active low
> +- firmware : Reference to the RPi firmware device node
> +
> +Example:
> +
> +expgpio: gpio-expander {

Still not right. The correct generic node name is "gpio".

> +	compatible = "raspberrypi,firmware-gpio";
> +	gpio-controller;
> +	#gpio-cells = <2>;
> +	firmware = <&firmware>;

Can you make this a child of the firmware node instead?

Rob

[PATCH v3 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding

[Baruch Siach]

Hi Rob,

Thanks for reviewing.

On Mon, Jan 29, 2018 at 10:11:34AM -0600, Rob Herring wrote:
> On Tue, Jan 16, 2018 at 02:45:08PM +0200, Baruch Siach wrote:
> > The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware over
> > I2C. The firmware mailbox interface allows the ARM core to control the
> > GPIO lines.
> > 
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > v3:
> >   * Rename node name.
> > 
> > v2:
> >   * Rename compatible string to raspberrypi,firmware-gpio
> > ---
> >  .../bindings/gpio/raspberrypi,firmware-gpio.txt    | 24 ++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt b/Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt
> > new file mode 100644
> > index 000000000000..936dc59eba12
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/raspberrypi,firmware-gpio.txt
> > @@ -0,0 +1,24 @@
> > +Raspberry Pi GPIO expander
> > +
> > +The Raspberry Pi 3 GPIO expander is controlled by the VC4 firmware. The
> > +firmware exposes a mailbox interface that allows the ARM core to control the
> > +GPIO lines on the expander.
> > +
> > +Required properties:
> > +
> > +- compatible : Should be "raspberrypi,firmware-gpio"
> > +- gpio-controller : Marks the device node as a gpio controller
> > +- #gpio-cells : Should be two.  The first cell is the pin number, and
> > +  the second cell is used to specify the gpio polarity:
> > +  0 = active high
> > +  1 = active low
> > +- firmware : Reference to the RPi firmware device node
> > +
> > +Example:
> > +
> > +expgpio: gpio-expander {
> 
> Still not right. The correct generic node name is "gpio".

I'll fix that.

> > +	compatible = "raspberrypi,firmware-gpio";
> > +	gpio-controller;
> > +	#gpio-cells = <2>;
> > +	firmware = <&firmware>;
> 
> Can you make this a child of the firmware node instead?

I guess I can, I'll need to look into it. What is the advantage of that? What 
about the existing raspberrypi,bcm2835-power[1] node in bcm2835-rpi.dtsi? 
Should it move under the firmware node as well?

[1] Documentation/devicetree/bindings/soc/bcm/raspberrypi,bcm2835-power.txt

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander

[Linus Walleij]

On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:

> The Raspberry Pi 3 has a GPIO expander that controls, among others, the
> activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus
> that is not directly controlled from the ARM core. The VC4 firmware controls
> the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox
> interface.
>
> This series adds support for the RPi3 expander.
>
> The driver is ported from the downstream kernel at
> https://github.com/raspberrypi/linux/, branch rpi-4.9.y.
>
> Changes in v3:
>
>   * Kconfig tweaks
>   * Check rpi_exp_gpio_get_polarity() return value
>   * Redundant header removal
>   * Redundant platform_set_drvdata() call removal
>   * Small coding style changes

All is looking pretty good. I see Rob had some last minute comments,
but please rebase and repost post v4.16-rc1 so we can get this merged,
we need to get this upstream.

Yours,
Linus Walleij

[PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander

[Baruch Siach]

Hi Linus,

On Tue, Feb 06, 2018 at 02:42:48PM +0100, Linus Walleij wrote:
> On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> 
> > The Raspberry Pi 3 has a GPIO expander that controls, among others, the
> > activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus
> > that is not directly controlled from the ARM core. The VC4 firmware controls
> > the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox
> > interface.
> >
> > This series adds support for the RPi3 expander.
> >
> > The driver is ported from the downstream kernel at
> > https://github.com/raspberrypi/linux/, branch rpi-4.9.y.
> >
> > Changes in v3:
> >
> >   * Kconfig tweaks
> >   * Check rpi_exp_gpio_get_polarity() return value
> >   * Redundant header removal
> >   * Redundant platform_set_drvdata() call removal
> >   * Small coding style changes
> 
> All is looking pretty good. I see Rob had some last minute comments,
> but please rebase and repost post v4.16-rc1 so we can get this merged,
> we need to get this upstream.

I was about to send v4 when I saw your email. I based v4 on current LinusT's 
tree as of e237f98a9c. I guess that affected files will not change before 
v4.16-rc1, but I can wait a few more days for -rc1.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander

[Linus Walleij]

On Tue, Feb 6, 2018 at 5:27 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> On Tue, Feb 06, 2018 at 02:42:48PM +0100, Linus Walleij wrote:
>> On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:
>>
>> > The Raspberry Pi 3 has a GPIO expander that controls, among others, the
>> > activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus
>> > that is not directly controlled from the ARM core. The VC4 firmware controls
>> > the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox
>> > interface.
>> >
>> > This series adds support for the RPi3 expander.
>> >
>> > The driver is ported from the downstream kernel at
>> > https://github.com/raspberrypi/linux/, branch rpi-4.9.y.
>> >
>> > Changes in v3:
>> >
>> >   * Kconfig tweaks
>> >   * Check rpi_exp_gpio_get_polarity() return value
>> >   * Redundant header removal
>> >   * Redundant platform_set_drvdata() call removal
>> >   * Small coding style changes
>>
>> All is looking pretty good. I see Rob had some last minute comments,
>> but please rebase and repost post v4.16-rc1 so we can get this merged,
>> we need to get this upstream.
>
> I was about to send v4 when I saw your email. I based v4 on current LinusT's
> tree as of e237f98a9c. I guess that affected files will not change before
> v4.16-rc1, but I can wait a few more days for -rc1.

It's fine to send if you feel it is ready. I am already queueing
stuff for v4.17.

Yours,
Linus Walleij

[PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander

[Stefan Wahren]

Hi Baruch,

Am 06.02.2018 um 17:27 schrieb Baruch Siach:
> Hi Linus,
>
> On Tue, Feb 06, 2018 at 02:42:48PM +0100, Linus Walleij wrote:
>> On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:
>>
>>> The Raspberry Pi 3 has a GPIO expander that controls, among others, the
>>> activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus
>>> that is not directly controlled from the ARM core. The VC4 firmware controls
>>> the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox
>>> interface.
>>>
>>> This series adds support for the RPi3 expander.
>>>
>>> The driver is ported from the downstream kernel at
>>> https://github.com/raspberrypi/linux/, branch rpi-4.9.y.
>>>
>>> Changes in v3:
>>>
>>>   * Kconfig tweaks
>>>   * Check rpi_exp_gpio_get_polarity() return value
>>>   * Redundant header removal
>>>   * Redundant platform_set_drvdata() call removal
>>>   * Small coding style changes
>> All is looking pretty good. I see Rob had some last minute comments,
>> but please rebase and repost post v4.16-rc1 so we can get this merged,
>> we need to get this upstream.
> I was about to send v4 when I saw your email. I based v4 on current LinusT's 
> tree as of e237f98a9c. I guess that affected files will not change before 
> v4.16-rc1, but I can wait a few more days for -rc1.
>
> baruch
>
please also address the owner issue in the driver, which was reported by
kbuild test robot.

Thanks

Stefan

[PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander

[Baruch Siach]

Hi Stefan,

On Wed, Feb 07, 2018 at 10:33:24AM +0100, Stefan Wahren wrote:
> Am 06.02.2018 um 17:27 schrieb Baruch Siach:
> > On Tue, Feb 06, 2018 at 02:42:48PM +0100, Linus Walleij wrote:
> >> On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> >>
> >>> The Raspberry Pi 3 has a GPIO expander that controls, among others, the
> >>> activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus
> >>> that is not directly controlled from the ARM core. The VC4 firmware controls
> >>> the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox
> >>> interface.
> >>>
> >>> This series adds support for the RPi3 expander.
> >>>
> >>> The driver is ported from the downstream kernel at
> >>> https://github.com/raspberrypi/linux/, branch rpi-4.9.y.
> >>>
> >>> Changes in v3:
> >>>
> >>>   * Kconfig tweaks
> >>>   * Check rpi_exp_gpio_get_polarity() return value
> >>>   * Redundant header removal
> >>>   * Redundant platform_set_drvdata() call removal
> >>>   * Small coding style changes
> >> All is looking pretty good. I see Rob had some last minute comments,
> >> but please rebase and repost post v4.16-rc1 so we can get this merged,
> >> we need to get this upstream.
> > I was about to send v4 when I saw your email. I based v4 on current LinusT's 
> > tree as of e237f98a9c. I guess that affected files will not change before 
> > v4.16-rc1, but I can wait a few more days for -rc1.
>
> please also address the owner issue in the driver, which was reported by
> kbuild test robot.

I removed the .owner platform_driver field set from v4. The owner field in 
gpio_chip is still set.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[PATCH v3 0/4] gpio: driver for the RPi3 GPIO expander

[Stefan Wahren]

Am 07.02.2018 um 10:38 schrieb Baruch Siach:
> Hi Stefan,
>
> On Wed, Feb 07, 2018 at 10:33:24AM +0100, Stefan Wahren wrote:
>> Am 06.02.2018 um 17:27 schrieb Baruch Siach:
>>> On Tue, Feb 06, 2018 at 02:42:48PM +0100, Linus Walleij wrote:
>>>> On Tue, Jan 16, 2018 at 1:45 PM, Baruch Siach <baruch@tkos.co.il> wrote:
>>>>
>>>>> The Raspberry Pi 3 has a GPIO expander that controls, among others, the
>>>>> activity LED, and the camera connector GPIOs. The GPIO expander on an I2C bus
>>>>> that is not directly controlled from the ARM core. The VC4 firmware controls
>>>>> the I2C bus, and allows the ARM core to set/get GPIO settings over its mailbox
>>>>> interface.
>>>>>
>>>>> This series adds support for the RPi3 expander.
>>>>>
>>>>> The driver is ported from the downstream kernel at
>>>>> https://github.com/raspberrypi/linux/, branch rpi-4.9.y.
>>>>>
>>>>> Changes in v3:
>>>>>
>>>>>    * Kconfig tweaks
>>>>>    * Check rpi_exp_gpio_get_polarity() return value
>>>>>    * Redundant header removal
>>>>>    * Redundant platform_set_drvdata() call removal
>>>>>    * Small coding style changes
>>>> All is looking pretty good. I see Rob had some last minute comments,
>>>> but please rebase and repost post v4.16-rc1 so we can get this merged,
>>>> we need to get this upstream.
>>> I was about to send v4 when I saw your email. I based v4 on current LinusT's
>>> tree as of e237f98a9c. I guess that affected files will not change before
>>> v4.16-rc1, but I can wait a few more days for -rc1.
>> please also address the owner issue in the driver, which was reported by
>> kbuild test robot.
> I removed the .owner platform_driver field set from v4. The owner field in
> gpio_chip is still set.

perfect

>
> baruch
>