From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 074B6C433F5 for ; Fri, 25 Feb 2022 00:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SGkOTK/KI33qyr8qyUkcxwNNhMdQXEUpGZgNrKgo4d8=; b=Dxxx8LwzfQm288 24Yy5daAjH6yfajsfv5jhkL4IBTMzeCIk40mIw0saLjwWnUwd4BAg1saOLL/aBL+QZfO7KueNuQ31 CS7nxKA0Ufq3bJ2dTGqVuWklxv+eeVElK2vpEW8GsTaRY97qHI0yqVW/OcxhUjj1HDoiqV/DqiozF gs0nDZMBGC85mrS0p05FdhMKqUGps113KBc3YIKOBbRWxzxnrKWF5m71y984E5+9O99UL4NCFOTUr jfoBdOy0d5KOnHjcrvuWBQmgsapOX/zirgr34ZOWcr5+6tDzu7IAgg/52kAfVMPoMgJJO2xZ8J2aT kfFI7BLoE0HTJqzgrnLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNOZv-002nMX-Bt; Fri, 25 Feb 2022 00:35:23 +0000 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNOZr-002nLo-T1 for linux-arm-kernel@lists.infradead.org; Fri, 25 Feb 2022 00:35:21 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R101e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04394; MF=ashimida@linux.alibaba.com; NM=1; PH=DS; RN=20; SR=0; TI=SMTPD_---0V5Q66IT_1645749311; Received: from 192.168.193.153(mailfrom:ashimida@linux.alibaba.com fp:SMTPD_---0V5Q66IT_1645749311) by smtp.aliyun-inc.com(127.0.0.1); Fri, 25 Feb 2022 08:35:12 +0800 Message-ID: Date: Thu, 24 Feb 2022 16:34:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] [PATCH] AARCH64: Add gcc Shadow Call Stack support Content-Language: en-US To: Nathan Chancellor Cc: catalin.marinas@arm.com, will@kernel.org, ndesaulniers@google.com, keescook@chromium.org, masahiroy@kernel.org, tglx@linutronix.de, akpm@linux-foundation.org, mark.rutland@arm.com, samitolvanen@google.com, npiggin@gmail.com, linux@roeck-us.net, mhiramat@kernel.org, ojeda@kernel.org, luc.vanoostenryck@gmail.com, elver@google.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20220222095736.24898-1-ashimida@linux.alibaba.com> <69d351c6-a69d-6ebb-53bc-b46dfe4da08a@linux.alibaba.com> From: Dan Li In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220224_163520_157145_CE469972 X-CRM114-Status: GOOD ( 10.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/23/22 09:39, Nathan Chancellor wrote: > On Wed, Feb 23, 2022 at 12:50:21AM -0800, Dan Li wrote: >> My intention is to remind users that this is a compiler feature. >> But since there is also a hint in CC_HAVE_SHADOW_CALL_STACK: >> +# Supported by clang >= 7.0 or GCC ... >> >> Removing the specific compiler here also looks fine to me. >> Would this look better? >> >> "This option enables Shadow Call Stack, which uses a ..." >> >> or maybe: >> >> "This option enables compiler's Shadow Call Stack, which uses a ..." > > I do not honestly have a strong opinion around removing mention of the > compiler so either looks fine to me (might be better to say "the > compiler's Shadow ..." in the second one). > Ah, yes, thanks :) Dan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel