From: Robin Murphy <robin.murphy@arm.com>
To: Danilo Krummrich <dakr@kernel.org>,
Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
broonie@kernel.org, will@kernel.org, joro@8bytes.org,
robin.clark@oss.qualcomm.com, hanguidong02@gmail.com,
quic_c_gdjako@quicinc.com, dmitry.baryshkov@oss.qualcomm.com,
driver-core@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] iommu/arm-smmu-qcom: do not register driver in probe()
Date: Thu, 22 Jan 2026 12:12:53 +0000 [thread overview]
Message-ID: <d2ddbb72-30a8-44da-b761-876b2d37567e@arm.com> (raw)
In-Reply-To: <DFV3I3D5UIZP.38TNCAJWQGI3O@kernel.org>
On 2026-01-22 11:52 am, Danilo Krummrich wrote:
> On Thu Jan 22, 2026 at 10:21 AM CET, Ioana Ciornei wrote:
>> The boot lockup was visible also on the NXP LX2160ARDB. This patch fixes
>> it.
>
> Interesting, this means that qcom_smmu_impl_init() must be called on this
> machine, is this expected?
Yup, same as on the Juno boards and probably others - an Arm SMMU is
present, which means if ARM_SMMU_QCOM is enabled then
arm_smmu_impl_init() is going to offer it to ask "hey, is this one of
yours that you might want to do something with based on your extensive
and complicated match list that we don't want to maintain in the common
impl code?", wherein qcom_smmu_impl_init() *should* return without doing
anything at all as it's not a match...
Cheers,
Robin.
>
>> Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com> #LX2160ARDB
>
> Thanks for testing!
next prev parent reply other threads:[~2026-01-22 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 14:12 [PATCH] iommu/arm-smmu-qcom: do not register driver in probe() Danilo Krummrich
2026-01-21 14:46 ` Greg KH
2026-01-21 15:11 ` Robin Murphy
2026-01-21 15:54 ` Bjorn Andersson
2026-01-21 16:02 ` Konrad Dybcio
2026-01-21 16:05 ` Mark Brown
2026-01-22 3:03 ` Wang Jiayue
2026-01-22 8:18 ` Jörg Rödel
2026-01-22 8:37 ` Danilo Krummrich
2026-01-22 9:21 ` Ioana Ciornei
2026-01-22 11:52 ` Danilo Krummrich
2026-01-22 12:12 ` Robin Murphy [this message]
2026-01-22 14:41 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2ddbb72-30a8-44da-b761-876b2d37567e@arm.com \
--to=robin.murphy@arm.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=hanguidong02@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_c_gdjako@quicinc.com \
--cc=rafael@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox