From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yassine Oudjana <yassine.oudjana@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Daniel Golle <daniel@makrotopia.org>,
Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
Tinghan Shen <tinghan.shen@mediatek.com>,
Chen-Yu Tsai <wenst@chromium.org>,
Edward-JW Yang <edward-jw.yang@mediatek.com>,
Johnson Wang <johnson.wang@mediatek.com>,
Fabien Parent <fparent@baylibre.com>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Miles Chen <miles.chen@mediatek.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Yassine Oudjana <y.oudjana@protonmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 1/4] dt-bindings: clock: Add MediaTek MT6735 clock bindings
Date: Mon, 27 Feb 2023 10:08:20 +0100 [thread overview]
Message-ID: <d2e43fe8-2072-6723-dbb4-500a6ff8f719@linaro.org> (raw)
In-Reply-To: <2XCQQR.YSBPBN01H6D31@gmail.com>
On 27/02/2023 09:29, Yassine Oudjana wrote:
>
> On Mon, Feb 27 2023 at 09:18:45 AM +01:00:00, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> On 25/02/2023 10:42, Yassine Oudjana wrote:
>>> From: Yassine Oudjana <y.oudjana@protonmail.com>
>>>
>>> Add clock definitions for the main clock controllers of MT6735
>>> (apmixedsys,
>>> topckgen, infracfg and pericfg).
>>>
>>> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> ---
>>> MAINTAINERS | 10 +++
>>> .../clock/mediatek,mt6735-apmixedsys.h | 16 ++++
>>> .../clock/mediatek,mt6735-infracfg.h | 25 ++++++
>>> .../clock/mediatek,mt6735-pericfg.h | 37 +++++++++
>>> .../clock/mediatek,mt6735-topckgen.h | 79
>>> +++++++++++++++++++
>>> 5 files changed, 167 insertions(+)
>>
>> You should squash it with other part of binding. What is the reason
>> behind splitting one binding into three patches?
>
> It seemed logical to me that each of clock and reset bindings as well
> as documentation would be separate parts especially since they go in
I don't understand. All of these are bindings. What do you mean by
"documentation"?
> different paths, but if combining them is how it's done then sure, I'll
> squash them and resend.
They cannot go different paths and your submissions creates false
impression they can. If you want to see - apply these on separate
branches and test if: driver compiles and paths to files in doc are not
broken. Answer: driver won't compile and paths will point to
non-existing files.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-27 9:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 9:42 [PATCH v3 0/4] MediaTek MT6735 main clock and reset drivers Yassine Oudjana
2023-02-25 9:42 ` [PATCH v3 1/4] dt-bindings: clock: Add MediaTek MT6735 clock bindings Yassine Oudjana
2023-02-27 8:18 ` Krzysztof Kozlowski
2023-02-27 8:29 ` Yassine Oudjana
2023-02-27 9:08 ` Krzysztof Kozlowski [this message]
2023-02-25 9:42 ` [PATCH v3 2/4] dt-bindings: reset: Add MediaTek MT6735 reset bindings Yassine Oudjana
2023-02-27 8:17 ` Krzysztof Kozlowski
2023-02-25 9:42 ` [PATCH v3 3/4] dt-bindings: arm: mediatek: Add MT6735 clock controller compatibles Yassine Oudjana
2023-02-27 8:18 ` Krzysztof Kozlowski
2023-02-25 9:42 ` [PATCH v3 4/4] clk: mediatek: Add drivers for MediaTek MT6735 main clock and reset drivers Yassine Oudjana
2023-02-25 12:05 ` kernel test robot
2023-02-27 8:19 ` Krzysztof Kozlowski
2023-02-27 9:28 ` AngeloGioacchino Del Regno
2023-02-27 10:39 ` Yassine Oudjana
2023-02-27 12:42 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2e43fe8-2072-6723-dbb4-500a6ff8f719@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=allen-kh.cheng@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bgolaszewski@baylibre.com \
--cc=chun-jie.chen@mediatek.com \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=edward-jw.yang@mediatek.com \
--cc=fparent@baylibre.com \
--cc=johnson.wang@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tinghan.shen@mediatek.com \
--cc=wenst@chromium.org \
--cc=y.oudjana@protonmail.com \
--cc=yassine.oudjana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).