From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 623A6C54EE9 for ; Tue, 13 Sep 2022 08:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DAVnPUsBsI2/cJw7sF260o2w2X8O1OkowMaM8UU6EM8=; b=PxNlo/+rCTD6Bp b14EH5stZlYLDzghBUd4S6esKuZXKiIroSAU4CP6YXSP7G6qXrKlu2aLHf3MSAGvfkFq3+T+LxDiU k15yI8zLzq5Q3LNnxh74v/YMCJow+5s5HacWekYYGb9cqqvxtthjcQohVJyzlWX8qytDJP4p35Px1 C+vIdxSZS0N6f1qRmlwyMs5Z85qSl9Fh3khMHn9CjKg2+/h0ytZOFNP+0suv/S+x5u/lJWjhZ4R4g /9OfHPX1s6+yV79ffBFFT+UFGoLQ+k27HFz3BooLM5ytqgx0CIe8mMZAC7lCs1MHkBr0mNeshKrry Bv4pkOPg6MXMN2WP/opA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY1Ya-004aRX-PU; Tue, 13 Sep 2022 08:46:13 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY1XI-004Zf4-7h for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 08:44:53 +0000 Received: by mail-wr1-x42b.google.com with SMTP id t7so19535932wrm.10 for ; Tue, 13 Sep 2022 01:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=FZVlunLlsLup+p0bI6QeJ/RYwaTVchuEcmhidvQoejo=; b=kGbIXxFn248s5nHz45P6zHNJW7wMKw4UuALZcV4uPLjbNXuN5nj379TTa5FLLkyNsf q2wrH6TX6hyS1BksUxlPprxthHCwrvt7TR9BRePqeSur77r6cEVFSZPbQomcezasWWgf th24b8xfsFYpSfaPNqL8uHGV1UA3yLH2ZKhLh4KHfYZZretdGgkhVNUBEvd38XI9WB91 wEFcu0TTwNgwmDC2z2/HtY+7Z1wEraLgP12icYpOyEPmpVCcpFBftXv20TE2hdkTQu/s 1aw6W1Et6FXYyFCJEibOe5XmJvU9fqWcxqkD2ypK6W609SU5UJxYCLbtAStHKKDCaR1S CIhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=FZVlunLlsLup+p0bI6QeJ/RYwaTVchuEcmhidvQoejo=; b=0J6CSw2xAobzSaKx87Ia3rviVwwEUvWaLlKy9DMBpO2eZGQkJC659XMLv4Afrpsavc tpqVhFRNNRPNDv3yHuU2GUOsBGEenY64a78S0suw6tytCa3fr1OdM5HdTsYgd5fEJl4y EOxGbPEk5VUzeHmZwx1b+nXOIB0qn3rNIzSvnLJMeYPJ8i2jjYYh9GbkZQ2QwGGLQyfZ FbPtSmnD424Vj3DmAqmSlTuE71iaKoudcazfzQXyukoEdLbpgumNdpxDLLuEqIIt1jLw 3KXk1AiL66gMfMxH1mHn73Vh154FGaefrFeqBZP/QBZNIOKyHhQvlA2ZeTpmAcGDdHZo Gjtw== X-Gm-Message-State: ACgBeo2EpL5oNCilIIt2Ys5X5WdHueH5p1rPI7hA+tQ2qac4fecpMmnU TW68xF1JriKe/yMBKrLzmrN7ng== X-Google-Smtp-Source: AA6agR6WhtQN8m38UaEkj0ux7abtkAZ4ZImaPmtJ2jpMlO+urIKvzCnDHmVTHBa4/sB4bFG4oepkgg== X-Received: by 2002:adf:e4ca:0:b0:228:d8b7:48a7 with SMTP id v10-20020adfe4ca000000b00228d8b748a7mr16964661wrm.300.1663058689956; Tue, 13 Sep 2022 01:44:49 -0700 (PDT) Received: from [10.119.22.201] ([89.101.193.70]) by smtp.gmail.com with ESMTPSA id p16-20020a05600c359000b003b486027c8asm7322640wmq.20.2022.09.13.01.44.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Sep 2022 01:44:49 -0700 (PDT) Message-ID: Date: Tue, 13 Sep 2022 10:44:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [EXT] Re: [PATCH v6 5/5] arm64: dts: freescale: add support for i.MX8DXL EVK board Content-Language: en-US To: Shenwei Wang , Shawn Guo Cc: Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Pengutronix Kernel Team , Peng Fan , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "imx@lists.linux.dev" , dl-linux-imx References: <20220822175245.222691-1-shenwei.wang@nxp.com> <20220822175245.222691-6-shenwei.wang@nxp.com> <20220903034819.GF1728671@dragon> <20220912081649.GR1728671@dragon> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_014452_355484_93042D5A X-CRM114-Status: GOOD ( 12.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/09/2022 16:35, Shenwei Wang wrote: >>>>> + gpio = <&pca6416_1 11 GPIO_ACTIVE_HIGH>; >>>> >>>> Missing enable-active-high? >>> >>> No. Enabling this regulator to select the fec1 interface instead of usdhc2. >> Pulling this GPIO pin to low is to use FEC1 interface. >> >> Then the polarity cell should be GPIO_ACTIVE_LOW rather than >> GPIO_ACTIVE_HIGH? >> > > That doesn't matter since any GPIO phandle flags are ignored in the node of "regulator-fixed". The final flag is only determined by the property of "enable-active-high". If there is a "enable-active-high", the GPIO line works as active high. If no such a property, it works as active low by default. Right? No. Your flags must match hardware, even if bindings also expect enable-active-high. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel