From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6277DC433DB for ; Wed, 27 Jan 2021 18:00:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04EBE64D9F for ; Wed, 27 Jan 2021 18:00:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04EBE64D9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lx5/qdOT7dNyMjE3ss8VFgUa7vYFL6pgUOkj71AqzP0=; b=HTgtxDTq3bxVc6jMLRK9QmWYu fDcHDPaDsdwWmz+vJiLMEtyNcX5t7Vl4qBf9NuFPcqpVQxbqIbcmtd8L6ZFkgL9WA4Z/ZCHy817WP Sa5q7F/3GWGPbjxhdiQIxgsPzxa2Q+kP7RkFt7ZxlxEGes0nnKZMVr+Hx/f/oavXCjYmTrEgxOOqb /ipIqIgKx37axBKQqFprt9WftBgkuR1Fha8rlxpsIj/sKcoc/yjxBQO6WpjN6g4R9u0lczZHOaPrf vEe0yfwchaP2iPZK2zDwOG+Po6OmIkzy8JTKEiFaMbQvjicEpzGgusJUfQCpabzJS3MK2LPEyghSD u2pMzDYXw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4p6X-0006pE-Fn; Wed, 27 Jan 2021 17:59:45 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4p6S-0006nr-0u for linux-arm-kernel@lists.infradead.org; Wed, 27 Jan 2021 17:59:41 +0000 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 8887120B7192; Wed, 27 Jan 2021 09:59:38 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8887120B7192 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1611770379; bh=u6YDtCnPbqCR0gis78ss8Y7oDmOQBhIrTOjdneH59BY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=I8l5HtBlTBedrIQBGerHNcZYLR35V9yPxqkGcZTZfVC0F5ANK7kYqJko9VbWh+e4B WyL8zYfK6cVs+7f5JIUpGAoDBqNXBX/k77L3StP9OpEO0arTI6RNBm0OBKhV02U7da 3QrrsCCB5/Mu3bh4h0E8igoAVJJmAiIbLxoo4p9A= Subject: Re: [PATCH v15 09/10] arm64: Call kmalloc() to allocate DTB buffer To: Will Deacon References: <20210115173017.30617-1-nramas@linux.microsoft.com> <20210115173017.30617-10-nramas@linux.microsoft.com> <20210127165208.GA358@willie-the-truck> From: Lakshmi Ramasubramanian Message-ID: Date: Wed, 27 Jan 2021 09:59:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210127165208.GA358@willie-the-truck> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_125940_293168_C8C12120 X-CRM114-Status: GOOD ( 18.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, benh@kernel.crashing.org, bhsharma@redhat.com, tao.li@vivo.com, zohar@linux.ibm.com, paulus@samba.org, vincenzo.frascino@arm.com, frowand.list@gmail.com, sashal@kernel.org, mpe@ellerman.id.au, masahiroy@kernel.org, jmorris@namei.org, takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, serge@hallyn.com, devicetree@vger.kernel.org, pasha.tatashin@soleen.com, prsriva@linux.microsoft.com, hsinyi@chromium.org, allison@lohutok.net, christophe.leroy@c-s.fr, mbrugger@suse.com, balajib@linux.microsoft.com, dmitry.kasatkin@gmail.com, linux-kernel@vger.kernel.org, james.morse@arm.com, gregkh@linuxfoundation.org, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/27/21 8:52 AM, Will Deacon wrote: Hi Will, > On Fri, Jan 15, 2021 at 09:30:16AM -0800, Lakshmi Ramasubramanian wrote: >> create_dtb() function allocates kernel virtual memory for >> the device tree blob (DTB). This is not consistent with other >> architectures, such as powerpc, which calls kmalloc() for allocating >> memory for the DTB. >> >> Call kmalloc() to allocate memory for the DTB, and kfree() to free >> the allocated memory. >> >> Co-developed-by: Prakhar Srivastava >> Signed-off-by: Prakhar Srivastava >> Signed-off-by: Lakshmi Ramasubramanian >> --- >> arch/arm64/kernel/machine_kexec_file.c | 12 +++++++----- >> 1 file changed, 7 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm64/kernel/machine_kexec_file.c b/arch/arm64/kernel/machine_kexec_file.c >> index 7de9c47dee7c..51c40143d6fa 100644 >> --- a/arch/arm64/kernel/machine_kexec_file.c >> +++ b/arch/arm64/kernel/machine_kexec_file.c >> @@ -29,7 +29,7 @@ const struct kexec_file_ops * const kexec_file_loaders[] = { >> >> int arch_kimage_file_post_load_cleanup(struct kimage *image) >> { >> - vfree(image->arch.dtb); >> + kfree(image->arch.dtb); >> image->arch.dtb = NULL; >> >> vfree(image->arch.elf_headers); >> @@ -59,19 +59,21 @@ static int create_dtb(struct kimage *image, >> + cmdline_len + DTB_EXTRA_SPACE; >> >> for (;;) { >> - buf = vmalloc(buf_size); >> + buf = kmalloc(buf_size, GFP_KERNEL); > > Is there a functional need for this patch? I build the 'dtbs' target just > now and sdm845-db845c.dtb is approaching 100K, which feels quite large > for kmalloc(). Changing the allocation from vmalloc() to kmalloc() would help us further consolidate the DTB setup code for powerpc and arm64. thanks, -lakshmi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel