From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD486EB64DD for ; Wed, 5 Jul 2023 06:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iRCYtFKeqfrjuJ8ZGOqQZjWkzotD1Ps+zecZx6ciUdo=; b=pm1imILvN8xqND NgkqWI0VlIhZ11aiCAVKTMmmeetKOdkrwtzOPLVEPet+lSSly7GUxNUsE/z73UHDA3zP83KovYG8P JvKe2yNFQCCEMa8zfWu2S2TePRJtGuFvkAGDwH7mF6uk9scFsceZGtGF1yL5Ti/M6bz0tvxjlFzx2 67XkIlmKLgB+NfmhShOsxIbqdS05fsceCvoKhrg8ZZTgKbC4ohrfCK8o5gEObNuajA94DLWlERe2g OSgTY9p9ZRrsJ9+MizhWm4ea4+dxNbnAxyJueTjfOhVCTzgcXBe97tnx2r7+99nTp4d790KHVBQdd So1qw4R6kY1ap/6M756g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGvpF-00EscM-2w; Wed, 05 Jul 2023 06:17:17 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGvpB-00EsbF-0p for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 06:17:14 +0000 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2b5c231c23aso101950461fa.0 for ; Tue, 04 Jul 2023 23:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688537829; x=1691129829; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=90vFHFNv8Z4EnqFJciqEXi399O0ahUbhYDsrlxPDfUA=; b=ZmcAsyvfEgsv3Kwm+U6DlC5Ix5sl36izoQPtKwWwQXUXXk9e96NWXqqiH/MdmdOQ68 6Y+kREJdwA7kgrbS+bngxnH+GlQfk/5CvT4xdIbRB8j0e9JsV5KwoLN4h3w4XeVrPOZ9 gyopY24vIoXs2o/zSgUQJO189T7kUPedathiv/f1g4jMjrWmJTTsrwIuoM36YCk4epoK 3qtnWlIf12SBeOj7oQ1uxCrRsUkLVuE1VzzGPYF/nditBmMYJ2kca1xN+Xl3xlpwHCJd iF0A6izZqoI/LQL0dwhehqI/cgJnzGT/EjBz3nXouh5WwOSXCIM9ILveifP2hrDqEh7P CbOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688537829; x=1691129829; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=90vFHFNv8Z4EnqFJciqEXi399O0ahUbhYDsrlxPDfUA=; b=c+LNH8Dj2Gav70I2EFTXiEzPAWFjPTj18EbpTzp6JCpP0FtjI4kLTPtJaSMa++cEZx y/Q+b5OGA68Qrpx1+8/ib4MReFPU4iDpWyrV/O+r0neu8NpdVyYUBgAaho7XX3LcUaZ7 HSmrQNxBfvG+D10MDcmdNzIomIlfKrgWs4p6582gCBjRzyi4QovCZDmhXOuJkYW8sCkp XHO2YT6yWuo+pILb2BQDl95zKm3bP9ctuePH/fWWUsvYroLfxpfZTSkj/XXjRJoKPFug 9/lnLrlYqh40xhzdpekiWjitU49U/ZI/2VHY1pqYrHJRs6MbE2oDSJmSegauq2z/xfTr WuJQ== X-Gm-Message-State: ABy/qLY/MNJ+ZKFkD43f5xS9/1tkBOyPe8jaUB8x/4+Td75zLMm/yxB2 yexHM5ExDpxg76/DYtweP+CzkQ== X-Google-Smtp-Source: APBJJlFEGjzSwAu/PuXg2rA//CTojQCgKRBCyvzFiOBPJoQUTeMenTuSrLxZqCx2g7wC+7Wnju1qjA== X-Received: by 2002:a2e:6a0f:0:b0:2b6:cf18:77e0 with SMTP id f15-20020a2e6a0f000000b002b6cf1877e0mr10155024ljc.48.1688537829112; Tue, 04 Jul 2023 23:17:09 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id r19-20020aa7cfd3000000b0051e06693590sm4552748edy.91.2023.07.04.23.17.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jul 2023 23:17:08 -0700 (PDT) Message-ID: Date: Wed, 5 Jul 2023 08:17:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH V7 1/2] dt-bindings: firmware: bootstats: Add the dtschema Content-Language: en-US To: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak References: From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_231713_354802_18333AAB X-CRM114-Status: GOOD ( 21.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/07/2023 07:32, Souradeep Chowdhury wrote: > Add the device tree bindings for boot stats. This has 2 properties > pre-abl-time and abl-time which records the timestamps for boot > stats. > > Signed-off-by: Souradeep Chowdhury > Link: https://lore.kernel.org/linux-arm-kernel/7d397e67-5d56-4975-98af-1ac9746c07f4@app.fastmail.com/ > --- > .../bindings/firmware/qcom,bootstats.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/firmware/qcom,bootstats.yaml > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,bootstats.yaml b/Documentation/devicetree/bindings/firmware/qcom,bootstats.yaml > new file mode 100644 > index 000000000000..22e697524058 > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/qcom,bootstats.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/qcom,bootstats.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Boot Stats This explains nothing... > + > +maintainers: > + - Souradeep Chowdhury > + > +description: | Drop | > + Qualcomm's proprietary Android boot-loaders capture boot time Wrong indentation. > + stats, like the time when the bootloader started execution and > + at what point the bootloader handed over control to the kernel. > + This is captured in the unit of ms in devicetree property. > + > +properties: > + pre-abl-time: > + description: The property to store the starting point of abl in ms. String instead of ms? No, this is the craziest idea I saw recently. Use -ms suffix. > + $ref: /schemas/types.yaml#/definitions/string-array > + > + abl-time: > + description: The property to store the duration of abl in ms. > + $ref: /schemas/types.yaml#/definitions/string-array I have no clue what this entire binding is about. Nothing can bind to it, no usage explained. Properties are not used to "store the duration". This does not look like suitable for DT, drop entire binding. > + > +required: > + - pre-abl-time > + - abl-time > + > +additionalProperties: false > + > +examples: > + - | > + bootstats { > + pre-abl-time="17627"; > + abl-time="26748"; Missing spaces. Open existing DTS and look at existing coding style. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel