From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24397C3DA49 for ; Sun, 14 Jul 2024 13:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XhhF2kOObaWSpTUE3FHoWYSAyXxA8qZtiRUXKka5xPk=; b=X8TRScKZcuBBZp5l+ZqTcpuD6V 20EHqMgOnXPB/JTYnCVIuCDWYCZ3IsKDJWgfp/Sb6uA6kcy95AJhamUPGhGfEe6XkYCqxnHXnrqjB TiFTZ0HkX3C6CrAFGwr90xSdoJIPl+32lRCiHl2qYqzNNQbQheCIgkPoiOC/EEIKlxVQa3zBCIrPw K0JYYwnAKQUg2bTY6tiHJNjTBM6LVZtgLRZUIndOLU9L9GtbNzI+KAxe3WGtzFNuOZDVkEJOLR1MJ pGTWk4GBCqGHA144BItV+k1yegKC3jGwxBf1Jvp3CBMr05hpLP7XEKE2oyHTR1f4OUFo6wJjJKTcb JKBeHgrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSzYr-00000004YmT-2QRj; Sun, 14 Jul 2024 13:46:45 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSzYY-00000004YiY-2Lrx for linux-arm-kernel@lists.infradead.org; Sun, 14 Jul 2024 13:46:28 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-427ad8bd88eso1516525e9.2 for ; Sun, 14 Jul 2024 06:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1720964785; x=1721569585; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XhhF2kOObaWSpTUE3FHoWYSAyXxA8qZtiRUXKka5xPk=; b=KkMm7KhcZj1Lvmuq4fLq5iSbTOwM9NTSJkvseN/Wt/N4JbNN6WOERwAMn8YXZMDNJe H0mYUqn+8g8KZiwA3gRzGp114BQwMd4ZwIdjDInHmBzlUzh4B2eMlEqJJcxMrrew54P2 w0s6KrxMzINaQJ0nU+CIoljj5OgwTfqDJ8Ca91wqIp5voCr0GzTKg7T8/T4pkF1JCYWF r0gGsKRzPLDjIjsQdKKXZ4Ce5kaYPFYHTHKz/efHM3Y5TINK1jgpDGVWlOiKyk1u9NaA QbAnA8AvavrJhVqjoLuFMHdaMWRisfbjtnRbGDbP6CHyZ4U+pNAibFsTSsDncTI8tfib 7IVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720964785; x=1721569585; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XhhF2kOObaWSpTUE3FHoWYSAyXxA8qZtiRUXKka5xPk=; b=fzhFWIZ8cEGRuC/GmPxFcv25NsNDJ363QrBYy2Lu2MA+T3zLM5lbV+wAYnCShouHGw 38v/lVcYcggfW0lkBzW96VzgsQHaNhpXjPlQZbFqZj05W2/SaZ+q4MpBGAbpEWovswuo uC09dDHIgAg5obbEI+YbFfijRL2B1Wj3YjEqAbbgrjh0s8DjYo2WyCd2UvOvYHaDFszO fXMNQ40VJFk94tGs0riItnwh5xnFUtD0I14YpJH8nX8H/9QYNp/fNqBIF7P+8ZX2XPIE 3ILCqNFPVMKhwp33l8/9+pS0UqBLtdqH8/ABTxmngMrlvdQ8vtN0m5hxA5nXojalKMew y7gw== X-Forwarded-Encrypted: i=1; AJvYcCW5qK5Y+CMoKNz5hO2La9RZ5JDz4FhaIpNTIInH+L3X2a4xmInECLh8kkg4gS/NA2UhqT0ZNEHuz+1+1MCVxTg4+Lhf8OR1oJ0xw9kfaE4MYDzR5Jk= X-Gm-Message-State: AOJu0YwjCUWYBMZk6XS7+g2N5G/n2HjDb3FV3QJ+Q/Nqq6RxlWTzkrX3 KRq93HCKGFHczjjg27QbXXXvfCuR/ANKPxywI34EoWBgaQwVAfpPR+nYsnihhX0= X-Google-Smtp-Source: AGHT+IF00EL0Y03INAlv8YUqpJscKmmaNb+dyxPLgyZMXltbvzpjzs9gZweXVagxn0t14s0u9qa2RA== X-Received: by 2002:a05:600c:3042:b0:426:6a5e:73c5 with SMTP id 5b1f17b1804b1-426708f1035mr104521085e9.37.1720964784947; Sun, 14 Jul 2024 06:46:24 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.171]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5ef550asm52187375e9.46.2024.07.14.06.46.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jul 2024 06:46:24 -0700 (PDT) Message-ID: Date: Sun, 14 Jul 2024 16:46:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 27/27] ARM: dts: microchip: sam9x75_curiosity: add sam9x75 curiosity board Content-Language: en-US To: Varshini Rajendran , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, mihai.sain@microchip.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240703102011.193343-1-varshini.rajendran@microchip.com> <20240703102943.196655-1-varshini.rajendran@microchip.com> From: claudiu beznea In-Reply-To: <20240703102943.196655-1-varshini.rajendran@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240714_064626_651531_54EC9A89 X-CRM114-Status: GOOD ( 19.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Varshini, On 03.07.2024 13:29, Varshini Rajendran wrote: > Add device tree file for sam9x75 curiosity board. > > Signed-off-by: Varshini Rajendran > --- > Changes in v5: > - Update commit message to match the directory structure. > - Alphanumerically sorted Makefile entries. > - Corrected VDDCore minimum voltage. > - Enabled the i2s node. > - Removed additional blank lines. > - Enclosed each entry with separate <>. > - Corrected pinctrl names to match Microchip convention. > - Enabled slewrate in sdmmc node. > - Corrected pinmux mask. > - Added phandle to leds for ease of access with upcoming device entries. > - Updated gpio pin number for red led. > --- > arch/arm/boot/dts/microchip/Makefile | 3 + > .../dts/microchip/at91-sam9x75_curiosity.dts | 312 ++++++++++++++++++ > 2 files changed, 315 insertions(+) > create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > > diff --git a/arch/arm/boot/dts/microchip/Makefile b/arch/arm/boot/dts/microchip/Makefile > index 0c45c8d17468..470fe46433a9 100644 > --- a/arch/arm/boot/dts/microchip/Makefile > +++ b/arch/arm/boot/dts/microchip/Makefile > @@ -2,6 +2,7 @@ > # Enables support for device-tree overlays > DTC_FLAGS_at91-sam9x60_curiosity := -@ > DTC_FLAGS_at91-sam9x60ek := -@ > +DTC_FLAGS_at91-sam9x75_curiosity := -@ > DTC_FLAGS_at91-sama5d27_som1_ek := -@ > DTC_FLAGS_at91-sama5d27_wlsom1_ek := -@ > DTC_FLAGS_at91-sama5d29_curiosity := -@ > @@ -60,6 +61,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \ > dtb-$(CONFIG_SOC_SAM9X60) += \ > at91-sam9x60_curiosity.dtb \ > at91-sam9x60ek.dtb > +dtb-$(CONFIG_SOC_SAM9X7) += \ > + at91-sam9x75_curiosity.dtb > dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-kizbox2-2.dtb \ > at91-kizbox3-hs.dtb \ > diff --git a/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > new file mode 100644 > index 000000000000..4a4f14f13634 > --- /dev/null > +++ b/arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts > @@ -0,0 +1,312 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * at91-sam9x75_curiosity.dts - Device Tree file for Microchip SAM9X75 Curiosity board > + * > + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries > + * > + * Author: Varshini Rajendran > + */ > +/dts-v1/; > +#include "sam9x7.dtsi" > +#include > + > +/ { > + model = "Microchip SAM9X75 Curiosity"; > + compatible = "microchip,sam9x75-curiosity", "microchip,sam9x7", "atmel,at91sam9"; > + > + aliases { > + i2c0 = &i2c6; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_key_gpio_default>; > + > + button-user { > + label = "USER"; > + gpios = <&pioC 9 GPIO_ACTIVE_LOW>; > + linux,code = ; > + wakeup-source; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + > + led_red: led-red { > + label = "red"; > + gpios = <&pioC 14 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&pinctrl_red_led_gpio_default>; > + }; > + > + led_green: led-green { > + label = "green"; > + gpios = <&pioC 21 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&pinctrl_green_led_gpio_default>; > + }; > + > + led_blue: led-blue { > + label = "blue"; > + gpios = <&pioC 20 GPIO_ACTIVE_HIGH>; > + pinctrl-0 = <&pinctrl_blue_led_gpio_default>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + memory@20000000 { > + reg = <0x20000000 0x10000000>; > + device_type = "memory"; > + }; > +}; > + > +&classd { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_classd_default>; > + atmel,pwm-type = "diff"; > + atmel,non-overlap-time = <10>; > + status = "okay"; > +}; > + > +&dbgu { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dbgu_default>; > + status = "okay"; > +}; > + > +&dma0 { > + status = "okay"; > +}; > + > +&flx6 { > + atmel,flexcom-mode = ; > + status = "okay"; > +}; > + > +&i2c6 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx6_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; > + > + pmic@5b { > + compatible = "microchip,mcp16502"; > + reg = <0x5b>; > + > + regulators { > + vdd_3v3: VDD_IO { > + regulator-name = "VDD_IO"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3600000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddioddr: VDD_DDR { > + regulator-name = "VDD_DDR"; > + regulator-min-microvolt = <1283000>; > + regulator-max-microvolt = <1450000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + }; > + > + vddcore: VDD_CORE { > + regulator-name = "VDD_CORE"; > + regulator-min-microvolt = <1140000>; > + regulator-max-microvolt = <1210000>; > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vddcpu: VDD_OTHER { > + regulator-name = "VDD_OTHER"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3600000>; I haven't got any input on question asked in v4 on the regulator values. Are the values from this version the right ones? Is this board supporting DVFS or the label name is wrong or maybe the min-max range is still wrong? > + regulator-initial-mode = <2>; > + regulator-allowed-modes = <2>, <4>; > + regulator-ramp-delay = <3125>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + regulator-mode = <4>; > + }; > + > + regulator-state-mem { > + regulator-mode = <4>; > + }; > + }; > + > + vldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + regulator-always-on; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + > + vldo2: LDO2 { > + regulator-name = "LDO2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3700000>; > + > + regulator-state-standby { > + regulator-on-in-suspend; > + }; > + }; > + }; > + }; > +}; > + > +&i2s { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2s_default>; > + #sound-dai-cells = <0>; > + status = "okay"; > +}; > + > +&main_xtal { > + clock-frequency = <24000000>; > +}; > + > +&pinctrl { > + classd { > + pinctrl_classd_default: classd-default { > + atmel,pins = > + , > + ; > + }; > + }; > + > + dbgu { > + pinctrl_dbgu_default: dbgu-default { > + atmel,pins = , > + ; > + }; > + }; > + > + flexcom { > + pinctrl_flx6_default: flx6-default { > + atmel,pins = > + , > + ; > + }; > + }; > + > + gpio-keys { > + pinctrl_key_gpio_default: key-gpio-default { > + atmel,pins = ; > + }; > + }; > + > + i2s { > + pinctrl_i2s_default: i2s-default { > + atmel,pins = > + , /* I2SCK */ > + , /* I2SWS */ > + , /* I2SDIN */ > + , /* I2SDOUT */ > + ; /* I2SMCK */ > + }; > + }; > + > + leds { > + pinctrl_red_led_gpio_default: red-led-gpio-default { > + atmel,pins = ; > + }; > + pinctrl_green_led_gpio_default: green-led-gpio-default { > + atmel,pins = ; > + }; > + pinctrl_blue_led_gpio_default: blue-led-gpio-default { > + atmel,pins = ; > + }; > + }; > + > + sdmmc0 { > + pinctrl_sdmmc0_default: sdmmc0-default { > + atmel,pins = > + , /* PA2 CK periph A with pullup */ > + , /* PA1 CMD periph A with pullup */ > + , /* PA0 DAT0 periph A */ > + , /* PA3 DAT1 periph A with pullup */ > + , /* PA4 DAT2 periph A with pullup */ > + ; /* PA5 DAT3 periph A with pullup */ > + }; > + }; > +}; /* pinctrl */ > + > +&rtt { > + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; > +}; > + > +&sdmmc0 { > + bus-width = <4>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sdmmc0_default>; > + cd-gpios = <&pioA 23 GPIO_ACTIVE_LOW>; > + disable-wp; > + status = "okay"; > +}; > + > +&slow_xtal { > + clock-frequency = <32768>; > +}; > + > +&poweroff { > + debounce-delay-us = <976>; > + status = "okay"; > + > + input@0 { > + reg = <0>; > + }; > +}; > + > +&trng { > + status = "okay"; > +}; > + > +&watchdog { > + status = "okay"; > +};