From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6123FC54E49 for ; Mon, 4 Mar 2024 07:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cro7uCyBa+b6/tEbgu/fvp9+x7UWpQUXtycIA6xjivA=; b=m1ehP9geSjRQIJ XKMItG1ZPI85W0QerFLy3PSydhZW/cgrNL6M3l0Pva9VT6/w82QqfzbVijniRqlAfL3DOBALwkb0r vmPt8CpN5pcrZf/NVvEr43MOaoZS0+MG3mM4xY0RRgtana4zwRZsMeCybzb02HOe7VI1a3JnqTaMU Tbl1kTl8Nhlnp7f9kOfl/1iPwB2fNvHwBuhXQF5jz5MNaYU/wm8IbPV5bgWgLZ0TZC7jl/AwbE8Xq /JZ4DtWwHDWpaijrjRiUEqknGLznL7uO4DHR6g6D2xDlqoW1vHOdDs7L7OieHj/NolSAdNKPc11l+ pL/ROkEZ610WOML+bH6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh2nd-00000007xY0-3M1A; Mon, 04 Mar 2024 07:31:49 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh2na-00000007xVT-0Biw for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2024 07:31:48 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-412e66bc492so1243175e9.0 for ; Sun, 03 Mar 2024 23:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709537504; x=1710142304; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=f51VA5MtxnAU0efzg76cN/fIARzVpps0Hh4Af04eUTk=; b=H5TnBwr4sb4dff37sMHuZvo9ysr2DEvP6t2Qii+xedsEhN0SiHowEIL4bMgc4YY0OR BP4Ri6+ESgFM0xA+XLVxHwglGhwe/SMXQh4gqgdkqw1r0JftDuuTfPztu9WVjYFLKfdO KNmRE/9Cl554m7G0W9s0IwnnEOVsLj4QXnZtMB0KZE+ddMPMolpHaJjz0m6HxExbw5aG b6/BBVXG0QfpGYRah1GMQ8jFHJ+digYAwypJKtabr6GABWyxTvEv5Z9L6JnCvAIfGgVQ ojVYXYBB12/3336Lbp2ORr2Frjz+5Ltb/s/ZeKyMAsSf2lUjn4xZ1QwJhIPixHweJ6W0 PwHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709537504; x=1710142304; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f51VA5MtxnAU0efzg76cN/fIARzVpps0Hh4Af04eUTk=; b=fxKcyu6+GdNqNKm+JQa8CY9hIhmuvzdiAGJQUZ4yS7AF0EUYkn8L9sg/3sB2gXWebr +qKfkR5iWHKrJV+aeoCCaPUkj5VptW7Fu3okl9IRdKd0T6ZNJ3nTyNSvfTBTcXrTxSht FRj63fUQogaPtnrd4fKBMMjVMixfys9YurY3Jc2XEtn+b4oHXcxUm6EXsJyWo1GhvXi3 K5fH6JBlX1Dah8HrrUVfjUTIN05VE3B+FyfGfFJFlsilLwvI31/wcU6aCviec5CPvNIv k7q6I1OdDGHVvVleWN7d/NzjbGCLtLhATimKH/a73FH2HrZ7BUtdSpGHd0AbXHcp6GB0 hhbg== X-Forwarded-Encrypted: i=1; AJvYcCVz6pVzvzhWfpVomUZUkpmzFqVBi0Y6+AZeo/3q0IjJxIcI48748SmDielKUAMTF/V9Rw9GjV0B1QAAAwZ8Y1mT4B2wGhJqy+m8Ul2UIfTgCeXOGvQ= X-Gm-Message-State: AOJu0YxJ16vwZBwEIltBFN4ADgHptqU8vIbZrO+S9EgnCY9K9uOu+UC3 ptRG0v7OjC7b0HhDUTUQkzGpiptVVGCKLmBauFsWvKKN6QOKZu7jwCfhlNRN6iI= X-Google-Smtp-Source: AGHT+IH50+zD8hJJZMhOea5o5klj2GNCPU/jhf8hnaytno2hnVtJ77HuPpiGjm37w2PqW+nTVUVZwQ== X-Received: by 2002:a05:600c:470e:b0:412:bcc1:44cc with SMTP id v14-20020a05600c470e00b00412bcc144ccmr6723784wmo.3.1709537503717; Sun, 03 Mar 2024 23:31:43 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id e2-20020a05600c218200b004125f34fd7csm16569261wme.31.2024.03.03.23.31.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Mar 2024 23:31:43 -0800 (PST) Message-ID: Date: Mon, 4 Mar 2024 08:31:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] dt-bindings: fpga: xlnx,fpga-selectmap: add DT schema Content-Language: en-US From: Krzysztof Kozlowski To: Charles Perry , Rob Herring , yilun xu Cc: mdf , Allen VANDIVER , Brian CODY , hao wu , Tom Rix , krzysztof kozlowski+dt , Conor Dooley , Michal Simek , linux-fpga , devicetree , linux-kernel , linux-arm-kernel References: <20240221195058.1281973-1-charles.perry@savoirfairelinux.com> <20240221195058.1281973-3-charles.perry@savoirfairelinux.com> <4a9f0eef-590b-45df-92bc-b63ad9282e18@linaro.org> <1012793477.1508198.1709486517581.JavaMail.zimbra@savoirfairelinux.com> Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240303_233146_263173_416CE450 X-CRM114-Status: GOOD ( 28.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/03/2024 08:30, Krzysztof Kozlowski wrote: > On 03/03/2024 18:21, Charles Perry wrote: >> On Feb 27, 2024, at 3:10 AM, Krzysztof Kozlowski krzysztof.kozlowski@linaro.org wrote: >> >>> On 21/02/2024 20:50, Charles Perry wrote: >>>> Document the SelectMAP interface of Xilinx 7 series FPGA. >>>> >>>> Signed-off-by: Charles Perry >>>> --- >>>> .../bindings/fpga/xlnx,fpga-selectmap.yaml | 86 +++++++++++++++++++ >>>> 1 file changed, 86 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/fpga/xlnx,fpga-selectmap.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/fpga/xlnx,fpga-selectmap.yaml >>>> b/Documentation/devicetree/bindings/fpga/xlnx,fpga-selectmap.yaml >>>> new file mode 100644 >>>> index 0000000000000..08a5e92781657 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/fpga/xlnx,fpga-selectmap.yaml >>>> @@ -0,0 +1,86 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/fpga/xlnx,fpga-selectmap.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Xilinx SelectMAP FPGA interface >>>> + >>>> +maintainers: >>>> + - Charles Perry >>>> + >>>> +description: | >>>> + Xilinx 7 Series FPGAs support a method of loading the bitstream over a >>>> + parallel port named the SelectMAP interface in the documentation. Only >>>> + the x8 mode is supported where data is loaded at one byte per rising edge of >>>> + the clock, with the MSB of each byte presented to the D0 pin. >>>> + >>>> + Datasheets: >>>> + >>>> https://www.xilinx.com/support/documentation/user_guides/ug470_7Series_Config.pdf >>>> + >>>> +allOf: >>>> + - $ref: /schemas/memory-controllers/mc-peripheral-props.yaml# >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - xlnx,fpga-xc7s-selectmap >>>> + - xlnx,fpga-xc7a-selectmap >>>> + - xlnx,fpga-xc7k-selectmap >>>> + - xlnx,fpga-xc7v-selectmap >>>> + >>>> + reg: >>>> + description: >>>> + At least 1 byte of memory mapped IO >>>> + maxItems: 1 >>>> + >>>> + prog_b-gpios: >>> >>> I commented on this and still see underscore. Nothing in commit msg >>> explains why this should have underscore. Changelog is also vague - >>> describes that you brought back underscores, instead of explaining why >>> you did it. >>> >>> So the same comments as usual: >>> >>> No underscores in names. >>> >>> Best regards, >>> Krzysztof >> >> Hello Krzysztof, >> >> Yes, I've gone full circle on that issue. Here's what I tried so far: > > And what part of the commit description allows me to understand this? > >> >> 1) Reuse the same gpio names: Duplicates errors of the past, Krzysztof >> doesn't like it. >> 2) Different gpio names for new driver only: Makes the driver code >> overly complicated, Yilun doesn't like it. > > That's a new driver, right? So what is complicated here? You have new > code and you take prog-b or prog_b? > >> 3) Change gpio names for both drivers, deprecate the old names: Makes >> the DT binding and the driver code overly complicated, Rob doesn't >> like it. > > I don't think I proposed changing existing bindings. > >> >> I think that while the driver code shouldn't be the driving force for >> the DT spec, it can be a good indication that the spec is unpractical to >> implement. > > What is impractical in implementing this? You just pass either A or B to > function requesting GPIO. Just choose proper name. > >> >> In this case, there are two interfaces on a chip that uses the same GPIO >> protocol, it would only make sense that they use the same names, this >> discards solution #2. > > I don't understand this. You have devm_gpiod_get() in your new code. Why > is it difficult to use different name? And I forgot to emphasize: none of these is mentioned in commit msg, so for v5 you will get exactly the same complains. And for every other patch which repeats the same and does not clarify caveats or exceptions. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel