From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72585C4727D for ; Wed, 23 Sep 2020 08:20:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21225235FC for ; Wed, 23 Sep 2020 08:20:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QrACWIGF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="YnWzkV9s"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="kCVoSNdr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21225235FC Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:MIME-Version:Content-ID:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Cc:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=crg3aJgDru74e3kiCYzNpBj9zESY/GWQbrFEf0Xa7kc=; b=QrACWIGF916EaHuqLju8oLkvWY Ayxlq9UqnTGq87NS3c66CPH8Oq53AFaNPNzgr5GkBbjdbSFHgW9l51LU0h5I7gKmjC0zZJn3B62Qf rzPvnKtxMCJ/oPeqJuG3uw8ypxOSP0tE0R7ske1nz4VVw8f6Mg/ODE6kzCpIJtPZDSha/Nv19rk+/ 02QQ1uCBxPcf1WYow0fZrMM+6kbexdiB+VSN9Pj6xrhohYG0m4kOsea1RFWo3vgQLW12rS7FVd5zf aHg6HxafQF3v73Yt1EMzR8zQfX9rtKy7Ay9LnqbdNZ7Yaj0MF7GamXmfs6ecWVEq7hB08Yev5K/zW G6iWOWVw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKzzr-0004I8-JH; Wed, 23 Sep 2020 08:19:27 +0000 Received: from esa5.microchip.iphmx.com ([216.71.150.166]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKzzo-0004HO-BD for linux-arm-kernel@lists.infradead.org; Wed, 23 Sep 2020 08:19:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1600849165; x=1632385165; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=xBKncXJfs7jkT9IKyaGYpfbkEAdQ3l0RzchMk4OXCiA=; b=YnWzkV9sAP64wTEc0kcR1YywmdCK82QcoIVxYv6rhF8BsLipCI+9T7xT +RZ8yCehulIbJyPhGiD8QFcwsFqLXrHlxc7dSXK2XiXf2rjN1y2Mxdu/2 qt9cvAxbD/1Ks3L1UZ9GJlfjhl1gCzTusdESf+VXa3NgbvA4sljmGDA5e +NqS9Oa2Jt9WKtPWqHav4/8MWvUBt+criS9vC0rW0hcsWtSYwvFCZB/nP W6PQLRBFbDT8TbYvdn7jd0g00kWUx0p0BB+2OE7MNhEDxg654W9x396pX lUC+9JX29mjO5sGq0bO1hwJtoQC4TH+k6GkQ/mv13fuCAwqgwcuAFgyJX g==; IronPort-SDR: TFgnsiDJhQVAuYOODZqk+U5TzaASoooneeMOjsSby6bcYjwOFgkOp8EImo9cupxgU32tWgrghV yKBiLmfxMQVXulucKYWJ9UHO2Bemf+v4bvw4soW10o1LgvCZ1XLcDwD2Sh/IzmZYet6r/XTHEo CwQ4jEFxWPtcV2KVP2F2OoQ7EGGga15Cd31RSBUK26UpptbQ6qkxDowN0KRo0oCsrCvDrQ0gtM U84dR1BiS1v9cKcITicjGlHS7RmlxUOru8ivTIBtfSqHB94m++IMPn6TeQx4CSnk09XRm49Rlj WKY= X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="92045906" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 23 Sep 2020 01:19:23 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 23 Sep 2020 01:19:05 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Wed, 23 Sep 2020 01:19:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1mx4wvb6hCvb3J7WataYrS0TPmuZulqzj8wfE+QzEEY7ZmuLxPmxMw5q/87kEby1L2fYVvr7xKKzo3TkXDwiCyh7YTWWFBccIEMHQg0uJ+H3Kl4RKz7OqomazcMGmAmmNeoTqvkj7oGYP4SWR1Agw6V0Ng5tCisABFxosedaAtbvJk5gef62VVM5dfD9PUDci+4z6m5UFbg/Zl65KCkkCR81LNOUAQ/s5rU7tDbG/VRseqOV4qcCg86pqiNABJuFWLEpl2bynYaW+8prmnInaXrgh6xDp1VFEyIGYBu4N48+i+IQUZOM0Nvr3mF0UmtGFfV2DcnqM56aVg5M++lwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xBKncXJfs7jkT9IKyaGYpfbkEAdQ3l0RzchMk4OXCiA=; b=fII8GyvknHCd9LXRHUSwHY+PpvrSh2yFBOmP/lx0vUlHJc/6nvNyjbTN1I+DE1XVOdF7ywRTz1HcRzNLocVmnFPUIxyiakIwJsuG8Lo0Aoiw5mft5/MQu836+BZMg7Ka1KXcAJq5LHWpvKA3EldffxlHTsnjDby1VcQRuVC+lvHIyAMUoqRB8Ba54si4xPBOKNf+44V1cPhrrKAzMP282+NGAjlWosdhD7e+8wa0nP+JfRdo6XmNzmiiFf2h8yIV2TZIe3yXYsODvQ1t1D9Ox6WgJf5DFO8EVc5bromEBaW5dpYkpQb1rx4qNbo8b7EMbYNz0fXFMoDy3epTnMX89g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xBKncXJfs7jkT9IKyaGYpfbkEAdQ3l0RzchMk4OXCiA=; b=kCVoSNdrv260vSlNvOtRnxxL1MXyxk3bKGRmenXIv+OgcDNeRG30SE2pZX5GBckd3vqULfGA3hPxaFGH4C0U2B+tBuropei8pV9BVluWwQOZ8KtnZM5uLeaIzshiZ9GquEKIQYi0NkSIGBiZrhhLOsbJ184x/ATpL5MVwj1p1z4= Received: from DM5PR11MB1914.namprd11.prod.outlook.com (2603:10b6:3:112::12) by DM6PR11MB3242.namprd11.prod.outlook.com (2603:10b6:5:5b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Wed, 23 Sep 2020 08:19:18 +0000 Received: from DM5PR11MB1914.namprd11.prod.outlook.com ([fe80::a8e8:d0bc:8b3c:d385]) by DM5PR11MB1914.namprd11.prod.outlook.com ([fe80::a8e8:d0bc:8b3c:d385%11]) with mapi id 15.20.3391.027; Wed, 23 Sep 2020 08:19:18 +0000 From: To: , , , , , , , , Subject: Re: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak Thread-Topic: [PATCH 4.19] dmaengine: at_hdmac: Fix memory leak Thread-Index: AQHWkYFbVNgbQZmRd0SqW2sKLrUKIKl14XKA Date: Wed, 23 Sep 2020 08:19:18 +0000 Message-ID: References: <20200920082838.GA813@amd> <80065eac-7dce-aadf-51ef-9a290973b9ec@microchip.com> In-Reply-To: <80065eac-7dce-aadf-51ef-9a290973b9ec@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: ucw.cz; dkim=none (message not signed) header.d=none;ucw.cz; dmarc=none action=none header.from=microchip.com; x-originating-ip: [82.77.80.152] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e72b6452-8d86-40a6-55fe-08d85f995e43 x-ms-traffictypediagnostic: DM6PR11MB3242: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:1060; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /YQIOIG80Dt69gf6VK3lPGUWLldar9Oa+4jvhXyR9T7OwjeSQFCpeOgtAKJV1Tzjs8Ix0rQ2MfEtd7c0z7pzGVIGMqPzX8+4atGnyP82B3Je5DpO9odR1YCDe746nlVUUgnsW8Cgoo11dG0GR9bld72OiaKHKayoQwc22EbCAYwsRPvVq4L5C9CcIfT1l+lYwybDco19EipmXWY9EYFCPg7DfD2P4L4QbbAjrj4FMEt940rW6kJUdwqXPKPyJNsn5Nl/k45ZYixpTKS0r4u+020itNyq3Y9xajPRRwWlsE76nQ20ZReEM6lPbl9hO+HRyZvVbWUb+FiNzqUWHmJAcyyPkRvARhaHzmB41iRXVZTClvFEAw8DaHuzc+NVeyBip74u5h/hjTrC43TAKmG8SPpG6+kYBQD9eVULRYR1Ie/Ia8hqSseggj6HRIyGgDv9+3PaKCL+c5iK9ZSSRaVOXgNRrKb4R5QidC3nip+BpZh5rsLzhNKCY09vUI/F/kA8 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1914.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(366004)(396003)(136003)(39860400002)(316002)(76116006)(91956017)(83380400001)(6486002)(6506007)(53546011)(31696002)(966005)(66556008)(66476007)(66446008)(66946007)(64756008)(26005)(2616005)(5660300002)(31686004)(186003)(6512007)(478600001)(71200400001)(8936002)(110136005)(2906002)(8676002)(36756003)(86362001)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: NcpsxQBE+TYOG5a6+ggywucfDRIDzqfTDIFTRCtoUmlIMuoZK2YSjX+nDrqoyNV8u0cS9dKxqntcU2gOEEvzCHJVviSOuf3ctZ7WVdFZOc/ey3pb73K0W6XLyMCK0ueS+ZNzLM9K+2Q2jiekKiFiLpL2P8DrXPe4SithxkT3uwmBkpX68WYnUVsPCz7MXS2KP77KljjJ4pbEGZ34j0wMJPHVvoFY7YM4XylMrcnMrV1rnqz3id4i722CGXIT/L4j/nBozmn5dc+gfGR6yxReJOiZN+mtdqm+JNYoDQyg8hoP2Pr1N+FBo74DC7qbxPbUE9yKn30FNl+cwVDn3O0VCVULRDG+ooBRaPSdsSlRSYbmNUBpPLHam/vm1Zjf44e+zWL6GxCp/sKQQIc4Zxz3YjyKnQNJj/xAyoy+n14eM6MsbsYvoqYwVv9Ylobo9fu/N0jjUWBagx2DgM4PILxE0AIJ8WOrEWrWPfMr/6mAD5bwI+ITAoS3egwwDYMA2kGPIeo3J97O4l1QBMVsSHPpiZwcbr4tWB5a70AFEJvruRwc8yEnJuMhUz8QIVZaI6WfZ2lIKmnIejsHXmBglNbY/g9hQMTPvX+cAGNQwVYgbLvlk5ZpBXB1i/D1M5bQB34Ou+n1GH+5a5fgyY8xa9vhFA== Content-ID: <6AA6864DB4269345923148A64EA6C76C@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1914.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e72b6452-8d86-40a6-55fe-08d85f995e43 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2020 08:19:18.7192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jY2r74yss+lwBhUy/uV8zP0eehRpdCqKK15IZycdcq7E/UpArI7QQYKe6/thiv8nQBBq/cS3MWxwQxLQKeRMcevtGA2UieFYOnBp+EzVdck= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3242 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_041924_543379_EF898E6B X-CRM114-Status: GOOD ( 23.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/23/20 11:13 AM, Tudor.Ambarus@microchip.com wrote: > Hi, Pavel, > > On 9/20/20 11:28 AM, Pavel Machek wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> This fixes memory leak in at_hdmac. Mainline does not have the same >> problem. >> >> Signed-off-by: Pavel Machek (CIP) >> >> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c >> index 86427f6ba78c..0847b2055857 100644 >> --- a/drivers/dma/at_hdmac.c >> +++ b/drivers/dma/at_hdmac.c >> @@ -1714,8 +1714,10 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec, >> atslave->dma_dev = &dmac_pdev->dev; >> >> chan = dma_request_channel(mask, at_dma_filter, atslave); >> - if (!chan) >> + if (!chan) { >> + kfree(atslave); >> return NULL; >> + } > > Thanks for submitting this to stable. While the fix is good, you can instead > cherry-pick the commit that hit upstream. In order to do that cleanly on top > of v4.19.145, you have to pick two other fixes: > > commit a6e7f19c9100 ("dmaengine: at_hdmac: Substitute kzalloc with kmalloc") > commit 3832b78b3ec2 ("dmaengine: at_hdmac: add missing put_device() call in at_dma_xlate()") > commit a6e7f19c9100 ("dmaengine: at_hdmac: Substitute kzalloc with kmalloc") this last commit should have been commit e097eb7473d9 ("dmaengine: at_hdmac: add missing kfree() call in at_dma_xlate()") bad copy and paste :) > > There are also some locking/deadlock fixes in mainline for this driver, > depending on the time you can allocate for this, the list of patches can increase. > I should have Cc'ed stable@vger.kernel.org in the first place, my bad. > > Also it may worth to read the rules for submitting to stable at: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > Cheers, > ta > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel