From: Nicolai Buchwitz <nb@tipi-net.de>
To: aiyengar1990@gmail.com
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
LABBE Corentin <clabbe.montjoie@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev,
Russell King <rmk+kernel@armlinux.org.uk>,
stable@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] net: stmmac: Limit the MTU of normal descriptors to one buffer
Date: Sun, 22 Nov 2026 17:27:10 +0100 [thread overview]
Message-ID: <d3af70f9334370a1d32511504aa14725@tipi-net.de> (raw)
In-Reply-To: <20261122-sun8i-emac-mtu-limit-v2-1-c4081e5b83cf@gmail.com>
On 22.11.2026 10:13, Arun Iyengar via B4 Relay wrote:
> From: Arun Iyengar <aiyengar1990@gmail.com>
>
> Russell King noted in [1] that max_mtu for normal descriptors,
> SKB_MAX_HEAD() (3712 on arm64), does not match the hardware. Their
> buffer sizes are 11 bits, and stmmac neither splits TX frames nor joins
> RX descriptors for them, so a frame must fit one 2047-byte buffer.
AFAIU TX does split (jumbo_frm() in chain_mode.c).
This makes RX the real limit as ndesc_get_rx_status() drops a frame that
spans more than one descriptor. Please say that instead, it should also
answer Chen-Yu's question about hardware vs driver?
>
> Limit max_mtu so that a frame with two VLAN tags and the FCS fits.
>
> Link:
> https://lore.kernel.org/r/E1vLJcL-0000000ExBL-0GFe@rmk-PC.armlinux.org.uk
> [1]
> Fixes: 48febf7e6476 ("stmmac: allow mtu bigger than 1500 in case of
> normal desc (V4)")
> Cc: Russell King <rmk+kernel@armlinux.org.uk>
> Cc: stable@vger.kernel.org
> Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>
> [...]
Thanks,
Nicolai
next prev parent reply other threads:[~2026-11-22 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-22 9:13 [PATCH net v2 0/2] net: stmmac: Limit the MTU of normal descriptors to one buffer Arun Iyengar via B4 Relay
2026-11-22 9:13 ` [PATCH net v2 1/2] " Arun Iyengar via B4 Relay
2026-11-22 16:27 ` Nicolai Buchwitz [this message]
2026-11-22 9:13 ` [PATCH net v2 2/2] net: stmmac: dwmac-sun8i: Limit the MTU to 2018 Arun Iyengar via B4 Relay
2026-11-22 11:39 ` Chen-Yu Tsai
2026-11-22 16:31 ` Nicolai Buchwitz
2026-11-22 16:36 ` Maxime Chevallier
2026-11-22 16:40 ` Nicolai Buchwitz
2026-11-22 16:33 ` Nicolai Buchwitz
2026-11-22 10:48 ` [PATCH net v2 0/2] net: stmmac: Limit the MTU of normal descriptors to one buffer Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3af70f9334370a1d32511504aa14725@tipi-net.de \
--to=nb@tipi-net.de \
--cc=aiyengar1990@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=samuel@sholland.org \
--cc=stable@vger.kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox