From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1570AC3DA5D for ; Mon, 15 Jul 2024 10:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:Message-ID:In-Reply-To:Subject:cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1VDMt6BhM03zaBmAW1YFT8GRu72U5uXIitRTt4yVWtY=; b=ILJV/OBX/zxSDPMCXlNQSBiUqf IUBdKcDrTkZC8A84o0kvpQjmAbvpAcWuaD/IgvJ0+uWdxoTrFZHmdQUr4vSYic76B2BK7Lf32bSVz nd3yZkMfrYVJzR+xSUKa4o8Pdo6aqkX7jRV3YX33iOZP3YJDvnEM5cWa7k363z+iPpewo3iyni4Io +VJzKj2uYwRejWVuDw/ztoNu/F84fmj+leUpgNGvoyXnNlzUha+Gp4QKA9Y26byFRE40JLGjQJpa4 LHTYDtCVEf8MBJMiK/TzEn1WC/Ofvwq3teqM6i66wYvSslbyEyIvG3F3n0pfo4nu2vCVrVuK0v7T/ SARUdFlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTJBx-00000006k9B-1YUv; Mon, 15 Jul 2024 10:44:25 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTJBd-00000006k5D-2WOj for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 10:44:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721040244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1VDMt6BhM03zaBmAW1YFT8GRu72U5uXIitRTt4yVWtY=; b=f2Qwyila8Ylu1t/Dg5xB4Y1EXssxxxWy1Ka58fa8T7oWPErV46NCbCbAmD3xH6woPcNKC/ IhwhfsES/SVFKf0fNp7lHolD14ks9vWyT3JTZZeGByTq9usD4OSMYPFTun/HPVjdaJHaP9 kLD3zPhULX29UKAVHf1HcOJxPhe4w8I= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-Ult-HSnqPz-uuHp5cqxBkA-1; Mon, 15 Jul 2024 06:44:03 -0400 X-MC-Unique: Ult-HSnqPz-uuHp5cqxBkA-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6b5dacdc192so72925276d6.0 for ; Mon, 15 Jul 2024 03:44:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721040242; x=1721645042; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1VDMt6BhM03zaBmAW1YFT8GRu72U5uXIitRTt4yVWtY=; b=a8RwWUPEHGNDcaDfVcRsYM0BNCUaTEccVAGNKIUqmIZO9YppT70dVtUzr1Vsqm5nMX fLZcxCAt9cj5qNgCa46pRJWLrc/tlQ++2fSMbP/oWN6VvvGzrkh0UzTiEs25dYsSECFq 7HWD1roZvMqvvHEu2lpZI4SUqSQK4DN9z88XjFnjTqx0KZGLTv1O/vSuX72akUcvGWhF jxVeK58np8I5fcPjxUuTOeUykvEGq0hcEzYzz5/DbIg+vjORQG0vZ//NPbBb63BB0iDK nu1l2j/kGfA8NWDQ/ezcSrijgWpZrLGZPFYLVer1FUVS23KuswsF/b1bnTtLwG1Wp/cp wE9Q== X-Forwarded-Encrypted: i=1; AJvYcCXMmDVaugm86vqMfBA8h45KbE0xBef2lNYLtokGcmyxp//bHibaNcTececOZIT8wZ1Sv7XjGsbIQn+o5P9rvYjH9CXFEs7F0vHlv+yUNnJH0njxEB0= X-Gm-Message-State: AOJu0YwXvqV46dfljcAT+1B4/8bkWI9RXO8NRGyMzsTTQzvVWONvjjFW l6QWanByMmDrdH142Y79YRrEHuwvEoDXWxaaV0pti9+nWC73Q5HbXZ/ygoD+3IChHjTBRYrj/2h aEu25ARn5a5PkdSpgXWg1gwzcbQw54ne/GM44P1hDfexSkbKzbVmRsa+gsVp458BG61kUtIYF X-Received: by 2002:ad4:596d:0:b0:6b5:2be1:cd6e with SMTP id 6a1803df08f44-6b754b6be33mr172946296d6.4.1721040242543; Mon, 15 Jul 2024 03:44:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrz3doHdIu7jIfoH+wiwb6f5b4GbXN3svlFADmcupRvZiDKcsGzoKyXQkY2C/ZlEeQe0uF7Q== X-Received: by 2002:ad4:596d:0:b0:6b5:2be1:cd6e with SMTP id 6a1803df08f44-6b754b6be33mr172946076d6.4.1721040242215; Mon, 15 Jul 2024 03:44:02 -0700 (PDT) Received: from rh (p200300c93f45e50062e5f8c654844c9a.dip0.t-ipconnect.de. [2003:c9:3f45:e500:62e5:f8c6:5484:4c9a]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b761957786sm20124196d6.14.2024.07.15.03.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 03:44:01 -0700 (PDT) Date: Mon, 15 Jul 2024 12:43:58 +0200 (CEST) From: Sebastian Ott To: Mark Rutland cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Zenghui Yu Subject: Re: [PATCH 1/3] KVM: arm64: fix override-init warnings in W=1 builds In-Reply-To: Message-ID: References: <20240712110332.10970-1-sebott@redhat.com> <20240712110332.10970-2-sebott@redhat.com> <8734oep96j.wl-maz@kernel.org> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII; format=flowed X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_034405_733353_CD5BCCFB X-CRM114-Status: GOOD ( 21.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 15 Jul 2024, Mark Rutland wrote: > On Fri, Jul 12, 2024 at 10:55:16PM +0100, Marc Zyngier wrote: >> On Fri, 12 Jul 2024 12:03:30 +0100, >> Sebastian Ott wrote: >>> >>> Remove double initializations in cases where that's easily possible >>> - like extra NULL initialization in static global structures. In the >>> other cases just silence -Woverride-init. >>> >>> To fix warnings like the following: >>> arch/arm64/kvm/hyp/vhe/switch.c:271:43: warning: initialized field overwritten [-Woverride-init] >>> 271 | [ESR_ELx_EC_CP15_32] = kvm_hyp_handle_cp15_32, >>> | ^~~~~~~~~~~~~~~~~~~~~~ >>> >>> Signed-off-by: Sebastian Ott >>> --- >>> arch/arm64/kvm/handle_exit.c | 5 +++++ >>> arch/arm64/kvm/hyp/nvhe/switch.c | 6 ++---- >>> arch/arm64/kvm/hyp/vhe/switch.c | 3 +-- >>> arch/arm64/kvm/sys_regs.c | 5 +++++ >>> 4 files changed, 13 insertions(+), 6 deletions(-) >>> >>> diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c >>> index d7c2990e7c9e..2c049746657c 100644 >>> --- a/arch/arm64/kvm/handle_exit.c >>> +++ b/arch/arm64/kvm/handle_exit.c >>> @@ -291,6 +291,9 @@ static int handle_svc(struct kvm_vcpu *vcpu) >>> return 1; >>> } >>> >>> +__diag_push(); >>> +__diag_ignore_all("-Woverride-init", "Allow field overrides in exit_handlers"); >> >> The wording you are looking for is "Silence stupid warning". I really >> mean it. There is really nothing wrong with this code, and if the >> compiler doesn't understand the purpose of a default initialiser, then >> *maybe* it should be fixed rather than polluting the kernel with this >> stuff. > > IMO this would be a lot more palatable if this were an attribute on the > struct or assignment, like we asked for in the past: > > https://lore.kernel.org/lkml/20190809083251.GA48423@lakrids.cambridge.arm.com/ > > Having something that we could put specifically on the default assignment would > make this a lot more legible and better capture the intent. Yea, I double checked in the gcc doc - there seems to be no other means to silence this per var or assignment. We can disable that in the makefile for the whole file or dir or we keep it as it is. Thanks, Sebastian