From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Tue, 30 Aug 2016 13:37:29 -0400 Subject: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status In-Reply-To: <20160830170422.GN9355@localhost> References: <1471927691-28827-1-git-send-email-okaya@codeaurora.org> <1471927691-28827-4-git-send-email-okaya@codeaurora.org> <20160830170422.GN9355@localhost> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 8/30/2016 1:04 PM, Vinod Koul wrote: > On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote: > >> spin_lock_init(&lldev->lock); >> - tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev); > > ?? > > This is not described in changlog? If you are not using in anywhere else, > then rst_task variable should be removed too.. > Sure, I can add more description. I thought I did mention that we are no longer resetting the hardware in ISR. I can certainly mention that rst_task variable is removed and can get rid of it. It is no longer in use. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.