From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD34C2D0E4 for ; Wed, 25 Nov 2020 03:31:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C489B20872 for ; Wed, 25 Nov 2020 03:31:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BUyEGvPk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C489B20872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7UZl50SmKE+zwUmcL8UNfXo+0h5w1amlMjV62PwIuaw=; b=BUyEGvPkXB32JdgkN9x1SaWlR i7byy1NU6Iq7FPPQJMP+pTDhQTAmQ8HgiTmSdeZOKGaakj/MNva3FetGiRdjf5Kk1qVuDX6Z3RAI4 m9ACotQW8WHrwTe8aq1j/79QxB6NReQN0/hKlfjtbZMtxJ4P42cUGx0fnFOoUyxVT6gSPSxpdhAa1 XK230jE81M3z8QJ1nBh0njRq9Co0iVv1WsdMtT3slhtgs2Wmm1F3pqXuJI+fe+5L/dF3UZg7ccc5C 1q2r0SZEOsinmu7lAhxCtC20DulxQ8tMkMNLmRjhvVeRkMlarku8ox2QZiBK6S71r7xGAO987aiia 0542GGsJw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khlWZ-00007Q-57; Wed, 25 Nov 2020 03:31:19 +0000 Received: from [2601:1c0:6280:3f0::cc1f] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1khlWU-00006x-ET; Wed, 25 Nov 2020 03:31:14 +0000 Subject: Re: [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix build errors To: Chunfeng Yun , Tiezhu Yang References: <1606211233-7425-1-git-send-email-yangtiezhu@loongson.cn> <1606271044.32484.20.camel@mhfsdcap03> From: Randy Dunlap Message-ID: Date: Tue, 24 Nov 2020 19:31:08 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1606271044.32484.20.camel@mhfsdcap03> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , linux-mediatek@lists.infradead.org, Xuefeng Li , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/24/20 6:24 PM, Chunfeng Yun wrote: > Hi Tiezhu, > > On Tue, 2020-11-24 at 17:47 +0800, Tiezhu Yang wrote: >> devm_ioremap_resource() will be not built in lib/devres.c if >> CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be >> not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not >> set, and then there exists two build errors about undefined >> reference to "devm_ioremap_resource" and "of_address_to_resource" >> in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY, >> make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it. >> >> Reported-by: kernel test robot >> Signed-off-by: Tiezhu Yang >> --- >> drivers/phy/mediatek/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig >> index 50c5e93..66df045 100644 >> --- a/drivers/phy/mediatek/Kconfig >> +++ b/drivers/phy/mediatek/Kconfig >> @@ -30,6 +30,8 @@ config PHY_MTK_XSPHY >> tristate "MediaTek XS-PHY Driver" >> depends on ARCH_MEDIATEK || COMPILE_TEST >> depends on OF >> + depends on HAS_IOMEM >> + depends on OF_ADDRESS > Why not add them into deconfig but here? In fact I don't know which way > is better and follow the kernel rule. > > Vinod and Kishon, do you have any suggestion about this? Putting them into a defconfig won't prevent random build errors while putting them here will (or at least should). >> select GENERIC_PHY >> help >> Enable this to support the SuperSpeedPlus XS-PHY transceiver for > The patch LGTM. Acked-by: Randy Dunlap thanks. -- ~Randy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel