From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7079AC001DB for ; Fri, 4 Aug 2023 06:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G1cKpvglrTEfH/ICQXGF8rJpP30yBmdId7slGqP5vcQ=; b=G0UrLEDIZcWiww FJfaXr9NhwiXGkD3pobdGr68Sc+E8kGifFmheE50SiKcylulWR4rtJlDr2J0WdwfgswF6hyLsvt39 mL7Qprr4MW7slSi8tf8xLPqLW7Qp7gwZulyXEqfXpZ7g/KWL/hYmaKIQgmiFluWwfMQwHrWeec93T Su52+Liln6sP3pt3Q2fOZKjAYorS7zcrXgp41JIufF1A/ltrBjDGUALuFODeAM2dx1yDWurRPJWSv xkviL+dKSImoZzUdtTFEOdD1ps4VtXCWWXwVl2wxVmej1RYlQI6o9phhL3siE/xtvg9lB2tsGZ2+H TvTTAxUmOhbmzm2U5EPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRoGn-00BfyT-1F; Fri, 04 Aug 2023 06:26:41 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRoGk-00Bfy6-2a for linux-arm-kernel@lists.infradead.org; Fri, 04 Aug 2023 06:26:40 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3746QR3W014030; Fri, 4 Aug 2023 01:26:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691130387; bh=FOBxZe1iIrsfnpRnsy5tLGnb3OV7R2WOTStpJEJck/g=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=k6Orwcv8QSwZHqMVXga5AwOHzGzX9R48UFKRexVV5GZbg0mczd7ofd5+rt7htOiUH tYzaBJ3jmRnuHi1fjeasgMfajx+kVqWlf7v3nCWOzttwyfDWdrr7Vr67F0jYPFudVq 7HoFwPspSVafojoudG1aIPK59YM9bX3lZXs6zvRQ= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3746QQbO096969 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 4 Aug 2023 01:26:26 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 4 Aug 2023 01:26:26 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 4 Aug 2023 01:26:26 -0500 Received: from [172.24.227.217] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3746QKrw119574; Fri, 4 Aug 2023 01:26:20 -0500 Message-ID: Date: Fri, 4 Aug 2023 11:56:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/4] dt-bindings: net: Add ICSS IEP Content-Language: en-US To: Conor Dooley , MD Danish Anwar CC: Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , , , , , , , References: <20230803110153.3309577-1-danishanwar@ti.com> <20230803110153.3309577-2-danishanwar@ti.com> <20230803-guacamole-buddy-d8179f11615e@spud> From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: <20230803-guacamole-buddy-d8179f11615e@spud> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230803_232638_918012_2D6C66F5 X-CRM114-Status: GOOD ( 19.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Conor, On 03/08/23 8:57 pm, Conor Dooley wrote: > On Thu, Aug 03, 2023 at 04:31:50PM +0530, MD Danish Anwar wrote: >> From: Md Danish Anwar >> >> Add DT binding documentation for ICSS IEP module. >> >> Signed-off-by: Md Danish Anwar >> --- >> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> new file mode 100644 >> index 000000000000..79cd72b330a6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) module >> + >> +maintainers: >> + - Md Danish Anwar >> + >> +properties: >> + compatible: >> + enum: >> + - ti,am654-icss-iep # for K3 AM65x, J721E and AM64x SoCs > > No. ti,am654-icss-iep is for am654. You should really have compatibles > specific to the SoC - is there a reason why this has not been done? > Yes, ti,am654-icss-iep is for am654. You are right, the compatibles should be specific to SoC. Currently the upstream support is being added for only AM65x. I will remove J721E and AM64x SoCs from the comment above and these compatibles when their support is enabled in future. Below is the updated compatible property. properties: compatible: enum: - ti,am654-icss-iep # for K3 AM65x SoCs > >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + description: phandle to the IEP source clock >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + icssg0_iep0: iep@2e000 { >> + compatible = "ti,am654-icss-iep"; >> + reg = <0x2e000 0x1000>; >> + clocks = <&icssg0_iepclk_mux>; >> + }; >> -- >> 2.34.1 >> -- Thanks and Regards, Danish. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel