From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A898C4332F for ; Mon, 14 Nov 2022 06:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:Subject:From:References:Cc:To: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uDfEDs6Hpl5LbZ41xET6V3+cXlM2Xv0Zl+xTpjFxIe0=; b=b1R+EpZyhcPZXD IySinzWH29DfKMckKxkLzCJQCeqSL5qWquZSP0Pmc37Vb7fT6CW9Bys60P7Jg6yHUwqpjsjf4z/cc eUvLKQh1rQq/B6HAo6lq/xshqFf+rUd+U4WW+awqzFYYHB1B7KMreGTl/AJeBOp0JXQuqtq+MXeGm oO/x6G67eLf3Jkm39n9gU7cmCs2pUy3/3Fl5WZ7IoX7tFjOf1AA+AOuWxABQHzMjeu6v1RMY/zF8y bOlAEUJ5DiYeRNIz1f1WIKt2pwjFG1IVIjnXfmATCHNP9ybU3/L3CfCGkUFTeNJwizBJhSrEdmCzR K9gX4SPfXDbr38nCArwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouSvP-00GF4a-4x; Mon, 14 Nov 2022 06:26:31 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ouSvL-00GF1k-PK; Mon, 14 Nov 2022 06:26:29 +0000 Received: by mail-lj1-x231.google.com with SMTP id u2so11880826ljl.3; Sun, 13 Nov 2022 22:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=b6VI+ABEZ1h4d+64TdR2Fv/MvDrZgmhBhQx9ZCHP/Hc=; b=nbs59sbEk04HhfP4ISizT/HOFFK9oht4Uzb9dfKOObUps2RPcCgGuIw2xdNq4Hv8aJ J2F0mW+RLpqoiH9V4IU3EhXNHVBhUdsM+eV983pPcWPyd9rmxC2O0J5yGvMAQSHrTChe 3dRiVVHbhqeUMFBKXDD/Oo+3FR0W/1YNUbylDbbywFHfAi9FMsstTY+4N9HGa2CBj4UM 7LhiKGYDBGPBk0hRLXJR+v4v+nB4bQBki4BBSqV8DaI8Uw6jJL7JJSzzWfHBH9FhA+am 4pgAS1rDQzBfmxL9XjgaYhT0i5rl4o0wOGN2SBo7p+IyVo4T5GTXHFHrrb2w7vhJH5NQ PIpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:content-language :references:cc:to:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b6VI+ABEZ1h4d+64TdR2Fv/MvDrZgmhBhQx9ZCHP/Hc=; b=qAk/fCaFR8xSiWe9sOFhlHcCluxilyNuo4G8Ewur5gu/lEk20ar/jBccLv80FQQUR0 Ry4yU8acwetGnrT6MEC8VzRLSYUT3KTqpDvw8DpVwhYyhLCfE7wQymxfAfE0J/3hz2OT td5RbqYj+58pjPwOpHnbQOxPhHEaeg/Yy80/FtlhO+i19h3crYdsO4ZMk91MGDfMCJH8 kBP/sjiD/vveaes02HxhxBhPYqzNTWY8EcwVV7PoZFMBbAPbGy9LQ4LrClP+rtrbVIBn NtyQK39cBPuDp2ZTK5xg2oL63Wb6CZuroFecIkUMS2/Pu3FKF5wOVn3hcfokkgfJhIcu AyAA== X-Gm-Message-State: ANoB5pmH7q3fPmgPkQqh8zfcK41XHkuB7OvCBOtHL0Wm+Myl2gyN7t4y OrPu2/zGRQO/FIUxWMiUXqQ= X-Google-Smtp-Source: AA0mqf6g4JQd9vs5Ov2KL2xebg9fydvdju7pLnvavXU+fGrclQlYXmgPDCLzOem8A+R9KznkAVyk0A== X-Received: by 2002:a2e:8751:0:b0:277:313e:454e with SMTP id q17-20020a2e8751000000b00277313e454emr3565669ljj.446.1668407180722; Sun, 13 Nov 2022 22:26:20 -0800 (PST) Received: from ?IPV6:2001:14ba:16f3:4a00::7? (dc75zzyyyyyyyyyyyyydt-3.rev.dnainternet.fi. [2001:14ba:16f3:4a00::7]) by smtp.gmail.com with ESMTPSA id c10-20020a056512324a00b0048af3c090f8sm1712909lfr.13.2022.11.13.22.26.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Nov 2022 22:26:20 -0800 (PST) Message-ID: Date: Mon, 14 Nov 2022 08:26:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Aidan MacDonald , lee@kernel.org Cc: mani@kernel.org, cristian.ciocaltea@gmail.com, wens@csie.org, tharvey@gateworks.com, cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org, brgl@bgdev.pl, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, jernej.skrabec@gmail.com, samuel@sholland.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20221112151835.39059-1-aidanmacdonald.0x0@gmail.com> <20221112151835.39059-11-aidanmacdonald.0x0@gmail.com> Content-Language: en-US From: Matti Vaittinen Subject: Re: [PATCH 10/18] mfd: rohm-bd71828: Replace irqchip mask_invert with unmask_base In-Reply-To: <20221112151835.39059-11-aidanmacdonald.0x0@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221113_222627_891993_CAC1134D X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/12/22 17:18, Aidan MacDonald wrote: > Remove use of the deprecated mask_invert flag. Inverted mask > registers (where a '1' bit enables an IRQ) can be described more > directly as an unmask register. > > Signed-off-by: Aidan MacDonald Reviewed-by: Matti Vaittinen > --- > drivers/mfd/rohm-bd71828.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c > index 714d9fcbf07b..3c5c6c393650 100644 > --- a/drivers/mfd/rohm-bd71828.c > +++ b/drivers/mfd/rohm-bd71828.c > @@ -413,9 +413,8 @@ static struct regmap_irq_chip bd71828_irq_chip = { > .irqs = &bd71828_irqs[0], > .num_irqs = ARRAY_SIZE(bd71828_irqs), > .status_base = BD71828_REG_INT_BUCK, > - .mask_base = BD71828_REG_INT_MASK_BUCK, > + .unmask_base = BD71828_REG_INT_MASK_BUCK, > .ack_base = BD71828_REG_INT_BUCK, > - .mask_invert = true, > .init_ack_masked = true, > .num_regs = 12, > .num_main_regs = 1, > @@ -430,9 +429,8 @@ static struct regmap_irq_chip bd71815_irq_chip = { > .irqs = &bd71815_irqs[0], > .num_irqs = ARRAY_SIZE(bd71815_irqs), > .status_base = BD71815_REG_INT_STAT_01, > - .mask_base = BD71815_REG_INT_EN_01, > + .unmask_base = BD71815_REG_INT_EN_01, > .ack_base = BD71815_REG_INT_STAT_01, > - .mask_invert = true, > .init_ack_masked = true, > .num_regs = 12, > .num_main_regs = 1, -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel