From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C143C00140 for ; Wed, 10 Aug 2022 13:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OJiaZGK7FiHEqoqfVSTDwJjq0AgLMDV+YJrJeVb1Rnk=; b=QO0XcFO03HMbbg KOo6ZsxD8v9yy+WjIr2Ttdnh7dkdT0IYLyRBzXzji1JATSguQMaECR6G2kgFSnoqxbG354qvQi9nF Uor/UVpzv5dgnQc4FJ24cO1YzVhaTRwAImbVyYTHbzaNC0mWFhsqtNLZNkIX6Ney3QdK4L/933KH3 u6mViecRfMEIBdiiJagd3agyFRtcUsLe6Se9eUXFyzqMbWp1wQ5ol/rOygG2/4GBQ8vT8sjQCpWIp o2WGKuB3VX8YohHGs3/htnVe0Zun+kc4MnJHFrvWZDQ4e93+McATJBSamSMiawbwiC8RrHvEuiZ4e nDLPWuKl5nHTQHQ0UTcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLlYW-00Bwxm-MN; Wed, 10 Aug 2022 13:15:28 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLlYP-00Bwve-C2 for linux-arm-kernel@lists.infradead.org; Wed, 10 Aug 2022 13:15:25 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27A9YPt2022853; Wed, 10 Aug 2022 15:15:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=rkpHv8Tbh6b+APur6AAgNWkVAtNoRSLElkQ+Ih3mAgQ=; b=6hXZBpjPuIjZqE4eqHtYmkWVRABPpkWAAiwdbmrONw++06+XoIhLE+Cj78ukYOtf2/hO sWDKmGcSSEf7TAzfybv00k9q0cg0EP0VjIzhu5AvcdiOUdQDO6VHLBhRkJz/fhLsxhZY 9u9AumrORfRWG/rzyTmdlRYzo8OxuKEOWs2PqoJZVX68AymXzZlGIGweqy2GmS8+d56a atgFS8RxGgbJFuDe0QyJxJvllire8LXNz+twwMU5JFyQeZOZgenTONY/H1kOxJTHhT34 FBsssktjpmStdVfGEY7IAyY+tjpshpb8V1f//6ha+NQmnSxMt7XGMgHYFBuenPqGCSua Nw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3huwrr5158-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Aug 2022 15:15:13 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0C8F710002A; Wed, 10 Aug 2022 15:15:12 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1B05E2132EC; Wed, 10 Aug 2022 15:15:10 +0200 (CEST) Received: from [10.201.21.72] (10.75.127.121) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Wed, 10 Aug 2022 15:15:09 +0200 Message-ID: Date: Wed, 10 Aug 2022 15:15:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/2] spi: stm32_qspi: Add transfer_one_message() spi callback Content-Language: en-US To: Mark Brown CC: Alexandre Torgue , , , , , References: <20220810093215.794977-1-patrice.chotard@foss.st.com> <20220810093215.794977-2-patrice.chotard@foss.st.com> From: Patrice CHOTARD In-Reply-To: X-Originating-IP: [10.75.127.121] X-ClientProxiedBy: GPXDAG2NODE4.st.com (10.75.127.68) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-10_08,2022-08-10_01,2022-06-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220810_061521_815347_580964A7 X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark On 8/10/22 15:06, Mark Brown wrote: > On Wed, Aug 10, 2022 at 11:32:14AM +0200, patrice.chotard@foss.st.com wrote: > >> Signed-off-by: Patrice Chotard >> >> v2: _ use parallel-memories property >> _ set auto_runtime_pm to true >> _ remove pm_runtime_*() usage in transfer_one_message() callback >> --- > > The changelog should come after the --- so that it gets automatically > stripped out by tooling. No need to resend just for this. > >> + /* >> + * Dual flash mode is only enable in case "parallel-memories" and >> + * "cs-gpios" properties are found in DT >> + */ >> + if (of_property_read_bool(dev->of_node, "parallel-memories") && >> + of_gpio_named_count(dev->of_node, "cs-gpios")) { >> + qspi->cr_reg = CR_DFM; >> + dev_dbg(dev, "Dual flash mode enable"); >> + } > > Do we need to add something to the DT bindings to indicate that > parallel-memories is valid? You mean in the st,stm32-qspi.yaml DT binding file ? Right i think it could be preferable to add it. Patrice _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel