From: "Rafał Miłecki" <zajec5@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: "Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"John Crispin" <john@phrozen.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 1/2] dt-bindings: pwm: mediatek,mt2712: add compatible for MT7988
Date: Wed, 14 Feb 2024 07:34:40 +0100 [thread overview]
Message-ID: <d4391868-ddcd-4f66-b539-28d245fa83df@gmail.com> (raw)
In-Reply-To: <20240213-resource-evaluator-0754cfd5882d@spud>
On 13.02.2024 19:18, Conor Dooley wrote:
> On Tue, Feb 13, 2024 at 05:46:32PM +0100, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> MT7988 has on-SoC controller that can control up to 8 PWMs.
>
> I see a binding and a dts patch, but no driver patch, how come?
I believe that to avoid cross-trees patchsets (which are sometimes
tricky for maintainers) there are two ways of submiting such changes:
1. dt-binding + driver; then (separately) DTS
2. dt-binding + DTS; then (separately) driver
I chose later in this case as my personal priority right now is to deal
with all MediaTek DTS files.
Is that wrong or unacceptable?
> Also, what makes this incompatibly different with the other devices in
> the binding, like the 8183?
It can control 8 PWMs unlike any other SoC block except for MT2712.
It uses different registers than MT2712 thought.
> Cheers,
> Conor.
>
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>> Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml b/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml
>> index 0fbe8a6469eb..a5c308801619 100644
>> --- a/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml
>> @@ -24,6 +24,7 @@ properties:
>> - mediatek,mt7629-pwm
>> - mediatek,mt7981-pwm
>> - mediatek,mt7986-pwm
>> + - mediatek,mt7988-pwm
>> - mediatek,mt8183-pwm
>> - mediatek,mt8365-pwm
>> - mediatek,mt8516-pwm
>> --
>> 2.35.3
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-14 6:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 16:46 [PATCH 1/2] dt-bindings: pwm: mediatek,mt2712: add compatible for MT7988 Rafał Miłecki
2024-02-13 16:46 ` [PATCH 2/2] arm64: dts: mediatek: mt7988: add PWM controller Rafał Miłecki
2024-02-14 9:09 ` AngeloGioacchino Del Regno
2024-02-14 9:24 ` Rafał Miłecki
2024-02-14 9:33 ` AngeloGioacchino Del Regno
2024-02-13 17:48 ` [PATCH 1/2] dt-bindings: pwm: mediatek,mt2712: add compatible for MT7988 Uwe Kleine-König
2024-02-14 9:05 ` Krzysztof Kozlowski
2024-02-16 13:10 ` Uwe Kleine-König
2024-02-13 18:18 ` Conor Dooley
2024-02-14 6:34 ` Rafał Miłecki [this message]
2024-02-14 9:27 ` AngeloGioacchino Del Regno
2024-02-14 10:06 ` Conor Dooley
2024-02-14 10:19 ` Rafał Miłecki
2024-02-16 8:56 ` Uwe Kleine-König
2024-02-16 9:07 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4391868-ddcd-4f66-b539-28d245fa83df@gmail.com \
--to=zajec5@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).